[FIR] Disallow operators not on functions

Introduce `NOT_FUNCTION_AS_OPERATOR` and use it instead of `PROPERTY_AS_OPERATOR`

^KT-65881 Fixed

Merge-request: KT-MR-14547

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/diagnostics/KtFirDataClassConverters.kt

@@ -4529,9 +4529,10 @@ internal val KT_DIAGNOSTIC_CONVERTER = KtDiagnosticConverterBuilder.buildConvert
             token,
         )
     }
-    add(FirErrors.PROPERTY_AS_OPERATOR) { firDiagnostic ->
-        PropertyAsOperatorImpl(
-            firSymbolBuilder.variableLikeBuilder.buildVariableSymbol(firDiagnostic.a),
+    add(FirErrors.NOT_FUNCTION_AS_OPERATOR) { firDiagnostic ->
+        NotFunctionAsOperatorImpl(
+            firDiagnostic.a,
+            firSymbolBuilder.buildSymbol(firDiagnostic.b),
             firDiagnostic as KtPsiDiagnostic,
             token,
         )

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/diagnostics/KtFirDiagnostics.kt

@@ -3156,9 +3156,10 @@ sealed interface KtFirDiagnostic<PSI : PsiElement> : KtDiagnosticWithPsi<PSI> {
         val operator: String
     }
 
-    interface PropertyAsOperator : KtFirDiagnostic<PsiElement> {
-        override val diagnosticClass get() = PropertyAsOperator::class
-        val property: KtVariableSymbol
+    interface NotFunctionAsOperator : KtFirDiagnostic<PsiElement> {
+        override val diagnosticClass get() = NotFunctionAsOperator::class
+        val elementName: String
+        val elementSymbol: KtSymbol
     }
 
     interface DslScopeViolation : KtFirDiagnostic<PsiElement> {

analysis/analysis-api-fir/src/org/jetbrains/kotlin/analysis/api/fir/diagnostics/KtFirDiagnosticsImpl.kt

@@ -3800,11 +3800,12 @@ internal class AssignmentOperatorShouldReturnUnitImpl(
     token: KtLifetimeToken,
 ) : KtAbstractFirDiagnostic<KtExpression>(firDiagnostic, token), KtFirDiagnostic.AssignmentOperatorShouldReturnUnit
 
-internal class PropertyAsOperatorImpl(
-    override val property: KtVariableSymbol,
+internal class NotFunctionAsOperatorImpl(
+    override val elementName: String,
+    override val elementSymbol: KtSymbol,
     firDiagnostic: KtPsiDiagnostic,
     token: KtLifetimeToken,
-) : KtAbstractFirDiagnostic<PsiElement>(firDiagnostic, token), KtFirDiagnostic.PropertyAsOperator
+) : KtAbstractFirDiagnostic<PsiElement>(firDiagnostic, token), KtFirDiagnostic.NotFunctionAsOperator
 
 internal class DslScopeViolationImpl(
     override val calleeSymbol: KtSymbol,