From 2bff38dd27e236bfdf844170c3ab59ee17d5d69a Mon Sep 17 00:00:00 2001 From: "Alexander.Likhachev" Date: Mon, 30 Jan 2023 21:35:22 +0100 Subject: [PATCH] [IC] Fix transaction wasn't marked as unsuccessful on execution exception #KT-56052 In Progress --- .../kotlin/incremental/CompilationTransaction.kt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/build-common/src/org/jetbrains/kotlin/incremental/CompilationTransaction.kt b/build-common/src/org/jetbrains/kotlin/incremental/CompilationTransaction.kt index 0b57b5e80a0..4a48a0f7ba2 100644 --- a/build-common/src/org/jetbrains/kotlin/incremental/CompilationTransaction.kt +++ b/build-common/src/org/jetbrains/kotlin/incremental/CompilationTransaction.kt @@ -126,6 +126,12 @@ abstract class BaseCompilationTransaction : CompilationTransaction { executionThrowable?.addSuppressed(exception) executionThrowable ?: exception } + + protected fun checkForExecutionException() { + if (executionThrowable != null) { + isSuccessful = false + } + } } /** @@ -143,6 +149,7 @@ class NonRecoverableCompilationTransaction : CompilationTransaction, BaseCompila } override fun close() { + checkForExecutionException() closeCachesManager()?.let { throw it } @@ -239,6 +246,7 @@ class RecoverableCompilationTransaction( } override fun close() { + checkForExecutionException() val mainException = closeCachesManager() val exceptionToThrow = runCatching { if (isSuccessful) {