azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent multiple declarations of update check when many files have changed

Browse Source
This commit is contained in:
Nikolay Krasko
2013-10-25 20:48:30 +04:00
parent 5d74068bbc
commit 2b3a6b5f57
1 changed files with 17 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/jet/plugin/configuration/ui/AbsentJdkAnnotationsComponent.java
+17 -21
View File
@@ -29,8 +29,9 @@ import com.intellij.openapi.projectRoots.Sdk;
import com.intellij.openapi.roots.ModuleRootAdapter; import com.intellij.openapi.roots.ModuleRootAdapter;
import com.intellij.openapi.roots.ModuleRootEvent; import com.intellij.openapi.roots.ModuleRootEvent;
import com.intellij.openapi.roots.ModuleRootManager; import com.intellij.openapi.roots.ModuleRootManager;
import com.intellij.openapi.vfs.*; import com.intellij.openapi.vfs.VirtualFileManager;
import com.intellij.openapi.vfs.impl.BulkVirtualFileListenerAdapter; import com.intellij.openapi.vfs.newvfs.BulkFileListener;
import com.intellij.openapi.vfs.newvfs.events.*;
import com.intellij.util.messages.MessageBusConnection; import com.intellij.util.messages.MessageBusConnection;
import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.NotNull;
import org.jetbrains.jet.plugin.configuration.AbsentSdkAnnotationsNotificationManager; import org.jetbrains.jet.plugin.configuration.AbsentSdkAnnotationsNotificationManager;
@@ -40,6 +41,7 @@ import org.jetbrains.jet.plugin.project.ProjectStructureUtil;
import org.jetbrains.jet.plugin.versions.KotlinRuntimeLibraryUtil; import org.jetbrains.jet.plugin.versions.KotlinRuntimeLibraryUtil;
import java.util.Collection; import java.util.Collection;
import java.util.List;
import java.util.Set; import java.util.Set;
public class AbsentJdkAnnotationsComponent extends AbstractProjectComponent { public class AbsentJdkAnnotationsComponent extends AbstractProjectComponent {
@@ -73,27 +75,18 @@ public class AbsentJdkAnnotationsComponent extends AbstractProjectComponent {
} }
}); });
connection.subscribe(VirtualFileManager.VFS_CHANGES, new BulkVirtualFileListenerAdapter(new VirtualFileAdapter() { connection.subscribe(VirtualFileManager.VFS_CHANGES, new BulkFileListener.Adapter() {
@Override @Override
public void fileDeleted(VirtualFileEvent event) { public void after(@NotNull List<? extends VFileEvent> events) {
showNotificationIfNeeded(); for (VFileEvent event : events) {
if (event instanceof VFileCreateEvent || event instanceof VFileDeleteEvent ||
event instanceof VFileMoveEvent || event instanceof VFileCopyEvent) {
showNotificationIfNeeded();
break;
}
}
} }
});
@Override
public void fileCreated(VirtualFileEvent event) {
showNotificationIfNeeded();
}
@Override
public void fileMoved(VirtualFileMoveEvent event) {
showNotificationIfNeeded();
}
@Override
public void fileCopied(VirtualFileCopyEvent event) {
showNotificationIfNeeded();
}
}));
} }
public void showNotificationIfNeeded() { public void showNotificationIfNeeded() {
@@ -102,6 +95,8 @@ public class AbsentJdkAnnotationsComponent extends AbstractProjectComponent {
public void run() { public void run() {
Collection<Sdk> sdks = collectSdksWithoutAnnotations(); Collection<Sdk> sdks = collectSdksWithoutAnnotations();
if (sdks.isEmpty()) return; if (sdks.isEmpty()) return;
//noinspection StaticFieldReferencedViaSubclass
AbsentSdkAnnotationsNotificationManager.instance$.notify(myProject, sdks); AbsentSdkAnnotationsNotificationManager.instance$.notify(myProject, sdks);
} }
}); });
@@ -126,6 +121,7 @@ public class AbsentJdkAnnotationsComponent extends AbstractProjectComponent {
return false; return false;
} }
@SuppressWarnings("StaticMethodReferencedViaSubclass")
boolean isAndroidSdk = NotificationsPackage.isAndroidSdk(sdk); boolean isAndroidSdk = NotificationsPackage.isAndroidSdk(sdk);
return !(isAndroidSdk && !KotlinRuntimeLibraryUtil.androidSdkAnnotationsArePresent(sdk)); return !(isAndroidSdk && !KotlinRuntimeLibraryUtil.androidSdkAnnotationsArePresent(sdk));
} }