From 2aaf589ef226bf6307893e31d76304ba01622eeb Mon Sep 17 00:00:00 2001 From: Yan Zhulanow Date: Tue, 16 May 2023 20:21:41 +0900 Subject: [PATCH] [LL API] Minor, simplify call sites in 'transformAnnotations()' --- .../LLFirAnnotationArgumentMappingLazyResolver.kt | 7 +------ .../LLFirAnnotationArgumentsLazyResolver.kt | 13 ++++++------- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentMappingLazyResolver.kt b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentMappingLazyResolver.kt index cf1f9bb662b..fa21636291b 100644 --- a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentMappingLazyResolver.kt +++ b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentMappingLazyResolver.kt @@ -6,23 +6,18 @@ package org.jetbrains.kotlin.analysis.low.level.api.fir.transformers import org.jetbrains.kotlin.analysis.low.level.api.fir.api.targets.LLFirResolveTarget -import org.jetbrains.kotlin.analysis.low.level.api.fir.api.throwUnexpectedFirElementError import org.jetbrains.kotlin.analysis.low.level.api.fir.file.builder.LLFirLockProvider -import org.jetbrains.kotlin.analysis.low.level.api.fir.lazy.resolve.FirLazyBodiesCalculator import org.jetbrains.kotlin.analysis.low.level.api.fir.lazy.resolve.LLFirPhaseUpdater import org.jetbrains.kotlin.analysis.low.level.api.fir.util.checkAnnotationArgumentsMappingIsResolved import org.jetbrains.kotlin.analysis.low.level.api.fir.util.checkPhase import org.jetbrains.kotlin.fir.FirAnnotationContainer import org.jetbrains.kotlin.fir.FirElementWithResolveState -import org.jetbrains.kotlin.fir.FirFileAnnotationsContainer import org.jetbrains.kotlin.fir.FirSession import org.jetbrains.kotlin.fir.declarations.* import org.jetbrains.kotlin.fir.expressions.FirAnnotationCall -import org.jetbrains.kotlin.fir.resolve.ResolutionMode import org.jetbrains.kotlin.fir.resolve.ScopeSession import org.jetbrains.kotlin.fir.resolve.transformers.body.resolve.FirTowerDataContextCollector import org.jetbrains.kotlin.fir.resolve.transformers.plugin.FirAnnotationArgumentsMappingTransformer -import org.jetbrains.kotlin.fir.visitors.transformSingle internal object LLFirAnnotationArgumentMappingLazyResolver : LLFirLazyResolver(FirResolvePhase.ANNOTATIONS_ARGUMENTS_MAPPING) { override fun resolve( @@ -71,6 +66,6 @@ private class LLFirAnnotationArgumentsMappingTargetResolver( ) override fun doLazyResolveUnderLock(target: FirElementWithResolveState) { - transformer.transformAnnotations(target) + transformAnnotations(target) } } diff --git a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentsLazyResolver.kt b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentsLazyResolver.kt index d72387290dc..985d9c45c0f 100644 --- a/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentsLazyResolver.kt +++ b/analysis/low-level-api-fir/src/org/jetbrains/kotlin/analysis/low/level/api/fir/transformers/LLFirAnnotationArgumentsLazyResolver.kt @@ -20,7 +20,6 @@ import org.jetbrains.kotlin.fir.FirSession import org.jetbrains.kotlin.fir.declarations.* import org.jetbrains.kotlin.fir.resolve.ResolutionMode import org.jetbrains.kotlin.fir.resolve.ScopeSession -import org.jetbrains.kotlin.fir.resolve.transformers.body.resolve.FirAbstractBodyResolveTransformerDispatcher import org.jetbrains.kotlin.fir.resolve.transformers.body.resolve.FirTowerDataContextCollector import org.jetbrains.kotlin.fir.resolve.transformers.plugin.FirAnnotationArgumentsResolveTransformer import org.jetbrains.kotlin.fir.types.FirResolvedTypeRef @@ -84,20 +83,20 @@ private class LLFirAnnotationArgumentsTargetResolver( override fun doLazyResolveUnderLock(target: FirElementWithResolveState) { FirLazyBodiesCalculator.calculateAnnotations(target) - transformer.transformAnnotations(target) + transformAnnotations(target) } } -internal fun FirAbstractBodyResolveTransformerDispatcher.transformAnnotations(target: FirElementWithResolveState) { +internal fun LLFirAbstractBodyTargetResolver.transformAnnotations(target: FirElementWithResolveState) { when { target is FirRegularClass -> { - target.transformAnnotations(declarationsTransformer, ResolutionMode.ContextIndependent) - target.transformTypeParameters(declarationsTransformer, ResolutionMode.ContextIndependent) - target.transformSuperTypeRefs(declarationsTransformer, ResolutionMode.ContextIndependent) + target.transformAnnotations(transformer.declarationsTransformer, ResolutionMode.ContextIndependent) + target.transformTypeParameters(transformer.declarationsTransformer, ResolutionMode.ContextIndependent) + target.transformSuperTypeRefs(transformer.declarationsTransformer, ResolutionMode.ContextIndependent) } target.isRegularDeclarationWithAnnotation -> { - target.transformSingle(this, ResolutionMode.ContextIndependent) + target.transformSingle(transformer, ResolutionMode.ContextIndependent) } else -> throwUnexpectedFirElementError(target)