Revert "Set minimal supported Gradle version to 6.7.1."

Temporary until 1.6.20 release branching.

This reverts commit 4c3404888a.

^KT-49733 Open
This commit is contained in:
Yahor Berdnikau
2021-11-26 10:54:21 +01:00
committed by TeamCityServer
parent 2ae10f4378
commit 2aa1c187d9
16 changed files with 32 additions and 24 deletions
-1
View File
@@ -61,7 +61,6 @@ val kotlinGradlePluginAndItsRequired = arrayOf(
":kotlin-stdlib-jdk7", ":kotlin-stdlib-jdk7",
":kotlin-stdlib-jdk8", ":kotlin-stdlib-jdk8",
":kotlin-stdlib-js", ":kotlin-stdlib-js",
":kotlin-stdlib-wasm",
":examples:annotation-processor-example", ":examples:annotation-processor-example",
":kotlin-script-runtime", ":kotlin-script-runtime",
":kotlin-scripting-common", ":kotlin-scripting-common",
@@ -173,6 +173,7 @@ class ConfigurationCacheIT : AbstractConfigurationCacheIT() {
} }
@SimpleGradlePluginTests @SimpleGradlePluginTests
@GradleTestVersions(minVersion = TestVersions.Gradle.G_6_6)
abstract class AbstractConfigurationCacheIT : KGPBaseTest() { abstract class AbstractConfigurationCacheIT : KGPBaseTest() {
override val defaultBuildOptions = override val defaultBuildOptions =
super.defaultBuildOptions.copy(configurationCache = true) super.defaultBuildOptions.copy(configurationCache = true)
@@ -19,14 +19,13 @@ package org.jetbrains.kotlin.gradle
import org.gradle.util.GradleVersion import org.gradle.util.GradleVersion
import org.jetbrains.kotlin.com.google.common.base.Objects import org.jetbrains.kotlin.com.google.common.base.Objects
import org.jetbrains.kotlin.gradle.GradleVersionRequired.Companion.OLDEST_SUPPORTED import org.jetbrains.kotlin.gradle.GradleVersionRequired.Companion.OLDEST_SUPPORTED
import org.jetbrains.kotlin.gradle.utils.minSupportedGradleVersion
import org.junit.Assume import org.junit.Assume
sealed class GradleVersionRequired(val minVersion: String, val maxVersion: String?) { sealed class GradleVersionRequired(val minVersion: String, val maxVersion: String?) {
companion object { companion object {
const val OLDEST_SUPPORTED = minSupportedGradleVersion const val OLDEST_SUPPORTED = "6.1.1"
val FOR_MPP_SUPPORT = AtLeast(OLDEST_SUPPORTED) val FOR_MPP_SUPPORT = AtLeast("6.1.1")
} }
class Exact(version: String) : GradleVersionRequired(version, version) { class Exact(version: String) : GradleVersionRequired(version, version) {
@@ -11,6 +11,8 @@ import org.jetbrains.kotlin.gradle.plugin.KotlinJsCompilerType
import org.jetbrains.kotlin.gradle.testbase.* import org.jetbrains.kotlin.gradle.testbase.*
import org.junit.jupiter.api.DisplayName import org.junit.jupiter.api.DisplayName
@JsGradlePluginTests
@GradleTestVersions(minVersion = TestVersions.Gradle.G_6_6)
abstract class AbstractJsConfigurationCacheIT(protected val irBackend: Boolean) : KGPBaseTest() { abstract class AbstractJsConfigurationCacheIT(protected val irBackend: Boolean) : KGPBaseTest() {
private val defaultJsOptions = BuildOptions.JsOptions( private val defaultJsOptions = BuildOptions.JsOptions(
useIrBackend = irBackend, useIrBackend = irBackend,
@@ -89,8 +91,6 @@ abstract class AbstractJsConfigurationCacheIT(protected val irBackend: Boolean)
} }
} }
@JsGradlePluginTests
class JsConfigurationCacheIT : AbstractJsConfigurationCacheIT(irBackend = false) class JsConfigurationCacheIT : AbstractJsConfigurationCacheIT(irBackend = false)
@JsGradlePluginTests
class JsIrConfigurationCacheIT : AbstractJsConfigurationCacheIT(irBackend = true) class JsIrConfigurationCacheIT : AbstractJsConfigurationCacheIT(irBackend = true)
@@ -240,6 +240,7 @@ class JvmTargetValidationTest : KGPBaseTest() {
} }
@DisplayName("Should do JVM target validation if java sources are added and configuration cache is reused") @DisplayName("Should do JVM target validation if java sources are added and configuration cache is reused")
@GradleTestVersions(minVersion = TestVersions.Gradle.G_6_6)
@GradleTest @GradleTest
@ExperimentalPathApi @ExperimentalPathApi
internal fun shouldDoJvmTargetValidationOnNewJavaSourcesAndConfigurationCacheReuse(gradleVersion: GradleVersion) { internal fun shouldDoJvmTargetValidationOnNewJavaSourcesAndConfigurationCacheReuse(gradleVersion: GradleVersion) {
@@ -146,6 +146,9 @@ class Kapt3Android42IT : BaseGradleIT() {
KAPT_SUCCESSFUL_REGEX.findAll(this.output).count() > 0 KAPT_SUCCESSFUL_REGEX.findAll(this.output).count() > 0
} }
override val defaultGradleVersion: GradleVersionRequired
get() = GradleVersionRequired.AtLeast("6.7.1")
override fun defaultBuildOptions(): BuildOptions = override fun defaultBuildOptions(): BuildOptions =
super.defaultBuildOptions().copy( super.defaultBuildOptions().copy(
kaptOptions = kaptOptions(), kaptOptions = kaptOptions(),
@@ -276,7 +276,8 @@ class KaptIncrementalWithIsolatingApt : KaptIncrementalIT() {
if (System.getProperty("os.name")?.toLowerCase()?.contains("windows") == true) return if (System.getProperty("os.name")?.toLowerCase()?.contains("windows") == true) return
val project = Project( val project = Project(
projectName = "kaptIncrementalWithParceler" projectName = "kaptIncrementalWithParceler",
gradleVersionRequirement = GradleVersionRequired.AtLeast("6.7.1")
).apply { ).apply {
setupWorkingDir() setupWorkingDir()
} }
@@ -1022,9 +1022,6 @@ abstract class AbstractKotlin2JsGradlePluginIT(protected val irBackend: Boolean)
@JsGradlePluginTests @JsGradlePluginTests
class GeneralKotlin2JsGradlePluginIT : KGPBaseTest() { class GeneralKotlin2JsGradlePluginIT : KGPBaseTest() {
// TODO: This test fails with deprecation error on Gradle <7.0
// Should be fixed via planned fixes in Kotlin/JS plugin: https://youtrack.jetbrains.com/issue/KFC-252
@GradleTestVersions(minVersion = TestVersions.Gradle.G_7_0)
@DisplayName("js with both backends mode builds successfully") @DisplayName("js with both backends mode builds successfully")
@GradleTest @GradleTest
fun testJsBothModeWithTests(gradleVersion: GradleVersion) { fun testJsBothModeWithTests(gradleVersion: GradleVersion) {
@@ -1169,7 +1169,8 @@ class KotlinGradleIT : BaseGradleIT() {
@Test @Test
fun testKtKt35942InternalsFromMainInTestViaTransitiveDepsAndroid() = with( fun testKtKt35942InternalsFromMainInTestViaTransitiveDepsAndroid() = with(
Project( Project(
projectName = "kt-35942-android" projectName = "kt-35942-android",
gradleVersionRequirement = GradleVersionRequired.AtLeast("6.7.1")
) )
) { ) {
build( build(
@@ -13,10 +13,7 @@ import java.util.zip.ZipFile
import kotlin.test.assertNotNull import kotlin.test.assertNotNull
class KotlinJsIrLibraryGradlePluginIT : BaseGradleIT() { class KotlinJsIrLibraryGradlePluginIT : BaseGradleIT() {
// TODO: This suite is failing with deprecation error on Gradle <7.0 versions override val defaultGradleVersion = GradleVersionRequired.AtLeast("6.1")
// Should be fixed via planned fixes in Kotlin/JS plugin: https://youtrack.jetbrains.com/issue/KFC-252
override val defaultGradleVersion: GradleVersionRequired
get() = GradleVersionRequired.AtLeast("7.0")
override fun defaultBuildOptions(): BuildOptions = override fun defaultBuildOptions(): BuildOptions =
super.defaultBuildOptions().copy( super.defaultBuildOptions().copy(
@@ -10,6 +10,12 @@ import kotlin.test.assertTrue
class KpmCompilerPluginIT : BaseGradleIT() { class KpmCompilerPluginIT : BaseGradleIT() {
/**
* Gradle implementation of KPM uses features of 6.4+ version
*/
override val defaultGradleVersion: GradleVersionRequired
get() = GradleVersionRequired.AtLeast("6.4")
@Test @Test
fun testTransientPluginOptions() { fun testTransientPluginOptions() {
val project = transformProjectWithPluginsDsl("kpmTransientPluginOptions") val project = transformProjectWithPluginsDsl("kpmTransientPluginOptions")
@@ -1841,12 +1841,7 @@ class NewMultiplatformIT : BaseGradleIT() {
} }
@Test @Test
fun testWasmJs() = with(Project( fun testWasmJs() = with(Project("new-mpp-wasm-js", gradleVersion)) {
"new-mpp-wasm-js",
// TODO: this test fails with deprecation error on Gradle <7.0
// Should be fixed via planned fixes in Kotlin/JS plugin: https://youtrack.jetbrains.com/issue/KFC-252
gradleVersionRequirement = GradleVersionRequired.AtLeast("7.0")
)) {
setupWorkingDir() setupWorkingDir()
gradleBuildScript().modify(::transformBuildScriptWithPluginsDsl) gradleBuildScript().modify(::transformBuildScriptWithPluginsDsl)
build("build") { build("build") {
@@ -204,7 +204,8 @@ class SubpluginsIT : BaseGradleIT() {
fun testKotlinVersionDowngradeInSupbrojectKt39809() = with( fun testKotlinVersionDowngradeInSupbrojectKt39809() = with(
Project( Project(
"android-dagger", "android-dagger",
directoryPrefix = "kapt2" directoryPrefix = "kapt2",
gradleVersionRequirement = GradleVersionRequired.AtLeast("6.7.1")
) )
) { ) {
setupWorkingDir() setupWorkingDir()
@@ -9,13 +9,19 @@ import org.jetbrains.kotlin.gradle.utils.minSupportedGradleVersion
interface TestVersions { interface TestVersions {
object Gradle { object Gradle {
const val G_6_1 = "6.1.1"
const val G_6_2 = "6.2.2"
const val G_6_3 = "6.3"
const val G_6_4 = "6.4.1"
const val G_6_5 = "6.5.1"
const val G_6_6 = "6.6.1"
const val G_6_7 = "6.7.1" const val G_6_7 = "6.7.1"
const val G_6_8 = "6.8.3" const val G_6_8 = "6.8.3"
const val G_6_9 = "6.9.1" const val G_6_9 = "6.9.1"
const val G_7_0 = "7.0.2" const val G_7_0 = "7.0.2"
const val G_7_1 = "7.1.1" const val G_7_1 = "7.1.1"
const val G_7_2 = "7.2" const val G_7_2 = "7.2"
const val G_7_3 = "7.3" const val G_7_3 = "7.3-rc-2"
const val MIN_SUPPORTED = minSupportedGradleVersion const val MIN_SUPPORTED = minSupportedGradleVersion
const val MAX_SUPPORTED = G_7_0 const val MAX_SUPPORTED = G_7_0
} }
@@ -133,6 +133,7 @@ class GradleAndJdkArgumentsProvider : GradleArgumentsProvider() {
companion object { companion object {
private val jdkGradleCompatibilityMatrix = mapOf( private val jdkGradleCompatibilityMatrix = mapOf(
JavaVersion.VERSION_14 to GradleVersion.version(TestVersions.Gradle.G_6_3),
JavaVersion.VERSION_15 to GradleVersion.version(TestVersions.Gradle.G_6_7), JavaVersion.VERSION_15 to GradleVersion.version(TestVersions.Gradle.G_6_7),
JavaVersion.VERSION_16 to GradleVersion.version(TestVersions.Gradle.G_7_0), JavaVersion.VERSION_16 to GradleVersion.version(TestVersions.Gradle.G_7_0),
JavaVersion.VERSION_17 to GradleVersion.version(TestVersions.Gradle.G_7_3) JavaVersion.VERSION_17 to GradleVersion.version(TestVersions.Gradle.G_7_3)
@@ -31,7 +31,7 @@ import org.gradle.util.GradleVersion
import java.io.File import java.io.File
import java.io.Serializable import java.io.Serializable
const val minSupportedGradleVersion = "6.7.1" const val minSupportedGradleVersion = "6.1.1"
internal fun checkGradleCompatibility( internal fun checkGradleCompatibility(
withComponent: String = "the Kotlin Gradle plugin", withComponent: String = "the Kotlin Gradle plugin",