K1: Deprecate incorrect callable references resolution behavior

^KT-54316 Related
^KT-54832 Fixed

compiler/testData/diagnostics/tests/objects/kt21515/callableReferenceComplexCasesWithImportsOld.fir.kt

@@ -0,0 +1,74 @@
+// !LANGUAGE: -ProhibitVisibilityOfNestedClassifiersFromSupertypesOfCompanion
+
+import A.Base.Companion.FromABaseCompanion
+import B.Base.Companion.FromBBaseCompanion
+import C.Base.Companion.FromCBaseCompanion
+import D.Base.Companion.FromDBaseCompanion
+
+// ===== Case 1: LHS is a class
+//
+object A {
+    open class Base {
+        companion object {
+            class FromABaseCompanion {
+                fun foo() = 42
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = FromABaseCompanion::foo
+    }
+}
+
+// ===== Case 2: LHS is a class with companion object, function comes from class
+
+object B {
+    open class Base {
+        companion object {
+            class FromBBaseCompanion {
+                fun foo() = 42
+
+                companion object {}
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = FromBBaseCompanion::foo
+    }
+}
+
+// ==== Case 3: LHS is a class with companion object, function comes from companion
+
+object C {
+    open class Base {
+        companion object {
+            class FromCBaseCompanion {
+                companion object {
+                    fun foo() = 42
+                }
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = FromCBaseCompanion::foo
+    }
+}
+
+// ==== Case 4: LHS is an object
+
+object D {
+    open class Base {
+        companion object {
+            object FromDBaseCompanion {
+                fun foo() = 42
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = FromDBaseCompanion::foo
+    }
+}

compiler/testData/diagnostics/tests/objects/kt21515/callableReferenceComplexCasesWithImportsOld.kt

@@ -1,4 +1,3 @@
-// FIR_IDENTICAL
 // !LANGUAGE: -ProhibitVisibilityOfNestedClassifiersFromSupertypesOfCompanion
 
 import A.Base.Companion.FromABaseCompanion
@@ -54,7 +53,7 @@ object C {
     }
 
     class Derived : Base() {
-        val a = FromCBaseCompanion::foo
+        val a = <!INCORRECT_CALLABLE_REFERENCE_RESOLUTION_FOR_COMPANION_LHS!>FromCBaseCompanion::foo<!>
     }
 }
 
@@ -72,4 +71,4 @@ object D {
     class Derived : Base() {
         val a = FromDBaseCompanion::foo
     }
-}
+}

compiler/testData/diagnostics/tests/objects/kt21515/callableReferencesComplexCasesWithQualificationOld.fir.kt

@@ -0,0 +1,69 @@
+// !LANGUAGE: -ProhibitVisibilityOfNestedClassifiersFromSupertypesOfCompanion
+
+// ===== Case 1: LHS is a class
+//
+object A {
+    open class Base {
+        companion object {
+            class FromBaseCompanion {
+                fun foo() = 42
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = A.Base.Companion.FromBaseCompanion::foo
+    }
+}
+
+// ===== Case 2: LHS is a class with companion object, function comes from class
+
+object B {
+    open class Base {
+        companion object {
+            class FromBaseCompanion {
+                fun foo() = 42
+
+                companion object {}
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = B.Base.Companion.FromBaseCompanion::foo
+    }
+}
+
+// ==== Case 3: LHS is a class with companion object, function comes from companion
+
+object C {
+    open class Base {
+        companion object {
+            class FromBaseCompanion {
+                companion object {
+                    fun foo() = 42
+                }
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = C.Base.Companion.FromBaseCompanion::foo
+    }
+}
+
+// ==== Case 4: LHS is an object
+
+object D {
+    open class Base {
+        companion object {
+            object FromBaseCompanion {
+                fun foo() = 42
+            }
+        }
+    }
+
+    class Derived : Base() {
+        val a = D.Base.Companion.FromBaseCompanion::foo
+    }
+}

compiler/testData/diagnostics/tests/objects/kt21515/callableReferencesComplexCasesWithQualificationOld.kt

@@ -1,4 +1,3 @@
-// FIR_IDENTICAL
 // !LANGUAGE: -ProhibitVisibilityOfNestedClassifiersFromSupertypesOfCompanion
 
 // ===== Case 1: LHS is a class
@@ -49,7 +48,7 @@ object C {
     }
 
     class Derived : Base() {
-        val a = C.Base.Companion.FromBaseCompanion::foo
+        val a = <!INCORRECT_CALLABLE_REFERENCE_RESOLUTION_FOR_COMPANION_LHS!>C.Base.Companion.FromBaseCompanion::foo<!>
     }
 }
 
@@ -67,4 +66,4 @@ object D {
     class Derived : Base() {
         val a = D.Base.Companion.FromBaseCompanion::foo
     }
-}
+}

compiler/testData/diagnostics/tests/objects/kt21515/callableReferencesOldComplexCases.kt

@@ -48,7 +48,7 @@ object C {
     }
 
     class Derived : Base() {
-        val a = <!DEPRECATED_ACCESS_BY_SHORT_NAME!>FromBaseCompanion<!>::foo
+        val a = <!INCORRECT_CALLABLE_REFERENCE_RESOLUTION_FOR_COMPANION_LHS!><!DEPRECATED_ACCESS_BY_SHORT_NAME!>FromBaseCompanion<!>::foo<!>
     }
 }