Small fixes after review: do not set is_pure=true for named constants refactoring
This commit is contained in:
@@ -5,7 +5,6 @@ Retention(RetentionPolicy.RUNTIME)
|
||||
annotation class Ann(
|
||||
val p1: Int,
|
||||
val p2: Byte,
|
||||
val p3: Byte,
|
||||
val p4: Int,
|
||||
val p5: Int
|
||||
)
|
||||
@@ -13,7 +12,6 @@ annotation class Ann(
|
||||
Ann(
|
||||
p1 = java.lang.Byte.MAX_VALUE + 1,
|
||||
p2 = 1 + 1,
|
||||
p3 = java.lang.Byte.MAX_VALUE - 1,
|
||||
p4 = 1 + 1,
|
||||
p5 = 1.toByte() + 1
|
||||
) class MyClass
|
||||
@@ -22,7 +20,6 @@ fun box(): String {
|
||||
val annotation = javaClass<MyClass>().getAnnotation(javaClass<Ann>())!!
|
||||
if (annotation.p1 != 128) return "fail 1, expected = ${128}, actual = ${annotation.p1}"
|
||||
if (annotation.p2 != 2.toByte()) return "fail 2, expected = ${2}, actual = ${annotation.p2}"
|
||||
if (annotation.p3 != 126.toByte()) return "fail 3, expected = ${126}, actual = ${annotation.p3}"
|
||||
if (annotation.p4 != 2) return "fail 4, expected = ${2}, actual = ${annotation.p4}"
|
||||
if (annotation.p5 != 2) return "fail 5, expected = ${2}, actual = ${annotation.p5}"
|
||||
return "OK"
|
||||
|
||||
@@ -5,7 +5,6 @@ Retention(RetentionPolicy.RUNTIME)
|
||||
annotation class Ann(
|
||||
val p1: Int,
|
||||
val p2: Int,
|
||||
val p3: Long,
|
||||
val p4: Long,
|
||||
val p5: Int
|
||||
)
|
||||
@@ -13,7 +12,6 @@ annotation class Ann(
|
||||
Ann(
|
||||
p1 = java.lang.Integer.MAX_VALUE + 1,
|
||||
p2 = 1 + 1,
|
||||
p3 = java.lang.Integer.MAX_VALUE + 1,
|
||||
p4 = 1 + 1,
|
||||
p5 = 1.toInt() + 1.toInt()
|
||||
) class MyClass
|
||||
@@ -22,7 +20,6 @@ fun box(): String {
|
||||
val annotation = javaClass<MyClass>().getAnnotation(javaClass<Ann>())!!
|
||||
if (annotation.p1 != -2147483648) return "fail 1, expected = ${-2147483648}, actual = ${annotation.p1}"
|
||||
if (annotation.p2 != 2) return "fail 2, expected = ${2}, actual = ${annotation.p2}"
|
||||
if (annotation.p3 != -2147483648.toLong()) return "fail 3, expected = ${-2147483648}, actual = ${annotation.p3}"
|
||||
if (annotation.p4 != 2.toLong()) return "fail 4, expected = ${2}, actual = ${annotation.p4}"
|
||||
if (annotation.p5 != 2) return "fail 5, expected = ${2}, actual = ${annotation.p5}"
|
||||
return "OK"
|
||||
|
||||
@@ -0,0 +1,26 @@
|
||||
fun fooInt(p: Int) = p
|
||||
fun fooLong(p: Long) = p
|
||||
fun fooByte(p: Byte) = p
|
||||
fun fooShort(p: Short) = p
|
||||
|
||||
fun test() {
|
||||
fooInt(1 plus 1)
|
||||
fooByte(1 plus 1)
|
||||
fooLong(1 plus 1)
|
||||
fooShort(1 plus 1)
|
||||
|
||||
fooInt(1 times 1)
|
||||
fooByte(1 times 1)
|
||||
fooLong(1 times 1)
|
||||
fooShort(1 times 1)
|
||||
|
||||
fooInt(1 div 1)
|
||||
fooByte(1 div 1)
|
||||
fooLong(1 div 1)
|
||||
fooShort(1 div 1)
|
||||
|
||||
fooInt(1 mod 1)
|
||||
fooByte(1 mod 1)
|
||||
fooLong(1 mod 1)
|
||||
fooShort(1 mod 1)
|
||||
}
|
||||
@@ -2,7 +2,7 @@ package test
|
||||
|
||||
enum class MyEnum { A }
|
||||
|
||||
// val prop1: true
|
||||
// val prop1: null
|
||||
val prop1 = MyEnum.A
|
||||
|
||||
// val prop2: null
|
||||
|
||||
@@ -0,0 +1,9 @@
|
||||
package test
|
||||
|
||||
val NAMED_CONSTANT = 1
|
||||
|
||||
// val prop1: null
|
||||
val prop1 = NAMED_CONSTANT
|
||||
|
||||
// val prop2: null
|
||||
val prop2 = NAMED_CONSTANT + 1
|
||||
@@ -8,4 +8,4 @@ annotation class Ann(
|
||||
|
||||
Ann(1 + 1, java.lang.Long.MAX_VALUE + 1 - 1, java.lang.Long.MAX_VALUE - 1) class MyClass
|
||||
|
||||
// EXPECTED: Ann[l1 = IntegerValueType(2): IntegerValueType(2), l2 = IntegerValueType(9223372036854775807): IntegerValueType(9223372036854775807), l3 = IntegerValueType(9223372036854775806): IntegerValueType(9223372036854775806)]
|
||||
// EXPECTED: Ann[l1 = IntegerValueType(2): IntegerValueType(2), l2 = 9223372036854775807.toLong(): jet.Long, l3 = 9223372036854775806.toLong(): jet.Long]
|
||||
|
||||
@@ -18,4 +18,4 @@ Ann(
|
||||
p6 = java.lang.Long.MAX_VALUE + 1
|
||||
) class MyClass
|
||||
|
||||
// EXPECTED: Ann[p1 = IntegerValueType(128): IntegerValueType(128), p2 = IntegerValueType(32768): IntegerValueType(32768), p3 = IntegerValueType(-2147483648): IntegerValueType(-2147483648), p4 = IntegerValueType(-2147483648): IntegerValueType(-2147483648), p5 = 2147483648.toLong(): jet.Long, p6 = IntegerValueType(-9223372036854775808): IntegerValueType(-9223372036854775808)]
|
||||
// EXPECTED: Ann[p1 = 128.toInt(): jet.Int, p2 = 32768.toInt(): jet.Int, p3 = -2147483648.toInt(): jet.Int, p4 = -2147483648.toInt(): jet.Int, p5 = 2147483648.toLong(): jet.Long, p6 = -9223372036854775808.toLong(): jet.Long]
|
||||
|
||||
@@ -16,4 +16,4 @@ Ann(
|
||||
p5 = 1.toByte() + 1.toByte()
|
||||
) class MyClass
|
||||
|
||||
// EXPECTED: Ann[p1 = IntegerValueType(128): IntegerValueType(128), p2 = IntegerValueType(2): IntegerValueType(2), p3 = IntegerValueType(128): IntegerValueType(128), p4 = 2.toInt(): jet.Int, p5 = 2.toInt(): jet.Int]
|
||||
// EXPECTED: Ann[p1 = 128.toInt(): jet.Int, p2 = IntegerValueType(2): IntegerValueType(2), p3 = 128.toInt(): jet.Int, p4 = 2.toInt(): jet.Int, p5 = 2.toInt(): jet.Int]
|
||||
|
||||
@@ -16,4 +16,4 @@ Ann(
|
||||
p5 = 1.toInt() + 1.toInt()
|
||||
) class MyClass
|
||||
|
||||
// EXPECTED: Ann[p1 = IntegerValueType(-2147483648): IntegerValueType(-2147483648), p2 = IntegerValueType(2): IntegerValueType(2), p3 = IntegerValueType(-2147483648): IntegerValueType(-2147483648), p4 = 2.toInt(): jet.Int, p5 = 2.toInt(): jet.Int]
|
||||
// EXPECTED: Ann[p1 = -2147483648.toInt(): jet.Int, p2 = IntegerValueType(2): IntegerValueType(2), p3 = -2147483648.toInt(): jet.Int, p4 = 2.toInt(): jet.Int, p5 = 2.toInt(): jet.Int]
|
||||
|
||||
Reference in New Issue
Block a user