From 276923834f53ee5c0bb2da5c68d8844febeb7007 Mon Sep 17 00:00:00 2001 From: Nikita Bobko Date: Tue, 19 Jul 2022 14:52:49 +0200 Subject: [PATCH] 1/5 Replace source dependency on kotlin-reflect with binary dependency Review: https://jetbrains.team/p/kt/reviews/6753 Meaningful semantic change was splitted into 5 commits to simplify the change review. Sinle commit would be too big. Why replace source to binary: to get rid of kotlin-reflect in Kotlin plugin artifact KTIJ-22276 Technically, versions.kotlin-reflect should be the same as in minimal supported IDEA (which is 213 IDEA and 1.5.10 version of reflect) but, unfortunatelly, 1.5.10 is too old for the Kotlin repo. ScriptCompilerTest.testTypeAliases fails if you try to use such an old version: java.lang.ClassCastException: kotlin.reflect.jvm.internal.impl.serialization.deserialization.descriptors.DeserializedTypeAliasDescriptor cannot be cast to kotlin.reflect.jvm.internal.impl.descriptors.ClassDescriptor at kotlin.reflect.jvm.internal.KClassImpl$Data$nestedClasses$2.invoke(KClassImpl.kt:102) at kotlin.reflect.jvm.internal.KClassImpl$Data$nestedClasses$2.invoke(KClassImpl.kt:47) at kotlin.reflect.jvm.internal.ReflectProperties$LazySoftVal.invoke(ReflectProperties.java:92) at kotlin.reflect.jvm.internal.ReflectProperties$Val.getValue(ReflectProperties.java:31) at kotlin.reflect.jvm.internal.KClassImpl$Data.getNestedClasses(KClassImpl.kt) at kotlin.reflect.jvm.internal.KClassImpl.getNestedClasses(KClassImpl.kt:240) at org.jetbrains.kotlin.scripting.compiler.test.ScriptCompilerTest.testTypeAliases(ScriptCompilerTest.kt:46) Well, let's use 1.6.10 which is kotlin-reflect bundled into 221. --- gradle/versions.properties | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gradle/versions.properties b/gradle/versions.properties index f7a7bb26dfa..b8d0189609b 100644 --- a/gradle/versions.properties +++ b/gradle/versions.properties @@ -39,6 +39,8 @@ versions.jflex=1.7.0 versions.jline=3.3.1 versions.jsr305=1.3.9 versions.junit=4.13.2 +# kotlin-reflect has version which is bundled in minimally supported IDEA +versions.kotlin-reflect=1.6.10 versions.kotlinx-collections-immutable-jvm=0.3.1 versions.kotlinx-collections-immutable=0.3.1 versions.kotlinx-coroutines-core-jvm=1.5.0