[FIR] Add checker for uninitialized properties

This commit is contained in:
Dmitriy Novozhilov
2020-06-17 11:51:15 +03:00
parent 25621d699b
commit 26458875d5
96 changed files with 1476 additions and 1358 deletions
@@ -21,7 +21,7 @@ fun <T> runOnce(block: () -> T): T {
fun valueReassignment() {
val x: Int
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
runTwice { x = 42 }
x.inc()
}
@@ -29,12 +29,12 @@ fun valueReassignment() {
fun shadowing() {
val x: Int
runTwice { val x: Int; x = 42; x.inc() }
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun branchingFlow(a: Any?) {
val x: Int
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
if (a is String) {
runTwice { x = 42 }
}
@@ -50,18 +50,18 @@ fun branchingFlowWithMissingBranches(a: Any?) {
runTwice { x = 42 }
}
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun repeatingFlow(n: Int) {
val x: Int
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
for (i in 1..n) {
runTwice { x = 42 }
}
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun repeatingFlow2(n: Int) {
@@ -71,5 +71,5 @@ fun repeatingFlow2(n: Int) {
runTwice { x = 42 }
}
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
@@ -1,31 +0,0 @@
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
import kotlin.contracts.*
fun <T> runTwice(block: () -> T): T {
contract {
callsInPlace(block, InvocationKind.AT_LEAST_ONCE)
}
block()
return block();
};
fun testInitialization() {
var x: Int
x.inc()
runTwice { x = 42 }
x.inc()
x = 43
x.inc()
}
fun repeatingFlow(n: Int) {
var x: Int
for (i in 1..n) {
runTwice { x = 42 }
}
x.inc()
}
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
@@ -19,11 +19,11 @@ fun indefiniteFlow() {
funWithUnknownInvocations { runTwice { x = 42 } }
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun shadowing() {
var x: Int
runTwice { val x: Int; x = 42; x.inc() }
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
@@ -31,14 +31,14 @@ fun branchingIndetermineFlow(a: Any?) {
myRun { x = 43 }
}
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun nonAnonymousLambdas() {
val x: Int
val initializer = { x = 42 }
myRun(initializer)
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun multipleAssignments() {
@@ -47,7 +47,7 @@ fun multipleAssignments() {
// Val reassignment because we know that repeat's lambda called in-place
myRun { x = 42 }
}
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun funWithUnknownInvocations(block: () -> Unit) = block()
@@ -56,7 +56,7 @@ fun nestedIndefiniteAssignment() {
val x: Int
// Captured val initialization reported, because we don't know anything about funWithUnknownInvocations
funWithUnknownInvocations { myRun { x = 42 } }
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
class InitializationForbiddenInNonInitSection {
@@ -16,7 +16,7 @@ fun indefiniteVarReassignment(n: Int) {
repeat(n) {
myRun { x = 42 }
}
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun nonAnonymousLambdas() {
@@ -24,7 +24,7 @@ fun nonAnonymousLambdas() {
var x: Int
val initializer = { x = 42 }
myRun(initializer)
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun branchingIndetermineFlow(a: Any) {
@@ -39,7 +39,7 @@ fun branchingIndetermineFlow(a: Any) {
myRun { x = 43 }
}
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
fun funWithUnknownInvocations(block: () -> Unit) = block()
@@ -47,5 +47,5 @@ fun funWithUnknownInvocations(block: () -> Unit) = block()
fun nestedIndefiniteAssignment() {
val x: Int
funWithUnknownInvocations { myRun { x = 42 } }
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}
@@ -1,28 +0,0 @@
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
import kotlin.contracts.*
fun <T, R> T.myLet(block: (T) -> R): R {
contract {
callsInPlace(block, InvocationKind.EXACTLY_ONCE)
}
return block(this)
}
fun initializationWithReceiver(y: String) {
val x: Int
y.myLet { x = 42 }
x.inc()
}
fun initializationWithSafeCall(y: String?) {
val x: Int
y?.myLet { x = 42 }
x.inc()
}
fun sanityCheck(x: Int, y: String): Int {
y.let { return x }
}
@@ -1,3 +1,4 @@
// FIR_IDENTICAL
// !LANGUAGE: +AllowContractsForCustomFunctions +UseCallsInPlaceEffect
// !USE_EXPERIMENTAL: kotlin.contracts.ExperimentalContracts
// !DIAGNOSTICS: -INVISIBLE_REFERENCE -INVISIBLE_MEMBER
@@ -14,5 +14,5 @@ fun <T> inPlace(block: () -> T): T {
fun reassignmentAndNoInitializaiton() {
val x: Int
inPlace { x = 42 }
x.inc()
<!UNINITIALIZED_VARIABLE!>x<!>.inc()
}