From 258bd1e8c06701cb636b30415e4c17a3544d6878 Mon Sep 17 00:00:00 2001 From: Alexey Sedunov Date: Wed, 10 Jan 2018 16:05:15 +0300 Subject: [PATCH] Maven: Fix parsing on import to the Kotlin facet #KT-22153 Fixed --- .../kotlin/idea/maven/KotlinMavenImporter.kt | 1 - .../idea/maven/KotlinMavenImporterTest.kt | 51 +++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/KotlinMavenImporter.kt b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/KotlinMavenImporter.kt index 8b5042fe057..fee7e5bfc9d 100644 --- a/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/KotlinMavenImporter.kt +++ b/idea/idea-maven/src/org/jetbrains/kotlin/idea/maven/KotlinMavenImporter.kt @@ -175,7 +175,6 @@ class KotlinMavenImporter : MavenImporter(KOTLIN_PLUGIN_GROUP_ID, KOTLIN_PLUGIN_ } } } - argsElement?.getChildren("arg")?.mapNotNullTo(this) { it.text } } parseCommandLineArguments(additionalArgs, arguments) diff --git a/idea/idea-maven/test/org/jetbrains/kotlin/idea/maven/KotlinMavenImporterTest.kt b/idea/idea-maven/test/org/jetbrains/kotlin/idea/maven/KotlinMavenImporterTest.kt index 0e331ba2f44..30341ed966e 100644 --- a/idea/idea-maven/test/org/jetbrains/kotlin/idea/maven/KotlinMavenImporterTest.kt +++ b/idea/idea-maven/test/org/jetbrains/kotlin/idea/maven/KotlinMavenImporterTest.kt @@ -2250,6 +2250,57 @@ class KotlinMavenImporterTest : MavenImportingTestCase() { TestCase.assertTrue(dependencies.any { it.name.asString() == "" }) } + fun testNoArgDuplication() { + createProjectSubDirs("src/main/kotlin", "src/main/kotlin.jvm", "src/test/kotlin", "src/test/kotlin.jvm") + + importProject(""" + test + project + 1.0.0 + + + + org.jetbrains.kotlin + kotlin-stdlib + $kotlinVersion + + + + + src/main/kotlin + + + + org.jetbrains.kotlin + kotlin-maven-plugin + + + + compile + compile + + compile + + + + + + -Xjsr305=strict + + + + + + """) + + assertModules("project") + assertImporterStatePresent() + + with (facetSettings) { + Assert.assertEquals("-Xjsr305=strict", compilerSettings!!.additionalArguments) + } + } + private fun assertImporterStatePresent() { assertNotNull("Kotlin importer component is not present", myTestFixture.module.getComponent(KotlinImporterComponent::class.java)) }