Introduce "Logger initialized with foreign class" inspection

^KT-38982 Fixed
This commit is contained in:
Toshiaki Kameyama
2020-05-16 11:48:19 +09:00
committed by Nikita Bobko
parent c6e23ffa3b
commit 23c4eac45b
35 changed files with 707 additions and 1 deletions
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.java.canonicalName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.java.canonicalName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.java.getCanonicalName())
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.java.getCanonicalName())
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.java.getName())
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.java.getName())
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.java.getSimpleName())
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.java.getSimpleName())
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.qualifiedName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.qualifiedName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.simpleName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.simpleName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.java.name)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.java.name)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,14 @@
// WITH_RUNTIME
// PROBLEM: none
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Foo::class.java)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,15 @@
// WITH_RUNTIME
// PROBLEM: Logger initialized with foreign class 'Bar::class'
// FIX: Replace with 'Foo::class'
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.java)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,15 @@
// WITH_RUNTIME
// PROBLEM: Logger initialized with foreign class 'Bar::class'
// FIX: Replace with 'Foo::class'
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.java)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(<caret>Bar::class.java.simpleName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}
@@ -0,0 +1,13 @@
// WITH_RUNTIME
package org.apache.commons.logging
class Foo {
private val logger = LogFactory.getLog(Foo::class.java.simpleName)
}
class Bar
object LogFactory {
fun getLog(clazz: Class<*>) {}
fun getLog(name: String?) {}
}