Introduce "Logger initialized with foreign class" inspection

^KT-38982 Fixed

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.logging.KotlinLoggerInitializedWithForeignClassInspection

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/canonicalName.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.java.canonicalName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/canonicalName.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.java.canonicalName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/getCanonicalName.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.java.getCanonicalName())
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/getCanonicalName.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.java.getCanonicalName())
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/getName.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.java.getName())
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/getName.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.java.getName())
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/getSimpleName.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.java.getSimpleName())
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/getSimpleName.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.java.getSimpleName())
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/kclassQualiiedName.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.qualifiedName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/kclassQualiiedName.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.qualifiedName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/kclassSimpleName.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.simpleName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/kclassSimpleName.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.simpleName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/name.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.java.name)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/name.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.java.name)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/nonForeignClass.kt

@@ -0,0 +1,14 @@
+// WITH_RUNTIME
+// PROBLEM: none
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Foo::class.java)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/simple.kt

@@ -0,0 +1,15 @@
+// WITH_RUNTIME
+// PROBLEM: Logger initialized with foreign class 'Bar::class'
+// FIX: Replace with 'Foo::class'
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.java)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/simple.kt.after

@@ -0,0 +1,15 @@
+// WITH_RUNTIME
+// PROBLEM: Logger initialized with foreign class 'Bar::class'
+// FIX: Replace with 'Foo::class'
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.java)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/simpleName.kt

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(<caret>Bar::class.java.simpleName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/commons/simpleName.kt.after

@@ -0,0 +1,13 @@
+// WITH_RUNTIME
+package org.apache.commons.logging
+
+class Foo {
+    private val logger = LogFactory.getLog(Foo::class.java.simpleName)
+}
+
+class Bar
+
+object LogFactory {
+    fun getLog(clazz: Class<*>) {}
+    fun getLog(name: String?) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/log4j/simple.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+package org.apache.log4j
+
+class Foo {
+    private val logger = Logger.getLogger(<caret>Bar::class.java)
+}
+
+class Bar
+
+object Logger {
+    fun getLogger(clazz: Class<*>) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/log4j/simple.kt.after

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+package org.apache.log4j
+
+class Foo {
+    private val logger = Logger.getLogger(Foo::class.java)
+}
+
+class Bar
+
+object Logger {
+    fun getLogger(clazz: Class<*>) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/log4j2/simple.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+package org.apache.logging.log4j
+
+class Foo {
+    private val logger = LogManager.getLogger(<caret>Bar::class.java)
+}
+
+class Bar
+
+object LogManager {
+    fun getLogger(clazz: Class<*>) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/log4j2/simple.kt.after

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+package org.apache.logging.log4j
+
+class Foo {
+    private val logger = LogManager.getLogger(Foo::class.java)
+}
+
+class Bar
+
+object LogManager {
+    fun getLogger(clazz: Class<*>) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/slf4j/simple.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+package org.slf4j
+
+class Foo {
+    private val logger = LoggerFactory.getLogger(<caret>Bar::class.java)
+}
+
+class Bar
+
+object LoggerFactory {
+    fun getLogger(clazz: Class<*>) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/slf4j/simple.kt.after

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+package org.slf4j
+
+class Foo {
+    private val logger = LoggerFactory.getLogger(Foo::class.java)
+}
+
+class Bar
+
+object LoggerFactory {
+    fun getLogger(clazz: Class<*>) {}
+}

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/util/simple.kt

@@ -0,0 +1,10 @@
+// RUNTIME_WITH_FULL_JDK
+package util
+
+import java.util.logging.Logger
+
+class Foo {
+    private val logger = Logger.getLogger(<caret>Bar::class.qualifiedName)
+}
+
+class Bar

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/util/simple.kt.after

@@ -0,0 +1,10 @@
+// RUNTIME_WITH_FULL_JDK
+package util
+
+import java.util.logging.Logger
+
+class Foo {
+    private val logger = Logger.getLogger(Foo::class.qualifiedName)
+}
+
+class Bar

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/util/simple2.kt

@@ -0,0 +1,10 @@
+// RUNTIME_WITH_FULL_JDK
+package util
+
+import java.util.logging.Logger.getLogger
+
+class Foo {
+    private val logger = getLogger(<caret>Bar::class.qualifiedName)
+}
+
+class Bar

idea/testData/inspectionsLocal/logging/loggerInitializedWithForeignClass/util/simple2.kt.after

@@ -0,0 +1,10 @@
+// RUNTIME_WITH_FULL_JDK
+package util
+
+import java.util.logging.Logger.getLogger
+
+class Foo {
+    private val logger = getLogger(Foo::class.qualifiedName)
+}
+
+class Bar