Switch warning to error for java-default method calls within 1.6 target

#KT-15825 Fixed

(cherry picked from commit 9b29ebb)

compiler/frontend.java/src/org/jetbrains/kotlin/resolve/jvm/diagnostics/DefaultErrorMessagesJvm.java

@@ -115,7 +115,7 @@ public class DefaultErrorMessagesJvm implements DefaultErrorMessages.Extension {
                 "Please make explicit overrides (abstract or concrete) for the following non-abstract members of ''{1}'': {2}",
                 NAME, NAME, STRING);
 
-        MAP.put(DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET, "Super calls to Java default methods are deprecated in JVM target 1.6. Recompile with '-jvm-target 1.8'");
+        MAP.put(DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET, "Super calls to Java default methods are prohibited in JVM target 1.6. Recompile with '-jvm-target 1.8'");
         MAP.put(INTERFACE_STATIC_METHOD_CALL_FROM_JAVA6_TARGET, "Calls to static methods in Java interfaces are deprecated in JVM target 1.6. Recompile with '-jvm-target 1.8'");
 
         MAP.put(INLINE_FROM_HIGHER_PLATFORM, "Cannot inline bytecode built with {0} into bytecode that is being built with {1}. Please specify proper ''-jvm-target'' option", STRING, STRING);

compiler/frontend.java/src/org/jetbrains/kotlin/resolve/jvm/diagnostics/ErrorsJvm.java

@@ -96,7 +96,7 @@ public interface ErrorsJvm {
 
     DiagnosticFactory3<PsiElement, DeclarationDescriptor, DeclarationDescriptor, String> TARGET6_INTERFACE_INHERITANCE = DiagnosticFactory3.create(ERROR);
 
-    DiagnosticFactory0<PsiElement> DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET = DiagnosticFactory0.create(WARNING);
+    DiagnosticFactory0<PsiElement> DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET = DiagnosticFactory0.create(ERROR);
     DiagnosticFactory0<PsiElement> INTERFACE_STATIC_METHOD_CALL_FROM_JAVA6_TARGET = DiagnosticFactory0.create(WARNING);
 
     DiagnosticFactory2<PsiElement, String, String> INLINE_FROM_HIGHER_PLATFORM = DiagnosticFactory2.create(ERROR);

compiler/testData/codegen/java8/box/capturedSuperCall.kt

@@ -11,6 +11,7 @@ open class Base {
     fun foo() = "OK"
 }
 
+@kotlin.Suppress("DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET")
 class C : Base(), IBase {
     val lambda1 = {
         super.foo()

compiler/testData/codegen/java8/box/inheritKotlin.kt

@@ -15,6 +15,7 @@ interface KInterface {
 }
 
 class Test : Simple {
+    @kotlin.Suppress("DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET")
     fun bar(): String {
         return super.test()
     }

compiler/testData/codegen/java8/box/invokeDefaultViaSuper.kt

@@ -13,12 +13,14 @@ interface KInterface : Test {
 }
 
 class KClass : Test {
+    @kotlin.Suppress("DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET")
     fun ktest(): String {
         return super.test() + test()
     }
 }
 
 class KTClass : KInterface {
+    @kotlin.Suppress("DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET")
     fun ktest(): String {
         return super.test() + test()
     }
@@ -27,6 +29,7 @@ class KTClass : KInterface {
 
 fun box(): String {
     val p = object : KInterface {
+        @kotlin.Suppress("DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET")
         fun ktest(): String {
             return super.test() + test()
         }

compiler/testData/codegen/java8/box/longChainOfKotlinExtendsFromJavaWithDefault.kt

@@ -15,6 +15,7 @@ interface K2 : K1
 interface K3 : K2
 
 class C : K3 {
+    @kotlin.Suppress("DEFAULT_METHOD_CALL_FROM_JAVA6_TARGET")
     override fun foo() = super.foo()
 }
 

idea/testData/codeInsight/overrideImplement/jdk8/overrideCollectionStream.kt.after

@@ -1,3 +1,4 @@
+// ERROR: Super calls to Java default methods are prohibited in JVM target 1.6. Recompile with '-jvm-target 1.8'
 import java.util.stream.Stream
 
 abstract class A : List<String> {