KT-4820: Intention to introduce/remove indices from a for-loop (update to modern Kotlin)

idea/testData/intentions/addForLoopIndicesIntention/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.AddForLoopIndicesIntention

idea/testData/intentions/addForLoopIndicesIntention/inapplicableExistingIndices.kt

@@ -1,7 +1,7 @@
 //IS_APPLICABLE: FALSE
 // WITH_RUNTIME
 fun b(c: List<String>) {
-    for ((<caret>indexVariable, d) in c.withIndices()) {
+    for ((<caret>indexVariable, d) in c.withIndex()) {
 
     }
 }

idea/testData/intentions/addForLoopIndicesIntention/inapplicableOverridenFunction.kt

@@ -1,6 +1,6 @@
 // WITH_RUNTIME
 // IS_APPLICABLE: FALSE
-fun String.withIndices(): Int = 42
+fun String.withIndex(): Int = 42
 
 fun foo(s: String) {
     for (<caret>a in s) {

idea/testData/intentions/addForLoopIndicesIntention/intArray.kt.after

@@ -1,6 +1,6 @@
 //WITH_RUNTIME
 fun foo(bar: IntArray) {
-    for ((index, a) in bar.withIndices()) {
+    for ((index, a) in bar.withIndex()) {
 
     }
 }

idea/testData/intentions/addForLoopIndicesIntention/iterable.kt.after

@@ -1,6 +1,6 @@
 //WITH_RUNTIME
 fun foo(bar: Iterable<Int>) {
-    for ((index, a) in bar.withIndices()) {
+    for ((index, a) in bar.withIndex()) {
 
     }
 }

idea/testData/intentions/addForLoopIndicesIntention/listWithType.kt.after

@@ -1,7 +1,7 @@
 // WITH_RUNTIME
 fun a() {
     val b = listOf(1,2,3,4,5)
-    for ((index, c : Int) in b.withIndices()) {
+    for ((index, c : Int) in b.withIndex()) {
 
     }
 }

idea/testData/intentions/addForLoopIndicesIntention/objectArray.kt.after

@@ -1,6 +1,6 @@
 //WITH_RUNTIME
 fun foo(bar: Array<Object>) {
-    for ((index, a) in bar.withIndices()) {
+    for ((index, a) in bar.withIndex()) {
 
     }
 }

idea/testData/intentions/addForLoopIndicesIntention/simpleIntList.kt.after

@@ -1,7 +1,7 @@
 // WITH_RUNTIME
 fun a() {
     val b = listOf(1,2,3,4,5)
-    for ((index, c) in b.withIndices()) {
+    for ((index, c) in b.withIndex()) {
 
     }
 }

idea/testData/intentions/addForLoopIndicesIntention/stream.kt.after

@@ -1,6 +1,6 @@
 //WITH_RUNTIME
 fun foo(bar: Stream<String>) {
-    for ((index, a) in bar.withIndices()) {
+    for ((index, a) in bar.withIndex()) {
 
     }
 }

idea/testData/intentions/addForLoopIndicesIntention/string.kt.after

@@ -1,6 +1,6 @@
 //WITH_RUNTIME
 fun foo(bar: String) {
-    for ((index, a) in bar.withIndices()) {
+    for ((index, a) in bar.withIndex()) {
 
     }
 }

idea/testData/intentions/removeForLoopIndicesIntention/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.RemoveForLoopIndicesIntention

idea/testData/intentions/removeForLoopIndicesIntention/inapplicableIndexUse.kt

@@ -2,7 +2,7 @@
 //WITH_RUNTIME
 
 fun foo(b: List<Int>) : Int {
-    for ((i, <caret>c) in b.withIndices()) {
+    for ((i, <caret>c) in b.withIndex()) {
         return i
     }
     return 0

idea/testData/intentions/removeForLoopIndicesIntention/inapplicableOverridenFunction.kt

@@ -1,11 +1,10 @@
 // WITH_RUNTIME
 // IS_APPLICABLE: FALSE
-import java.util.LinkedList
 
-fun Int.withIndices(): List<Pair<Int, Int>> = LinkedList<Pair<Int, Int>>()
+fun Int.withIndex(): List<Pair<Int, Int>> = linkedListOf<Pair<Int, Int>>()
 
 fun foo(s: Int) {
-    for ((index<caret>, a) in s.withIndices()) {
+    for ((index<caret>, a) in s.withIndex()) {
 
     }
 }

idea/testData/intentions/removeForLoopIndicesIntention/loopWithType.kt

@@ -1,6 +1,6 @@
 //WITH_RUNTIME
 fun foo(bar: List<Int>) {
-    for ((i : <caret>Int, b: Int) in bar.withIndices()) {
+    for ((i : <caret>Int, b: Int) in bar.withIndex()) {
 
     }
 }

idea/testData/intentions/removeForLoopIndicesIntention/simpleLoopWithIndices.kt

@@ -1,6 +1,6 @@
 //WITH_RUNTIME
 fun foo(bar: List<String>) {
-    for ((i,<caret>a) in bar.withIndices()) {
+    for ((i,<caret>a) in bar.withIndex()) {
 
     }
 }