[Analysis API] fix IndexOutOfRangeException

Previously, the `KtFirUsualClassType.qualifiers` was empty for the local classes

The reason was a RawFirBuilder setting up a containingClassForLocalAttr
to the outer non-local class for the local class. It should be a null instead,
see the localClassType.kt as an example

^KT-55510 fixed
This commit is contained in:
Ilya Kirillov
2022-12-16 13:55:29 +01:00
committed by teamcity
parent 61d8b91c89
commit 20b81464be
23 changed files with 396 additions and 38 deletions
@@ -0,0 +1,66 @@
/*
* Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
* Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
*/
package org.jetbrains.kotlin.analysis.api.fe10.test.cases.generated.cases.types;
import com.intellij.testFramework.TestDataPath;
import org.jetbrains.kotlin.test.util.KtTestUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.kotlin.analysis.api.fe10.test.configurator.AnalysisApiFe10TestConfiguratorFactory;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiTestConfiguratorFactoryData;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiTestConfigurator;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.TestModuleKind;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.FrontendKind;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisSessionMode;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiMode;
import org.jetbrains.kotlin.analysis.api.impl.base.test.cases.types.AbstractTypeByDeclarationReturnTypeTest;
import org.jetbrains.kotlin.test.TestMetadata;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import java.io.File;
import java.util.regex.Pattern;
/** This class is generated by {@link org.jetbrains.kotlin.generators.tests.analysis.api.GenerateAnalysisApiTestsKt}. DO NOT MODIFY MANUALLY */
@SuppressWarnings("all")
@TestMetadata("analysis/analysis-api/testData/types/byDeclarationReturnType")
@TestDataPath("$PROJECT_ROOT")
public class Fe10IdeNormalAnalysisSourceModuleTypeByDeclarationReturnTypeTestGenerated extends AbstractTypeByDeclarationReturnTypeTest {
@NotNull
@Override
public AnalysisApiTestConfigurator getConfigurator() {
return AnalysisApiFe10TestConfiguratorFactory.INSTANCE.createConfigurator(
new AnalysisApiTestConfiguratorFactoryData(
FrontendKind.Fe10,
TestModuleKind.Source,
AnalysisSessionMode.Normal,
AnalysisApiMode.Ide
)
);
}
@Test
public void testAllFilesPresentInByDeclarationReturnType() throws Exception {
KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/types/byDeclarationReturnType"), Pattern.compile("^(.+)\\.kt$"), null, true);
}
@Test
@TestMetadata("localClassType.kt")
public void testLocalClassType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localClassType.kt");
}
@Test
@TestMetadata("localClassWithTypeArgumentsType.kt")
public void testLocalClassWithTypeArgumentsType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localClassWithTypeArgumentsType.kt");
}
@Test
@TestMetadata("localNestedClassType.kt")
public void testLocalNestedClassType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localNestedClassType.kt");
}
}
@@ -107,7 +107,7 @@ internal class KtFirNamedClassOrObjectSymbol(
firSymbol.classKind.toKtClassKind(isCompanionObject = firSymbol.isCompanion)
}
override val symbolKind: KtSymbolKind get() = withValidityAssertion { getSymbolKind(firResolveSession) }
override val symbolKind: KtSymbolKind get() = withValidityAssertion { getSymbolKind() }
context(KtAnalysisSession)
override fun createPointer(): KtSymbolPointer<KtNamedClassOrObjectSymbol> = withValidityAssertion {
@@ -16,16 +16,20 @@ import org.jetbrains.kotlin.analysis.api.symbols.markers.KtSymbolKind
import org.jetbrains.kotlin.analysis.low.level.api.fir.api.LLFirResolveSession
import org.jetbrains.kotlin.analysis.low.level.api.fir.util.errorWithFirSpecificEntries
import org.jetbrains.kotlin.analysis.low.level.api.fir.util.withFirEntry
import org.jetbrains.kotlin.analysis.utils.errors.buildErrorWithAttachment
import org.jetbrains.kotlin.fir.containingClassForLocalAttr
import org.jetbrains.kotlin.fir.declarations.FirCallableDeclaration
import org.jetbrains.kotlin.fir.declarations.FirDeclaration
import org.jetbrains.kotlin.fir.declarations.FirDeclarationOrigin
import org.jetbrains.kotlin.fir.declarations.FirSimpleFunction
import org.jetbrains.kotlin.fir.declarations.synthetic.FirSyntheticProperty
import org.jetbrains.kotlin.fir.declarations.synthetic.FirSyntheticPropertyAccessor
import org.jetbrains.kotlin.fir.declarations.utils.isLocal
import org.jetbrains.kotlin.fir.scopes.impl.importedFromObjectOrStaticData
import org.jetbrains.kotlin.fir.scopes.impl.originalForWrappedIntegerOperator
import org.jetbrains.kotlin.fir.symbols.FirBasedSymbol
import org.jetbrains.kotlin.analysis.utils.errors.buildErrorWithAttachment
import org.jetbrains.kotlin.fir.declarations.*
import org.jetbrains.kotlin.fir.declarations.utils.isLocal
import org.jetbrains.kotlin.fir.resolve.getContainingDeclaration
import org.jetbrains.kotlin.fir.symbols.impl.FirClassLikeSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirRegularClassSymbol
internal interface KtFirSymbol<out S : FirBasedSymbol<*>> : KtSymbol, KtLifetimeOwner {
val firSymbol: S
@@ -100,14 +104,17 @@ internal tailrec fun FirDeclaration.ktSymbolOrigin(): KtSymbolOrigin = when (ori
FirDeclarationOrigin.ScriptCustomization -> KtSymbolOrigin.PLUGIN
}
internal fun KtClassLikeSymbol.getSymbolKind(firResolveSession: LLFirResolveSession): KtSymbolKind {
internal fun KtClassLikeSymbol.getSymbolKind(): KtSymbolKind {
val firSymbol = firSymbol as FirClassLikeSymbol<*>
return when {
if (firSymbol.isLocal) {
// TODO: hack should be dropped after KT-54390
firSymbol.isLocal && (firSymbol.fir.getContainingDeclaration(firResolveSession.useSiteFirSession) as? FirClass)?.let { clazz ->
clazz.declarations.none { it === firSymbol.fir }
} == true -> KtSymbolKind.LOCAL
when {
firSymbol is FirRegularClassSymbol && firSymbol.fir.containingClassForLocalAttr == null -> {
return KtSymbolKind.LOCAL
}
}
}
return when {
firSymbol.classId.isNestedClass -> KtSymbolKind.CLASS_MEMBER
firSymbol.isLocal -> KtSymbolKind.LOCAL
else -> KtSymbolKind.TOP_LEVEL
@@ -57,7 +57,7 @@ internal class KtFirTypeAliasSymbol(
KtFirAnnotationListForDeclaration.create(firSymbol, firResolveSession.useSiteFirSession, token)
}
override val symbolKind: KtSymbolKind get() = withValidityAssertion { getSymbolKind(firResolveSession) }
override val symbolKind: KtSymbolKind get() = withValidityAssertion { getSymbolKind() }
context(KtAnalysisSession)
override fun createPointer(): KtSymbolPointer<KtTypeAliasSymbol> = withValidityAssertion {
@@ -9,12 +9,13 @@ import org.jetbrains.kotlin.analysis.api.fir.KtSymbolByFirBuilder
import org.jetbrains.kotlin.analysis.api.types.KtClassTypeQualifier
import org.jetbrains.kotlin.analysis.low.level.api.fir.api.tryCollectDesignation
import org.jetbrains.kotlin.analysis.low.level.api.fir.util.errorWithFirSpecificEntries
import org.jetbrains.kotlin.analysis.low.level.api.fir.util.withFirEntry
import org.jetbrains.kotlin.analysis.utils.errors.checkWithAttachmentBuilder
import org.jetbrains.kotlin.fir.containingClassForLocal
import org.jetbrains.kotlin.fir.declarations.*
import org.jetbrains.kotlin.fir.declarations.utils.isInner
import org.jetbrains.kotlin.fir.declarations.utils.isLocal
import org.jetbrains.kotlin.fir.renderWithType
import org.jetbrains.kotlin.fir.resolve.getContainingClass
import org.jetbrains.kotlin.fir.resolve.toFirRegularClass
import org.jetbrains.kotlin.fir.resolve.toSymbol
import org.jetbrains.kotlin.fir.symbols.impl.FirRegularClassSymbol
@@ -47,7 +48,6 @@ internal object UsualClassTypeQualifierBuilder {
val nonLocalDesignation = it.tryCollectDesignation()
nonLocalDesignation?.toSequence(includeTarget = true)?.toList()
?: collectDesignationPathForLocal(it)
?: emptyList()
}
@@ -90,26 +90,21 @@ internal object UsualClassTypeQualifierBuilder {
designation.add(currentClass)
containingClassLookUp = currentClass.containingClassForLocal()
}
return designation
return designation.asReversed()
}
private fun collectDesignationPathForLocal(declaration: FirDeclaration): List<FirDeclaration>? {
@OptIn(LookupTagInternals::class)
val containingClass = when (declaration) {
is FirCallableDeclaration -> declaration.getContainingClass(declaration.moduleData.session)
is FirAnonymousObject -> return listOf(declaration)
is FirClassLikeDeclaration -> declaration.let {
if (!declaration.isLocal) return null
(it as? FirRegularClass)?.containingClassForLocal()?.toFirRegularClass(declaration.moduleData.session)
}
private fun collectDesignationPathForLocal(declaration: FirClassLikeDeclaration): List<FirDeclaration> {
checkWithAttachmentBuilder(
declaration.isLocal,
message = { "${declaration::class} is not local" }
) {
withFirEntry("firDeclaration", declaration)
}
return when (declaration) {
is FirAnonymousObject -> listOf(declaration)
is FirRegularClass -> declaration.collectForLocal()
is FirTypeAlias -> listOf(declaration) // TODO: handle type aliases
else -> error("Invalid declaration ${declaration.renderWithType()}")
} ?: return listOf(declaration)
return if (containingClass.isLocal) {
containingClass.collectForLocal().reversed()
} else {
null
}
}
}
@@ -0,0 +1,66 @@
/*
* Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
* Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
*/
package org.jetbrains.kotlin.analysis.api.fir.test.cases.generated.cases.types;
import com.intellij.testFramework.TestDataPath;
import org.jetbrains.kotlin.test.util.KtTestUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.kotlin.analysis.api.fir.test.configurators.AnalysisApiFirTestConfiguratorFactory;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiTestConfiguratorFactoryData;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiTestConfigurator;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.TestModuleKind;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.FrontendKind;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisSessionMode;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiMode;
import org.jetbrains.kotlin.analysis.api.impl.base.test.cases.types.AbstractTypeByDeclarationReturnTypeTest;
import org.jetbrains.kotlin.test.TestMetadata;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import java.io.File;
import java.util.regex.Pattern;
/** This class is generated by {@link org.jetbrains.kotlin.generators.tests.analysis.api.GenerateAnalysisApiTestsKt}. DO NOT MODIFY MANUALLY */
@SuppressWarnings("all")
@TestMetadata("analysis/analysis-api/testData/types/byDeclarationReturnType")
@TestDataPath("$PROJECT_ROOT")
public class FirIdeNormalAnalysisSourceModuleTypeByDeclarationReturnTypeTestGenerated extends AbstractTypeByDeclarationReturnTypeTest {
@NotNull
@Override
public AnalysisApiTestConfigurator getConfigurator() {
return AnalysisApiFirTestConfiguratorFactory.INSTANCE.createConfigurator(
new AnalysisApiTestConfiguratorFactoryData(
FrontendKind.Fir,
TestModuleKind.Source,
AnalysisSessionMode.Normal,
AnalysisApiMode.Ide
)
);
}
@Test
public void testAllFilesPresentInByDeclarationReturnType() throws Exception {
KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/types/byDeclarationReturnType"), Pattern.compile("^(.+)\\.kt$"), null, true);
}
@Test
@TestMetadata("localClassType.kt")
public void testLocalClassType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localClassType.kt");
}
@Test
@TestMetadata("localClassWithTypeArgumentsType.kt")
public void testLocalClassWithTypeArgumentsType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localClassWithTypeArgumentsType.kt");
}
@Test
@TestMetadata("localNestedClassType.kt")
public void testLocalNestedClassType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localNestedClassType.kt");
}
}
@@ -0,0 +1,66 @@
/*
* Copyright 2010-2023 JetBrains s.r.o. and Kotlin Programming Language contributors.
* Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
*/
package org.jetbrains.kotlin.analysis.api.standalone.fir.test.cases.generated.cases.types;
import com.intellij.testFramework.TestDataPath;
import org.jetbrains.kotlin.test.util.KtTestUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.kotlin.analysis.api.standalone.fir.test.AnalysisApiFirStandaloneModeTestConfiguratorFactory;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiTestConfiguratorFactoryData;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiTestConfigurator;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.TestModuleKind;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.FrontendKind;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisSessionMode;
import org.jetbrains.kotlin.analysis.test.framework.test.configurators.AnalysisApiMode;
import org.jetbrains.kotlin.analysis.api.impl.base.test.cases.types.AbstractTypeByDeclarationReturnTypeTest;
import org.jetbrains.kotlin.test.TestMetadata;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import java.io.File;
import java.util.regex.Pattern;
/** This class is generated by {@link org.jetbrains.kotlin.generators.tests.analysis.api.GenerateAnalysisApiTestsKt}. DO NOT MODIFY MANUALLY */
@SuppressWarnings("all")
@TestMetadata("analysis/analysis-api/testData/types/byDeclarationReturnType")
@TestDataPath("$PROJECT_ROOT")
public class FirStandaloneNormalAnalysisSourceModuleTypeByDeclarationReturnTypeTestGenerated extends AbstractTypeByDeclarationReturnTypeTest {
@NotNull
@Override
public AnalysisApiTestConfigurator getConfigurator() {
return AnalysisApiFirStandaloneModeTestConfiguratorFactory.INSTANCE.createConfigurator(
new AnalysisApiTestConfiguratorFactoryData(
FrontendKind.Fir,
TestModuleKind.Source,
AnalysisSessionMode.Normal,
AnalysisApiMode.Standalone
)
);
}
@Test
public void testAllFilesPresentInByDeclarationReturnType() throws Exception {
KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("analysis/analysis-api/testData/types/byDeclarationReturnType"), Pattern.compile("^(.+)\\.kt$"), null, true);
}
@Test
@TestMetadata("localClassType.kt")
public void testLocalClassType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localClassType.kt");
}
@Test
@TestMetadata("localClassWithTypeArgumentsType.kt")
public void testLocalClassWithTypeArgumentsType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localClassWithTypeArgumentsType.kt");
}
@Test
@TestMetadata("localNestedClassType.kt")
public void testLocalNestedClassType() throws Exception {
runTest("analysis/analysis-api/testData/types/byDeclarationReturnType/localNestedClassType.kt");
}
}
@@ -1,2 +1,2 @@
KtType: Foo
KtType: Foo.Bar
PsiType: PsiType:Bar
@@ -0,0 +1,11 @@
annotationsList: []
classId: B
classSymbol: KtNamedClassOrObjectSymbol(<local>/B)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: B
symbol: KtNamedClassOrObjectSymbol(<local>/B)
typeArguments: []
]
@@ -0,0 +1,7 @@
class A {
fun aa() {
class B()
fun cc<caret>c(): B
}
}
@@ -0,0 +1,11 @@
annotationsList: []
classId: A.B
classSymbol: KtNamedClassOrObjectSymbol(<local>/B)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: B
symbol: KtNamedClassOrObjectSymbol(<local>/B)
typeArguments: []
]
@@ -0,0 +1,35 @@
annotationsList: []
classId: B
classSymbol: KtNamedClassOrObjectSymbol(<local>/B)
nullability: NON_NULLABLE
ownTypeArguments: [
annotationsList: []
classId: kotlin/Int
classSymbol: KtNamedClassOrObjectSymbol(kotlin/Int)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: Int
symbol: KtNamedClassOrObjectSymbol(kotlin/Int)
typeArguments: []
]
]
qualifiers: [
qualifier:
name: B
symbol: KtNamedClassOrObjectSymbol(<local>/B)
typeArguments: [
annotationsList: []
classId: kotlin/Int
classSymbol: KtNamedClassOrObjectSymbol(kotlin/Int)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: Int
symbol: KtNamedClassOrObjectSymbol(kotlin/Int)
typeArguments: []
]
]
]
@@ -0,0 +1,7 @@
class A {
fun aa() {
class B<T>()
fun cc<caret>c(): B<Int>
}
}
@@ -0,0 +1,35 @@
annotationsList: []
classId: A.B
classSymbol: KtNamedClassOrObjectSymbol(<local>/B)
nullability: NON_NULLABLE
ownTypeArguments: [
annotationsList: []
classId: kotlin/Int
classSymbol: KtNamedClassOrObjectSymbol(kotlin/Int)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: Int
symbol: KtNamedClassOrObjectSymbol(kotlin/Int)
typeArguments: []
]
]
qualifiers: [
qualifier:
name: B
symbol: KtNamedClassOrObjectSymbol(<local>/B)
typeArguments: [
annotationsList: []
classId: kotlin/Int
classSymbol: KtNamedClassOrObjectSymbol(kotlin/Int)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: Int
symbol: KtNamedClassOrObjectSymbol(kotlin/Int)
typeArguments: []
]
]
]
@@ -0,0 +1,15 @@
annotationsList: []
classId: C
classSymbol: KtNamedClassOrObjectSymbol(<local>/C)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: B
symbol: KtNamedClassOrObjectSymbol(<local>/B)
typeArguments: []
qualifier:
name: C
symbol: KtNamedClassOrObjectSymbol(<local>/C)
typeArguments: []
]
@@ -0,0 +1,9 @@
class A {
fun aa() {
class B {
class C
}
fun cc<caret>c(): B.C
}
}
@@ -0,0 +1,15 @@
annotationsList: []
classId: A.B.C
classSymbol: KtNamedClassOrObjectSymbol(<local>/C)
nullability: NON_NULLABLE
ownTypeArguments: []
qualifiers: [
qualifier:
name: B
symbol: KtNamedClassOrObjectSymbol(<local>/B)
typeArguments: []
qualifier:
name: C
symbol: KtNamedClassOrObjectSymbol(<local>/C)
typeArguments: []
]