diff --git a/idea/src/org/jetbrains/kotlin/idea/quickfix/ChangePrivateTopLevelToInternalFix.kt b/idea/src/org/jetbrains/kotlin/idea/quickfix/IncreaseVisibilityFix.kt similarity index 89% rename from idea/src/org/jetbrains/kotlin/idea/quickfix/ChangePrivateTopLevelToInternalFix.kt rename to idea/src/org/jetbrains/kotlin/idea/quickfix/IncreaseVisibilityFix.kt index 95970deca23..70dc1e7008f 100644 --- a/idea/src/org/jetbrains/kotlin/idea/quickfix/ChangePrivateTopLevelToInternalFix.kt +++ b/idea/src/org/jetbrains/kotlin/idea/quickfix/IncreaseVisibilityFix.kt @@ -30,7 +30,8 @@ import org.jetbrains.kotlin.psi.KtModifierListOwner import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils import org.jetbrains.kotlin.resolve.DescriptorUtils -class ChangePrivateTopLevelToInternalFix(element: KtModifierListOwner, private val elementName: String) : KotlinQuickFixAction(element), CleanupFix { +class IncreaseVisibilityFix(element: KtModifierListOwner, private val elementName: String) : + KotlinQuickFixAction(element), CleanupFix { override fun getText() = "Make $elementName internal" override fun getFamilyName() = "Make top-level declaration internal" @@ -48,7 +49,7 @@ class ChangePrivateTopLevelToInternalFix(element: KtModifierListOwner, private v descriptor.visibility != Visibilities.PRIVATE) return null val declaration = DescriptorToSourceUtils.getSourceFromDescriptor(descriptor) as? KtModifierListOwner ?: return null - return ChangePrivateTopLevelToInternalFix(declaration, descriptor.name.asString()) + return IncreaseVisibilityFix(declaration, descriptor.name.asString()) } } } diff --git a/idea/src/org/jetbrains/kotlin/idea/quickfix/QuickFixRegistrar.kt b/idea/src/org/jetbrains/kotlin/idea/quickfix/QuickFixRegistrar.kt index 54526bc5757..99a0e2749b6 100644 --- a/idea/src/org/jetbrains/kotlin/idea/quickfix/QuickFixRegistrar.kt +++ b/idea/src/org/jetbrains/kotlin/idea/quickfix/QuickFixRegistrar.kt @@ -149,9 +149,9 @@ class QuickFixRegistrar : QuickFixContributor { CANNOT_CHANGE_ACCESS_PRIVILEGE.registerFactory(ChangeVisibilityModifierFix) CANNOT_WEAKEN_ACCESS_PRIVILEGE.registerFactory(ChangeVisibilityModifierFix) - INVISIBLE_REFERENCE.registerFactory(ChangePrivateTopLevelToInternalFix) - INVISIBLE_MEMBER.registerFactory(ChangePrivateTopLevelToInternalFix) - INVISIBLE_SETTER.registerFactory(ChangePrivateTopLevelToInternalFix) + INVISIBLE_REFERENCE.registerFactory(IncreaseVisibilityFix) + INVISIBLE_MEMBER.registerFactory(IncreaseVisibilityFix) + INVISIBLE_SETTER.registerFactory(IncreaseVisibilityFix) REDUNDANT_NULLABLE.registerFactory(RemoveNullableFix.Factory(RemoveNullableFix.NullableKind.REDUNDANT)) NULLABLE_SUPERTYPE.registerFactory(RemoveNullableFix.Factory(RemoveNullableFix.NullableKind.SUPERTYPE)) diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.after.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.after.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.after.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.after.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.after.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.after.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.after.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.after.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.before.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.before.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.before.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.before.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.before.Main.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.before.Main.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.before.Main.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.before.Main.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.after.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.after.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.after.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.after.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.after.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.after.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.after.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.after.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.before.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.before.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.before.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.before.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.before.Main.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.before.Main.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.before.Main.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.before.Main.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.after.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.after.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.after.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.after.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.after.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.after.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.after.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.after.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.before.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.before.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.before.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.before.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.before.Main.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.before.Main.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.before.Main.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.before.Main.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.after.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.after.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.after.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.after.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.after.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.after.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.after.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.after.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.before.Dependency.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.before.Dependency.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.before.Dependency.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.before.Dependency.kt diff --git a/idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.before.Main.kt b/idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.before.Main.kt similarity index 100% rename from idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.before.Main.kt rename to idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.before.Main.kt diff --git a/idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixMultiFileTestGenerated.java b/idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixMultiFileTestGenerated.java index 817a1aec359..971b082694d 100644 --- a/idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixMultiFileTestGenerated.java +++ b/idea/tests/org/jetbrains/kotlin/idea/quickfix/QuickFixMultiFileTestGenerated.java @@ -1286,6 +1286,39 @@ public class QuickFixMultiFileTestGenerated extends AbstractQuickFixMultiFileTes } } + @TestMetadata("idea/testData/quickfix/increaseVisibility") + @TestDataPath("$PROJECT_ROOT") + @RunWith(JUnit3RunnerWithInners.class) + public static class IncreaseVisibility extends AbstractQuickFixMultiFileTest { + public void testAllFilesPresentInIncreaseVisibility() throws Exception { + KotlinTestUtils.assertAllTestsPresentByMetadata(this.getClass(), new File("idea/testData/quickfix/increaseVisibility"), Pattern.compile("^(\\w+)\\.((before\\.Main\\.\\w+)|(test))$"), true); + } + + @TestMetadata("privateTopLevelFunInFile.before.Main.kt") + public void testPrivateTopLevelFunInFile() throws Exception { + String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/increaseVisibility/privateTopLevelFunInFile.before.Main.kt"); + doTestWithExtraFile(fileName); + } + + @TestMetadata("privateTopLevelValInFile.before.Main.kt") + public void testPrivateTopLevelValInFile() throws Exception { + String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/increaseVisibility/privateTopLevelValInFile.before.Main.kt"); + doTestWithExtraFile(fileName); + } + + @TestMetadata("privateTopLevelVarInFile.before.Main.kt") + public void testPrivateTopLevelVarInFile() throws Exception { + String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/increaseVisibility/privateTopLevelVarInFile.before.Main.kt"); + doTestWithExtraFile(fileName); + } + + @TestMetadata("privateTopLevelVarWithSetterInFile.before.Main.kt") + public void testPrivateTopLevelVarWithSetterInFile() throws Exception { + String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/increaseVisibility/privateTopLevelVarWithSetterInFile.before.Main.kt"); + doTestWithExtraFile(fileName); + } + } + @TestMetadata("idea/testData/quickfix/migration") @TestDataPath("$PROJECT_ROOT") @RunWith(JUnit3RunnerWithInners.class) @@ -1458,39 +1491,6 @@ public class QuickFixMultiFileTestGenerated extends AbstractQuickFixMultiFileTes } - @TestMetadata("idea/testData/quickfix/privateInFiles") - @TestDataPath("$PROJECT_ROOT") - @RunWith(JUnit3RunnerWithInners.class) - public static class PrivateInFiles extends AbstractQuickFixMultiFileTest { - public void testAllFilesPresentInPrivateInFiles() throws Exception { - KotlinTestUtils.assertAllTestsPresentByMetadata(this.getClass(), new File("idea/testData/quickfix/privateInFiles"), Pattern.compile("^(\\w+)\\.((before\\.Main\\.\\w+)|(test))$"), true); - } - - @TestMetadata("privateTopLevelFunInFile.before.Main.kt") - public void testPrivateTopLevelFunInFile() throws Exception { - String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/privateInFiles/privateTopLevelFunInFile.before.Main.kt"); - doTestWithExtraFile(fileName); - } - - @TestMetadata("privateTopLevelValInFile.before.Main.kt") - public void testPrivateTopLevelValInFile() throws Exception { - String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/privateInFiles/privateTopLevelValInFile.before.Main.kt"); - doTestWithExtraFile(fileName); - } - - @TestMetadata("privateTopLevelVarInFile.before.Main.kt") - public void testPrivateTopLevelVarInFile() throws Exception { - String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/privateInFiles/privateTopLevelVarInFile.before.Main.kt"); - doTestWithExtraFile(fileName); - } - - @TestMetadata("privateTopLevelVarWithSetterInFile.before.Main.kt") - public void testPrivateTopLevelVarWithSetterInFile() throws Exception { - String fileName = KotlinTestUtils.navigationMetadata("idea/testData/quickfix/privateInFiles/privateTopLevelVarWithSetterInFile.before.Main.kt"); - doTestWithExtraFile(fileName); - } - } - @TestMetadata("idea/testData/quickfix/properties") @TestDataPath("$PROJECT_ROOT") @RunWith(JUnit3RunnerWithInners.class)