Fix function List<T>.reverse().

For now all iterables (including List) return reversed *copy* of collection.
See Problem 3 at https://github.com/JetBrains/kotlin/pull/78#issuecomment-6533534
This commit is contained in:
Alexander Zolotov
2012-06-26 00:13:26 +04:00
parent 8d2bd30585
commit 1e301843f7
15 changed files with 47 additions and 23 deletions
@@ -245,7 +245,8 @@ public inline fun <in T, C: Collection<in T>> Array<T>.toCollection(result: C) :
*/
public inline fun <T> Array<T>.reverse() : List<T> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Boolean>> BooleanArray.toCollection(result: C)
*/
public inline fun BooleanArray.reverse() : List<Boolean> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Byte>> ByteArray.toCollection(result: C) : C {
*/
public inline fun ByteArray.reverse() : List<Byte> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Char>> CharArray.toCollection(result: C) : C {
*/
public inline fun CharArray.reverse() : List<Char> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Double>> DoubleArray.toCollection(result: C) :
*/
public inline fun DoubleArray.reverse() : List<Double> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Float>> FloatArray.toCollection(result: C) : C
*/
public inline fun FloatArray.reverse() : List<Float> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Int>> IntArray.toCollection(result: C) : C {
*/
public inline fun IntArray.reverse() : List<Int> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -243,7 +243,8 @@ public inline fun <in T, C: Collection<in T>> java.util.Iterator<T>.toCollection
*/
public inline fun <T> java.util.Iterator<T>.reverse() : List<T> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Long>> LongArray.toCollection(result: C) : C {
*/
public inline fun LongArray.reverse() : List<Long> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <C: Collection<Short>> ShortArray.toCollection(result: C) : C
*/
public inline fun ShortArray.reverse() : List<Short> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */
@@ -245,7 +245,8 @@ public inline fun <in T, C: Collection<in T>> Iterable<T>.toCollection(result: C
*/
public inline fun <T> Iterable<T>.reverse() : List<T> {
val list = toList()
return list.reverse()
Collections.reverse(list)
return list
}
/** Copies all elements into a [[LinkedList]] */