KT-57468 Kotlin assignment plugin: operation name cannot be found

The problem results in broken import quick fix and import optimizer on
the IDE side [1].

`AssignResolutionAltererExtension` introduced a possibility to override
 resolution of assignment statements. The inconsistency though is
 that `KtSimpleNameReference.getResolvesByNames` doesn't return a name
 for the overridden `=`. Kotlin as a language doesn't support this [2].

This commit eliminates the drawback above:
1. It fixes the name `assign` the `=` can be resolved to [3].
   This eliminates the need to search for the name, bypassing the
   plugins.
2. `KtSimpleNameReference.getResolvesByNames` returns `assign` among
   other names in case it deals with binary `=` and assignment is
   resolved.
3. `KtCompilerPluginsProvider` was extended to check plugins' presence.
   K1 implementation added.

----------------------------------------------------------------
[1]: https://youtrack.jetbrains.com/issue/KTIJ-24390
[2]: OperatorConventions.getNameForOperationSymbol
     https://kotlinlang.org/docs/operator-overloading.html#augmented-assignments
[3]: OperatorConventions#ASSIGN_METHOD + AssignmentPluginNames

This commit is contained in:

Andrei Klunnyi

2023-03-08 10:57:51 +01:00

committed by

Space Team

parent 4c1a66b7d6

commit 1e0115aef8

16 changed files with 83 additions and 22 deletions

									
										plugins/assign-plugin/assign-plugin.common/src/org/jetbrains/kotlin/assignment/plugin/AssignmentPluginNames.kt
									
		-3
	
												View File
												
				@@ -5,10 +5,7 @@

				package org.jetbrains.kotlin.assignment.plugin

				import org.jetbrains.kotlin.name.Name

				object AssignmentPluginNames {

				    const val PLUGIN_ID = "org.jetbrains.kotlin.assignment"

				    const val ANNOTATION_OPTION_NAME = "annotation"

				    val ASSIGN_METHOD = Name.identifier("assign")

				}