From 1d36188589664d4cb929054951b3860217af2741 Mon Sep 17 00:00:00 2001 From: "Pavel V. Talanov" Date: Wed, 3 Oct 2012 21:15:13 +0400 Subject: [PATCH] Refactor mysterious field typeParameters to be local variable with a less mysterious name --- .../jet/lang/resolve/java/JavaDescriptorResolveData.java | 4 +--- .../jet/lang/resolve/java/JavaDescriptorResolver.java | 7 ++++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolveData.java b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolveData.java index 6a183a9aa0d..16a22bc6dd0 100644 --- a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolveData.java +++ b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolveData.java @@ -147,14 +147,11 @@ class JavaDescriptorResolveData { private final ClassDescriptorFromJvmBytecode classDescriptor; - List typeParameters; - protected ResolverClassData(boolean negative) { super(negative); this.classDescriptor = null; } - protected ResolverClassData( @Nullable PsiClass psiClass, @Nullable PsiPackage psiPackage, @@ -166,6 +163,7 @@ class JavaDescriptorResolveData { classDescriptor = descriptor; } + public ClassDescriptorFromJvmBytecode getClassDescriptor() { return classDescriptor; } diff --git a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolver.java b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolver.java index e2847b4dc8f..cb88defa36b 100644 --- a/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolver.java +++ b/compiler/frontend.java/src/org/jetbrains/jet/lang/resolve/java/JavaDescriptorResolver.java @@ -239,10 +239,11 @@ public class JavaDescriptorResolver implements DependencyClassByQualifiedNameRes List supertypes = new ArrayList(); - classData.typeParameters = javaDescriptorSignatureResolver.createUninitializedClassTypeParameters(psiClass, classData); + List typeParameterDescriptorInitializations + = javaDescriptorSignatureResolver.createUninitializedClassTypeParameters(psiClass, classData); List typeParameters = new ArrayList(); - for (JavaDescriptorSignatureResolver.TypeParameterDescriptorInitialization typeParameter : classData.typeParameters) { + for (JavaDescriptorSignatureResolver.TypeParameterDescriptorInitialization typeParameter : typeParameterDescriptorInitializations) { typeParameters.add(typeParameter.descriptor); } @@ -262,7 +263,7 @@ public class JavaDescriptorResolver implements DependencyClassByQualifiedNameRes classData.getClassDescriptor().createTypeConstructor(); classData.getClassDescriptor().setScopeForMemberLookup(new JavaClassMembersScope(semanticServices, classData)); - javaDescriptorSignatureResolver.initializeTypeParameters(classData.typeParameters, classData.getClassDescriptor(), "class " + qualifiedName); + javaDescriptorSignatureResolver.initializeTypeParameters(typeParameterDescriptorInitializations, classData.getClassDescriptor(), "class " + qualifiedName); // TODO: ugly hack: tests crash if initializeTypeParameters called with class containing proper supertypes supertypes.addAll(getSupertypes(new PsiClassWrapper(psiClass), classData, classData.getTypeParameters()));