if then to elvis: propose transformation to 'let' #KT-26653 Fixed

idea/testData/intentions/branched/ifThenToElvis/replaceWithLet.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+
+fun foo(s: String?) {
+    val x = <caret>if (s != null) {
+        bar(s)
+    }
+    else {
+        13
+    }
+}
+
+fun bar(s: String): Int = 42

idea/testData/intentions/branched/ifThenToElvis/replaceWithLet.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun foo(s: String?) {
+    val x = s?.let { bar(it) } ?: 13
+}
+
+fun bar(s: String): Int = 42

idea/testData/intentions/branched/ifThenToElvis/replaceWithLetAndRenameIt.kt

@@ -0,0 +1,12 @@
+// WITH_RUNTIME
+
+fun foo(it: String?) {
+    val x = <caret>if (it != null) {
+        bar(it)
+    }
+    else {
+        13
+    }
+}
+
+fun bar(s: String): Int = 42

idea/testData/intentions/branched/ifThenToElvis/replaceWithLetAndRenameIt.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+fun foo(it: String?) {
+    val x = it?.let { it1 -> bar(it1) } ?: 13
+}
+
+fun bar(s: String): Int = 42

idea/testData/intentions/branched/ifThenToElvis/replaceWithLetInMember.kt

@@ -1,4 +1,3 @@
-// IS_APPLICABLE: false
 // WITH_RUNTIME
 
 class Test {
@@ -6,9 +5,8 @@ class Test {
         return param1
     }
 
-    fun doAThingIfPresent(param1: String?) {
-        // In theory could propose transformation to 'let'
-        <caret>if (param1 != null) {
+    fun doAThingIfPresent(param1: String?): String {
+        return <caret>if (param1 != null) {
             doAThing(param1)
         } else {
             ""

idea/testData/intentions/branched/ifThenToElvis/replaceWithLetInMember.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+
+class Test {
+    fun doAThing(param1: String): String {
+        return param1
+    }
+
+    fun doAThingIfPresent(param1: String?): String {
+        return param1?.let { doAThing(it) } ?: ""
+    }
+}

idea/testData/intentions/branched/ifThenToElvis/replaceWithLetInMemberWithIs.kt

@@ -1,4 +1,3 @@
-// IS_APPLICABLE: false
 // WITH_RUNTIME
 
 class Test {
@@ -6,9 +5,8 @@ class Test {
         return param1
     }
 
-    fun doAThingIfPresent(param1: String?) {
-        // In theory could propose transformation to 'let'
-        <caret>if (param1 is String) {
+    fun doAThingIfPresent(param1: Any?): String {
+        return <caret>if (param1 is String) {
             doAThing(param1)
         } else {
             ""

idea/testData/intentions/branched/ifThenToElvis/replaceWithLetInMemberWithIs.kt.after

@@ -0,0 +1,11 @@
+// WITH_RUNTIME
+
+class Test {
+    fun doAThing(param1: String): String {
+        return param1
+    }
+
+    fun doAThingIfPresent(param1: Any?): String {
+        return (param1 as? String)?.let { doAThing(it) } ?: ""
+    }
+}