Add variance (in / out) modifier inspection #KT-11090 Fixed

idea/testData/inspections/addVarianceModifier/inspectionData/expected.xml

@@ -0,0 +1,42 @@
+<problems>
+    <problem>
+        <file>test.kt</file>
+        <line>1</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Type parameter can have 'in' or 'out' variance</problem_class>
+        <description>Type parameter can have 'out' variance</description>
+    </problem>
+    <problem>
+        <file>test.kt</file>
+        <line>5</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Type parameter can have 'in' or 'out' variance</problem_class>
+        <description>Type parameter can have 'in' variance</description>
+    </problem>
+    <problem>
+        <file>test.kt</file>
+        <line>17</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Type parameter can have 'in' or 'out' variance</problem_class>
+        <description>Type parameter can have 'out' variance</description>
+    </problem>
+    <problem>
+        <file>test.kt</file>
+        <line>21</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Type parameter can have 'in' or 'out' variance</problem_class>
+        <description>Type parameter can have 'in' variance</description>
+    </problem>
+    <problem>
+        <file>test.kt</file>
+        <line>24</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="temp:///src/test.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Type parameter can have 'in' or 'out' variance</problem_class>
+        <description>Type parameter can have 'in' or 'out' variance</description>
+    </problem>
+</problems>

idea/testData/inspections/addVarianceModifier/inspectionData/inspections.test

@@ -0,0 +1 @@
+// INSPECTION_CLASS: org.jetbrains.kotlin.idea.inspections.AddVarianceModifierInspection

idea/testData/inspections/addVarianceModifier/test.kt

@@ -0,0 +1,24 @@
+interface EffectivelyOut<T> {
+    fun foo(): T
+    val bar: T
+}
+interface EffectivelyIn<T> {
+    fun foo(arg: T)
+}
+interface Invariant1<T> {
+    var bar: T
+}
+interface Invariant2<T> {
+    fun T.foo(): T
+}
+interface Invariant3<T : Invariant1<T>> {
+    fun T.foo()
+}
+abstract class AbstractOut<T> {
+    abstract val foo: T
+    private var bar = foo
+}
+abstract class AbstractIn<T>(private val foo: T) {
+    fun bar(arg: T) = foo == arg
+}
+interface Empty<T>

idea/testData/quickfix/addVarianceModifier/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.AddVarianceModifierInspection

idea/testData/quickfix/addVarianceModifier/Empty.kt

@@ -0,0 +1,2 @@
+// "Add 'out' variance" "true"
+interface Empty<<caret>T>

idea/testData/quickfix/addVarianceModifier/abstractIn.kt

@@ -0,0 +1,4 @@
+// "Add 'in' variance" "true"
+abstract class AbstractIn<<caret>T>(private val foo: T) {
+    fun bar(arg: T) = foo == arg
+}

idea/testData/quickfix/addVarianceModifier/abstractIn.kt.after

@@ -0,0 +1,4 @@
+// "Add 'in' variance" "true"
+abstract class AbstractIn<in T>(private val foo: T) {
+    fun bar(arg: T) = foo == arg
+}

idea/testData/quickfix/addVarianceModifier/abstractOut.kt

@@ -0,0 +1,5 @@
+// "Add 'out' variance" "true"
+abstract class AbstractOut<<caret>T> {
+    abstract val foo: T
+    private var bar = foo
+}

idea/testData/quickfix/addVarianceModifier/abstractOut.kt.after

@@ -0,0 +1,5 @@
+// "Add 'out' variance" "true"
+abstract class AbstractOut<out T> {
+    abstract val foo: T
+    private var bar = foo
+}

idea/testData/quickfix/addVarianceModifier/empty.kt.after

@@ -0,0 +1,2 @@
+// "Add 'out' variance" "true"
+interface Empty<out T>