diff --git a/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java b/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java index 0ad94a702f5..ffe3b583f01 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java +++ b/compiler/frontend/src/org/jetbrains/kotlin/diagnostics/Errors.java @@ -75,7 +75,7 @@ public interface Errors { DiagnosticFactory3 INVISIBLE_MEMBER = DiagnosticFactory3.create(ERROR, CALL_ELEMENT); // Exposed visibility group - DiagnosticFactory2 EXPOSED_PROPERTY_TYPE = DiagnosticFactory2.create(ERROR); + DiagnosticFactory2 EXPOSED_PROPERTY_TYPE = DiagnosticFactory2.create(ERROR); DiagnosticFactory2 EXPOSED_FUNCTION_RETURN_TYPE = DiagnosticFactory2.create(ERROR); DiagnosticFactory2 EXPOSED_PARAMETER_TYPE = DiagnosticFactory2.create(ERROR); DiagnosticFactory2 EXPOSED_RECEIVER_TYPE = DiagnosticFactory2.create(ERROR); diff --git a/compiler/frontend/src/org/jetbrains/kotlin/resolve/DeclarationsChecker.kt b/compiler/frontend/src/org/jetbrains/kotlin/resolve/DeclarationsChecker.kt index e075067da32..96f0d0c31e5 100644 --- a/compiler/frontend/src/org/jetbrains/kotlin/resolve/DeclarationsChecker.kt +++ b/compiler/frontend/src/org/jetbrains/kotlin/resolve/DeclarationsChecker.kt @@ -639,7 +639,7 @@ class DeclarationsChecker( val propertyVisibility = propertyDescriptor.effectiveVisibility() val typeVisibility = propertyDescriptor.type.effectiveVisibility() if (!typeVisibility.sameOrMorePermissive(propertyVisibility)) { - trace.report(EXPOSED_PROPERTY_TYPE.on(property, propertyVisibility, typeVisibility)) + trace.report(EXPOSED_PROPERTY_TYPE.on(property.nameIdentifier ?: property, propertyVisibility, typeVisibility)) } checkMemberReceiverExposedType(property.receiverTypeReference, propertyDescriptor) } diff --git a/compiler/testData/diagnostics/tests/declarationChecks/ambiguousObjectExpressionType.kt b/compiler/testData/diagnostics/tests/declarationChecks/ambiguousObjectExpressionType.kt index 0853172d660..5cd229e471a 100644 --- a/compiler/testData/diagnostics/tests/declarationChecks/ambiguousObjectExpressionType.kt +++ b/compiler/testData/diagnostics/tests/declarationChecks/ambiguousObjectExpressionType.kt @@ -16,13 +16,13 @@ class Foo { privateProperty.f2() } - protected val protectedProperty = object : MyClass(), MyTrait {} + protected val protectedProperty = object : MyClass(), MyTrait {} - val internalProperty = object : MyClass(), MyTrait {} + val internalProperty = object : MyClass(), MyTrait {} - internal val internal2Property = object : MyClass(), MyTrait {} + internal val internal2Property = object : MyClass(), MyTrait {} - public val publicProperty = object : MyClass(), MyTrait {} + public val publicProperty = object : MyClass(), MyTrait {} private fun privateFunction() = object : MyClass(), MyTrait {} @@ -50,13 +50,13 @@ class Foo { privatePropertyInner.f2() } - protected val protectedProperty = object : MyClass(), MyTrait {} + protected val protectedProperty = object : MyClass(), MyTrait {} - val internalProperty = object : MyClass(), MyTrait {} + val internalProperty = object : MyClass(), MyTrait {} - internal val internal2Property = object : MyClass(), MyTrait {} + internal val internal2Property = object : MyClass(), MyTrait {} - public val publicProperty = object : MyClass(), MyTrait {} + public val publicProperty = object : MyClass(), MyTrait {} private fun privateFunctionInner() = object : MyClass(), MyTrait {} @@ -90,13 +90,13 @@ class Foo { private val packagePrivateProperty = object : MyClass(), MyTrait {} -protected val packageProtectedProperty = object : MyClass(), MyTrait {} +protected val packageProtectedProperty = object : MyClass(), MyTrait {} -val packageInternalProperty = object : MyClass(), MyTrait {} +val packageInternalProperty = object : MyClass(), MyTrait {} -internal val packageInternal2Property = object : MyClass(), MyTrait {} +internal val packageInternal2Property = object : MyClass(), MyTrait {} -public val packagePublicProperty = object : MyClass(), MyTrait {} +public val packagePublicProperty = object : MyClass(), MyTrait {} protected fun packageProtectedFunction() = object : MyClass(), MyTrait {} diff --git a/compiler/testData/diagnostics/tests/exposed/internal.kt b/compiler/testData/diagnostics/tests/exposed/internal.kt index 255a3ad355d..4a66f825eca 100644 --- a/compiler/testData/diagnostics/tests/exposed/internal.kt +++ b/compiler/testData/diagnostics/tests/exposed/internal.kt @@ -10,7 +10,7 @@ internal open class Your: My() { open class His: Your() { protected open class Nested // error, public from internal - val x = My() + val x = My() // valid, private from internal private fun bar() = My() // valid, internal from internal diff --git a/compiler/testData/diagnostics/tests/exposed/localInMemberType.kt b/compiler/testData/diagnostics/tests/exposed/localInMemberType.kt index da900209967..8d7af475f85 100644 --- a/compiler/testData/diagnostics/tests/exposed/localInMemberType.kt +++ b/compiler/testData/diagnostics/tests/exposed/localInMemberType.kt @@ -4,9 +4,9 @@ class Something { internal val internalVal1 = object { override fun toString() = "!" } private val privateVal1 = object { override fun toString() = "!" } - public val publicVal2 = run { class A; A() } - protected val protectedVal2 = run { class A; A() } - internal val internalVal2 = run { class A; A() } + public val publicVal2 = run { class A; A() } + protected val protectedVal2 = run { class A; A() } + internal val internalVal2 = run { class A; A() } private val privateVal2 = run { class A; A() } public fun publicFun1() = object { override fun toString() = "!" } diff --git a/compiler/testData/diagnostics/tests/exposed/localInPropertyType.kt b/compiler/testData/diagnostics/tests/exposed/localInPropertyType.kt index 0cbe05741a8..38f8b7cbd01 100644 --- a/compiler/testData/diagnostics/tests/exposed/localInPropertyType.kt +++ b/compiler/testData/diagnostics/tests/exposed/localInPropertyType.kt @@ -2,27 +2,27 @@ class My(val value: T) open class Base -val invalid1 = run { +val invalid1 = run { class Local My(Local()) -} +} -val invalid2 = My(object {}) +val invalid2 = My(object {}) -val invalid3 = My(object : Base() {}) +val invalid3 = My(object : Base() {}) -val invalid4 = run { +val invalid4 = run { class Local My(My(Local())) -} +} -val invalid5 = run { +val invalid5 = run { fun invalid5a() = run { class Local Local() } My(invalid5a()) -} +} // Valid: effectively Any val valid1 = object {} diff --git a/compiler/testData/diagnostics/tests/exposed/object.kt b/compiler/testData/diagnostics/tests/exposed/object.kt index 109fc25d91e..fd7d8bbbda9 100644 --- a/compiler/testData/diagnostics/tests/exposed/object.kt +++ b/compiler/testData/diagnostics/tests/exposed/object.kt @@ -1,7 +1,7 @@ // From KT-10753 object My : Inter() { fun foo(arg: Inter): Inter = arg - val x: Inter? = null + val x: Inter? = null } internal open class Inter diff --git a/compiler/testData/diagnostics/tests/exposed/simple.kt b/compiler/testData/diagnostics/tests/exposed/simple.kt index 6c21a890bcf..c5348c66589 100644 --- a/compiler/testData/diagnostics/tests/exposed/simple.kt +++ b/compiler/testData/diagnostics/tests/exposed/simple.kt @@ -10,7 +10,7 @@ public class Derived<T: My>(xx: My?, x: My): this(xx ?: x) - val y: Base? = null + val y: Base? = null val My.z: Int get() = 42 diff --git a/compiler/testData/diagnostics/tests/imports/InaccessiblePrivateClass.kt b/compiler/testData/diagnostics/tests/imports/InaccessiblePrivateClass.kt index f8ac999bb3a..358ed929e8b 100644 --- a/compiler/testData/diagnostics/tests/imports/InaccessiblePrivateClass.kt +++ b/compiler/testData/diagnostics/tests/imports/InaccessiblePrivateClass.kt @@ -15,4 +15,4 @@ package p1 import p2.* val x: X = X() -val y: Y = Y() +val y: Y = Y() diff --git a/compiler/testData/diagnostics/tests/j+k/packageVisibility.kt b/compiler/testData/diagnostics/tests/j+k/packageVisibility.kt index 06b89d9879c..3f614cbca9e 100644 --- a/compiler/testData/diagnostics/tests/j+k/packageVisibility.kt +++ b/compiler/testData/diagnostics/tests/j+k/packageVisibility.kt @@ -16,29 +16,29 @@ class MyJavaClass { //FILE:a.kt package a -val mc = MyJavaClass() +val mc = MyJavaClass() val x = MyJavaClass.staticMethod() val y = MyJavaClass.NestedClass.staticMethodOfNested() -val z = MyJavaClass.NestedClass() +val z = MyJavaClass.NestedClass() //FILE: b.kt package b import a.MyJavaClass -val mc1 = MyJavaClass() +val mc1 = MyJavaClass() val x = MyJavaClass.staticMethod() val y = MyJavaClass.NestedClass.staticMethodOfNested() -val z = MyJavaClass.NestedClass() +val z = MyJavaClass.NestedClass() //FILE: c.kt package a.c import a.MyJavaClass -val mc1 = MyJavaClass() +val mc1 = MyJavaClass() val x = MyJavaClass.staticMethod() val y = MyJavaClass.NestedClass.staticMethodOfNested() -val z = MyJavaClass.NestedClass() \ No newline at end of file +val z = MyJavaClass.NestedClass() \ No newline at end of file diff --git a/compiler/testData/diagnostics/tests/resolve/constructorVsCompanion.kt b/compiler/testData/diagnostics/tests/resolve/constructorVsCompanion.kt index b3a45c91266..d371da9c931 100644 --- a/compiler/testData/diagnostics/tests/resolve/constructorVsCompanion.kt +++ b/compiler/testData/diagnostics/tests/resolve/constructorVsCompanion.kt @@ -17,7 +17,7 @@ class E private constructor() { } val a = A -val b = B +val b = B val c = C val d = D val e = E(42) \ No newline at end of file diff --git a/compiler/testData/diagnostics/testsWithStdLib/InaccessibleInternalClass.kt b/compiler/testData/diagnostics/testsWithStdLib/InaccessibleInternalClass.kt index 1574d35641e..bb4f2196574 100644 --- a/compiler/testData/diagnostics/testsWithStdLib/InaccessibleInternalClass.kt +++ b/compiler/testData/diagnostics/testsWithStdLib/InaccessibleInternalClass.kt @@ -11,5 +11,5 @@ import p.* interface I { val v1: FilteringSequence - val v2: IndexingSequence + val v2: IndexingSequence }