Fix default positioning strategy handling
that causes flaky tests because the default positioning strategy was dependent on the order of the reported messages. The code led to it was introduced in an attempt to extract common PSI-independent strategy because PSI is leaking into the abstract diagnostic infrastructure. The approach is definitely problematic, but to fix it now, the leaking dependency to the psi-based module is introduced. This should be fixed in the future by introducing better abstractions. Fixes flaky tests touched in the commit. #KT-63002 fixed
This commit is contained in:
committed by
Space Team
parent
0de04f934e
commit
1ad4f19181
@@ -1,11 +0,0 @@
|
||||
// ISSUE: KT-62447, KT-62628
|
||||
// FIR_DUMP
|
||||
|
||||
fun main() {
|
||||
val x: <!SYNTAX, WRONG_ANNOTATION_TARGET!>@SinceKotlin("2.0")<!><!SYNTAX!><!>
|
||||
}
|
||||
|
||||
@Target(AnnotationTarget.TYPE)
|
||||
annotation class Anno
|
||||
|
||||
val prop: @Anno <!UNRESOLVED_REFERENCE!>Foo<!>? = null
|
||||
+1
-1
@@ -1,4 +1,4 @@
|
||||
FILE: AnnotatedErrorTypeRef.fir.kt
|
||||
FILE: AnnotatedErrorTypeRef.kt
|
||||
public final fun main(): R|kotlin/Unit| {
|
||||
lval x: @R|kotlin/SinceKotlin|(version = String(2.0)) <ERROR TYPE REF: Incomplete code>
|
||||
}
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
// FIR_IDENTICAL
|
||||
// ISSUE: KT-62447, KT-62628
|
||||
// FIR_DUMP
|
||||
|
||||
|
||||
Reference in New Issue
Block a user