azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[K/N] Disable mutation checks if freezing is disabled

Browse Source
This commit is contained in:
Sergey Bogolepov
2022-04-13 10:51:37 +00:00
committed by Space
parent e72dc7d0c9
commit 19658b3a47
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
kotlin-native/backend.native/compiler/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/llvm/IrToBitcode.kt
+11 -5
View File
@@ -1740,7 +1740,12 @@ internal class CodeGeneratorVisitor(val context: Context, val lifetimes: Map<IrE
private fun needMutationCheck(irClass: IrClass): Boolean { private fun needMutationCheck(irClass: IrClass): Boolean {
// For now we omit mutation checks on immutable types, as this allows initialization in constructor // For now we omit mutation checks on immutable types, as this allows initialization in constructor
// and it is assumed that API doesn't allow to change them. // and it is assumed that API doesn't allow to change them.
return !irClass.isFrozen(context) return context.config.freezing.enableFreezeChecks && !irClass.isFrozen(context)
}
private fun needLifetimeConstraintsCheck(valueToAssign: LLVMValueRef, irClass: IrClass): Boolean {
// TODO: Likely, we don't need isFrozen check here at all.
return functionGenerationContext.isObjectType(valueToAssign.type) && !irClass.isFrozen(context)
} }
private fun isZeroConstValue(value: IrExpression): Boolean { private fun isZeroConstValue(value: IrExpression): Boolean {
@@ -1776,13 +1781,14 @@ internal class CodeGeneratorVisitor(val context: Context, val lifetimes: Map<IrE
assert(thisPtr.type == codegen.kObjHeaderPtr) { assert(thisPtr.type == codegen.kObjHeaderPtr) {
LLVMPrintTypeToString(thisPtr.type)?.toKString().toString() LLVMPrintTypeToString(thisPtr.type)?.toKString().toString()
} }
if (needMutationCheck(value.symbol.owner.parentAsClass)) { val parentAsClass = value.symbol.owner.parentAsClass
if (needMutationCheck(parentAsClass)) {
functionGenerationContext.call(context.llvm.mutationCheck, functionGenerationContext.call(context.llvm.mutationCheck,
listOf(functionGenerationContext.bitcast(codegen.kObjHeaderPtr, thisPtr)), listOf(functionGenerationContext.bitcast(codegen.kObjHeaderPtr, thisPtr)),
Lifetime.IRRELEVANT, currentCodeContext.exceptionHandler) Lifetime.IRRELEVANT, currentCodeContext.exceptionHandler)
}
if (functionGenerationContext.isObjectType(valueToAssign.type)) if (needLifetimeConstraintsCheck(valueToAssign, parentAsClass)) {
functionGenerationContext.call(context.llvm.checkLifetimesConstraint, listOf(thisPtr, valueToAssign)) functionGenerationContext.call(context.llvm.checkLifetimesConstraint, listOf(thisPtr, valueToAssign))
} }
functionGenerationContext.storeAny(valueToAssign, fieldPtrOfClass(thisPtr, value.symbol.owner), false) functionGenerationContext.storeAny(valueToAssign, fieldPtrOfClass(thisPtr, value.symbol.owner), false)
} else { } else {