FIR IDE: Fix import of properties; also fix bug in alreadyHasImport

idea/idea-completion/testData/handlers/multifile/AlreadyImportedExtensionPropertyNoImport-1.kt

@@ -0,0 +1,8 @@
+// FIR_COMPARISON
+package first
+
+import second.extensionProp
+
+fun foo() {
+    "".extensi<caret>
+}

idea/idea-completion/testData/handlers/multifile/AlreadyImportedExtensionPropertyNoImport-2.kt

@@ -0,0 +1,4 @@
+package second
+
+val String.extensionProp: Int
+    get() = 1

idea/idea-completion/testData/handlers/multifile/AlreadyImportedExtensionPropertyNoImport.kt.after

@@ -0,0 +1,8 @@
+// FIR_COMPARISON
+package first
+
+import second.extensionProp
+
+fun foo() {
+    "".extensionProp<caret>
+}

idea/idea-completion/tests/org/jetbrains/kotlin/idea/completion/test/handlers/CompletionMultifileHandlerTest.kt

@@ -26,6 +26,10 @@ open class CompletionMultiFileHandlerTest : KotlinFixtureCompletionBaseTestCase(
         doTest()
     }
 
+    fun testAlreadyImportedExtensionPropertyNoImport() {
+        doTest()
+    }
+
     fun testExtensionPropertyInSamePackageNoImport() {
         doTest()
     }

idea/idea-fir/src/org/jetbrains/kotlin/idea/completion/KotlinFirLookupElementFactory.kt

@@ -132,11 +132,15 @@ private class VariableLookupElementFactory {
         if (setterName != null) "$getterName()/$setterName()" else "$getterName()"
 
     private fun detectImportStrategy(symbol: KtVariableLikeSymbol): CallableImportStrategy {
-        if (symbol !is KtKotlinPropertySymbol) return CallableImportStrategy.DoNothing
+        if (symbol !is KtKotlinPropertySymbol || symbol.dispatchType != null) return CallableImportStrategy.DoNothing
-        if (symbol.dispatchType != null || symbol.receiverType != null) return CallableImportStrategy.DoNothing
 
-        return symbol.callableIdIfNonLocal?.let(CallableImportStrategy::InsertFqNameAndShorten)
+        val propertyId = symbol.callableIdIfNonLocal ?: return CallableImportStrategy.DoNothing
-            ?: CallableImportStrategy.DoNothing
+
+        return if (symbol.isExtension) {
+            CallableImportStrategy.AddImport(propertyId)
+        } else {
+            CallableImportStrategy.InsertFqNameAndShorten(propertyId)
+        }
     }
 }
 
@@ -163,12 +167,14 @@ private class FunctionLookupElementFactory {
     }
 
     private fun detectImportStrategy(symbol: KtFunctionSymbol): CallableImportStrategy {
-        val functionFqName = symbol.callableIdIfNonLocal
+        if (symbol.dispatchType != null) return CallableImportStrategy.DoNothing
-        return when {
+
-            functionFqName == null -> CallableImportStrategy.DoNothing
+        val functionFqName = symbol.callableIdIfNonLocal ?: return CallableImportStrategy.DoNothing
-            symbol.dispatchType != null -> CallableImportStrategy.DoNothing
+
-            !symbol.isExtension -> CallableImportStrategy.InsertFqNameAndShorten(functionFqName)
+        return if (symbol.isExtension) {
-            else -> CallableImportStrategy.AddImport(functionFqName)
+            CallableImportStrategy.AddImport(functionFqName)
+        } else {
+            CallableImportStrategy.InsertFqNameAndShorten(functionFqName)
         }
     }
 
@@ -356,7 +362,7 @@ private fun addCallableImportIfRequired(targetFile: KtFile, nameToImport: FqName
 }
 
 private fun alreadyHasImport(file: KtFile, nameToImport: FqName): Boolean {
-    if (file.importDirectives.any { it.importPath?.fqName == nameToImport }) return false
+    if (file.importDirectives.any { it.importPath?.fqName == nameToImport }) return true
 
     withAllowedResolve {
         analyze(file) {