From 17bbedbc50f90550d3c3e6ba1246ba5290009e9b Mon Sep 17 00:00:00 2001 From: Dmitriy Novozhilov Date: Mon, 2 Aug 2021 17:45:46 +0300 Subject: [PATCH] [Test] Fix FileComparisonFailureFirst comparator to keep sorting stability --- .../jetbrains/kotlin/test/services/JUnit5Assertions.kt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/compiler/tests-common-new/tests/org/jetbrains/kotlin/test/services/JUnit5Assertions.kt b/compiler/tests-common-new/tests/org/jetbrains/kotlin/test/services/JUnit5Assertions.kt index 3f5ec7271cd..9ecc85f3f9f 100644 --- a/compiler/tests-common-new/tests/org/jetbrains/kotlin/test/services/JUnit5Assertions.kt +++ b/compiler/tests-common-new/tests/org/jetbrains/kotlin/test/services/JUnit5Assertions.kt @@ -76,8 +76,13 @@ object JUnit5Assertions : AssertionsService() { } private object FileComparisonFailureFirst : Comparator { - override fun compare(o1: Throwable?, o2: Throwable?): Int { - return if (o1 is FileComparisonFailure) -1 else 0 + override fun compare(o1: Throwable, o2: Throwable): Int { + return when { + o1 is FileComparisonFailure && o2 is FileComparisonFailure -> 0 + o1 is FileComparisonFailure -> -1 + o2 is FileComparisonFailure -> 1 + else -> 0 + } } } }