[FIR] Make sure the primary constructor is first in class CFG

The primary constructor of a class needs to be the first subgraph of the
class control-flow graph. Based on the Kotlin specification, class
initialization order goes first primary constructor, in-place
declarations (properties and init blocks), and then secondary
constructors. If the class doesn't have a primary constructor, then it
is just skipped in the order.

Unfortunately, the class control-flow graph had in-place declarations
first and then all constructors. Instead, we should treat the primary
constructor as the first in-place declaration, and then continue with
the existing processing as secondary constructors. This will guarantee
that super constructor calls have the correct property initialization
information.

^KT-65093 Fixed

This commit is contained in:

Brian Norman

2024-01-18 20:17:17 -06:00

committed by

Space Team

parent c628172235

commit 17a1871b83

28 changed files with 732 additions and 900 deletions

									
										compiler/testData/diagnostics/tests/controlFlowAnalysis/deadCode/initializationInUnreachableCode.fir.kt
									
Vendored

		+2
		-2
	
												View File
												
				@@ -2,8 +2,8 @@

				fun error(): Nothing = throw Exception()

				class Some<!UNREACHABLE_CODE!>()<!> {

				    var x: Int

				class Some() {

				    <!MUST_BE_INITIALIZED_OR_BE_ABSTRACT!>var x: Int<!>

				    val y: Int = error()

				    init {