Check element disposed before getting component in migration (EA-134713)

Check if it can reduce the exceptions rate and check for deeper exceptions.
This commit is contained in:
Nikolay Krasko
2019-01-25 16:08:48 +03:00
parent d1b7c0f683
commit 16ff522cd3
7 changed files with 38 additions and 15 deletions
@@ -19,7 +19,7 @@ class MavenImportListener(val project: Project) : MavenProjectsManager.Listener
MavenImportListener.TOPIC,
MavenImportListener { _: Collection<MavenProject>, _: List<Module> ->
notifyOutdatedBundledCompilerIfNecessary(project)
KotlinMigrationProjectComponent.getInstance(project).onImportFinished()
KotlinMigrationProjectComponent.getInstanceIfNotDisposed(project)?.onImportFinished()
}
)
@@ -27,6 +27,6 @@ class MavenImportListener(val project: Project) : MavenProjectsManager.Listener
}
override fun projectsScheduled() {
KotlinMigrationProjectComponent.getInstance(project).onImportAboutToStart()
KotlinMigrationProjectComponent.getInstanceIfNotDisposed(project)?.onImportAboutToStart()
}
}
@@ -104,7 +104,8 @@ class MavenMigrateTest : MavenImportingTestCase() {
}
val importResult = FutureResult<KotlinMigrationProjectComponent.MigrationTestState?>()
val migrationProjectComponent = KotlinMigrationProjectComponent.getInstance(myProject)
val migrationProjectComponent = KotlinMigrationProjectComponent.getInstanceIfNotDisposed(myProject)
?: error("Disposed project")
migrationProjectComponent.setImportFinishListener { migrationState ->
importResult.set(migrationState)