From 154a54a1e72fc19e54e8d7c0417bbe60853db0f1 Mon Sep 17 00:00:00 2001
From: Ilya Kirillov <ilya.kirillov@jetbrains.com>
Date: Thu, 23 Jun 2022 21:33:18 +0200
Subject: [PATCH] [Analysis API] add more info to the error message of
 KtCallResolverMixIn

---
 .../analysis/api/components/KtCallResolver.kt | 31 +++++++++++--------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/analysis/analysis-api/src/org/jetbrains/kotlin/analysis/api/components/KtCallResolver.kt b/analysis/analysis-api/src/org/jetbrains/kotlin/analysis/api/components/KtCallResolver.kt
index a64f92b163a..5e7ddaf6efb 100644
--- a/analysis/analysis-api/src/org/jetbrains/kotlin/analysis/api/components/KtCallResolver.kt
+++ b/analysis/analysis-api/src/org/jetbrains/kotlin/analysis/api/components/KtCallResolver.kt
@@ -8,6 +8,7 @@ package org.jetbrains.kotlin.analysis.api.components
 import org.jetbrains.kotlin.analysis.api.calls.KtCallCandidateInfo
 import org.jetbrains.kotlin.analysis.api.calls.KtCallInfo
 import org.jetbrains.kotlin.analysis.api.lifetime.withValidityAssertion
+import org.jetbrains.kotlin.analysis.utils.printer.getElementTextInContext
 import org.jetbrains.kotlin.psi.KtArrayAccessExpression
 import org.jetbrains.kotlin.psi.KtCallElement
 import org.jetbrains.kotlin.psi.KtElement
@@ -23,21 +24,21 @@ public interface KtCallResolverMixIn : KtAnalysisSessionMixIn {
     public fun KtElement.resolveCall(): KtCallInfo? =
         withValidityAssertion { withValidityAssertion { analysisSession.callResolver.resolveCall(this) } }
 
-    public fun KtCallElement.resolveCall(): KtCallInfo =
-        withValidityAssertion {
-            analysisSession.callResolver.resolveCall(this)
-                ?: error("KtCallElement should always resolve to a KtCallInfo")
-        }
+    public fun KtCallElement.resolveCall(): KtCallInfo = withValidityAssertion {
+        analysisSession.callResolver.resolveCall(this)
+            ?: unresolvedKtCallError(this)
+    }
 
-    public fun KtUnaryExpression.resolveCall(): KtCallInfo =
-        withValidityAssertion {
-            analysisSession.callResolver.resolveCall(this) ?: error("KtUnaryExpression should always resolve to a KtCallInfo")
-        }
+    public fun KtUnaryExpression.resolveCall(): KtCallInfo = withValidityAssertion {
+        analysisSession.callResolver.resolveCall(this)
+            ?: unresolvedKtCallError(this)
+    }
 
-    public fun KtArrayAccessExpression.resolveCall(): KtCallInfo =
-        withValidityAssertion {
-            analysisSession.callResolver.resolveCall(this) ?: error("KtArrayAccessExpression should always resolve to a KtCallInfo")
-        }
+
+    public fun KtArrayAccessExpression.resolveCall(): KtCallInfo = withValidityAssertion {
+        analysisSession.callResolver.resolveCall(this)
+            ?: unresolvedKtCallError(this)
+    }
 
     /**
      * Returns all the candidates considered during [overload resolution](https://kotlinlang.org/spec/overload-resolution.html) for the call
@@ -49,3 +50,7 @@ public interface KtCallResolverMixIn : KtAnalysisSessionMixIn {
     public fun KtElement.collectCallCandidates(): List<KtCallCandidateInfo> =
         withValidityAssertion { analysisSession.callResolver.collectCallCandidates(this) }
 }
+
+private inline fun <reified PSI : KtElement> unresolvedKtCallError(element: PSI): Nothing {
+    error("${PSI::class.simpleName} should always resolve to a KtCallInfo\nelement: ${element::class.simpleName}\ntext:\n${element.getElementTextInContext()}")
+}