From 144ec9285f64d228ffcb859f26c1431c787ee83b Mon Sep 17 00:00:00 2001 From: Yan Zhulanow Date: Mon, 22 Jan 2018 17:52:03 +0300 Subject: [PATCH] Minor: Get rid of duplicating option descriptions in Kapt plugin --- .../org/jetbrains/kotlin/kapt3/Kapt3Plugin.kt | 42 ++++++++++++------- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/plugins/kapt3/kapt3-compiler/src/org/jetbrains/kotlin/kapt3/Kapt3Plugin.kt b/plugins/kapt3/kapt3-compiler/src/org/jetbrains/kotlin/kapt3/Kapt3Plugin.kt index a889241ef4c..fd75f5d676c 100644 --- a/plugins/kapt3/kapt3-compiler/src/org/jetbrains/kotlin/kapt3/Kapt3Plugin.kt +++ b/plugins/kapt3/kapt3-compiler/src/org/jetbrains/kotlin/kapt3/Kapt3Plugin.kt @@ -38,6 +38,20 @@ import org.jetbrains.kotlin.config.JVMConfigurationKeys import org.jetbrains.kotlin.container.ComponentProvider import org.jetbrains.kotlin.context.ProjectContext import org.jetbrains.kotlin.descriptors.ModuleDescriptor +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.ANNOTATION_PROCESSORS_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.ANNOTATION_PROCESSOR_CLASSPATH_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.APT_MODE_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.APT_ONLY_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.APT_OPTIONS_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.CLASS_OUTPUT_DIR_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.CORRECT_ERROR_TYPES_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.INCREMENTAL_DATA_OUTPUT_DIR_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.JAVAC_CLI_OPTIONS_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.MAP_DIAGNOSTIC_LOCATIONS_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.SOURCE_OUTPUT_DIR_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.STUBS_OUTPUT_DIR_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.USE_LIGHT_ANALYSIS_OPTION +import org.jetbrains.kotlin.kapt3.Kapt3CommandLineProcessor.Companion.VERBOSE_MODE_OPTION import org.jetbrains.kotlin.kapt3.util.KaptLogger import org.jetbrains.kotlin.psi.KtFile import org.jetbrains.kotlin.resolve.BindingTrace @@ -50,47 +64,47 @@ import java.util.* object Kapt3ConfigurationKeys { val SOURCE_OUTPUT_DIR: CompilerConfigurationKey = - CompilerConfigurationKey.create("source files output directory") + CompilerConfigurationKey.create(SOURCE_OUTPUT_DIR_OPTION.description) val CLASS_OUTPUT_DIR: CompilerConfigurationKey = - CompilerConfigurationKey.create("class files output directory") + CompilerConfigurationKey.create(CLASS_OUTPUT_DIR_OPTION.description) val STUBS_OUTPUT_DIR: CompilerConfigurationKey = - CompilerConfigurationKey.create("stubs output directory") + CompilerConfigurationKey.create(STUBS_OUTPUT_DIR_OPTION.description) val INCREMENTAL_DATA_OUTPUT_DIR: CompilerConfigurationKey = - CompilerConfigurationKey.create("incremental data output directory") + CompilerConfigurationKey.create(INCREMENTAL_DATA_OUTPUT_DIR_OPTION.description) val ANNOTATION_PROCESSOR_CLASSPATH: CompilerConfigurationKey> = - CompilerConfigurationKey.create>("annotation processor classpath") + CompilerConfigurationKey.create>(ANNOTATION_PROCESSOR_CLASSPATH_OPTION.description) val APT_OPTIONS: CompilerConfigurationKey = - CompilerConfigurationKey.create("annotation processing options") + CompilerConfigurationKey.create(APT_OPTIONS_OPTION.description) val JAVAC_CLI_OPTIONS: CompilerConfigurationKey = - CompilerConfigurationKey.create("javac CLI options") + CompilerConfigurationKey.create(JAVAC_CLI_OPTIONS_OPTION.description) val ANNOTATION_PROCESSORS: CompilerConfigurationKey = - CompilerConfigurationKey.create("annotation processor qualified names") + CompilerConfigurationKey.create(ANNOTATION_PROCESSORS_OPTION.description) val VERBOSE_MODE: CompilerConfigurationKey = - CompilerConfigurationKey.create("verbose mode") + CompilerConfigurationKey.create(VERBOSE_MODE_OPTION.description) @Deprecated("Use APT_MODE instead.") val APT_ONLY: CompilerConfigurationKey = - CompilerConfigurationKey.create("do only annotation processing") + CompilerConfigurationKey.create(APT_ONLY_OPTION.description) val APT_MODE: CompilerConfigurationKey = - CompilerConfigurationKey.create("annotation processing mode") + CompilerConfigurationKey.create(APT_MODE_OPTION.description) val USE_LIGHT_ANALYSIS: CompilerConfigurationKey = - CompilerConfigurationKey.create("do not analyze declaration bodies if can") + CompilerConfigurationKey.create(USE_LIGHT_ANALYSIS_OPTION.description) val CORRECT_ERROR_TYPES: CompilerConfigurationKey = - CompilerConfigurationKey.create("replace error types with ones from the declaration sources") + CompilerConfigurationKey.create(CORRECT_ERROR_TYPES_OPTION.description) val MAP_DIAGNOSTIC_LOCATIONS: CompilerConfigurationKey = - CompilerConfigurationKey.create("map diagnostic reported on kapt stubs to original locations in Kotlin sources") + CompilerConfigurationKey.create(MAP_DIAGNOSTIC_LOCATIONS_OPTION.description) } class Kapt3CommandLineProcessor : CommandLineProcessor {