[Test] Move extracting JVM_TARGET to provideConfigurationKeys

This commit is contained in:
Dmitriy Novozhilov
2021-02-10 11:02:01 +03:00
committed by TeamCityServer
parent 606ae45f5f
commit 1216b33593
3 changed files with 4 additions and 10 deletions
@@ -323,10 +323,6 @@ class CodegenTestsOnAndroidGenerator private constructor(private val pathManager
services.registerDependencyProvider(DependencyProviderImpl(services, moduleStructure.modules))
val keyConfiguration = CompilerConfiguration()
module.directives.singleOrZeroValue(JvmEnvironmentConfigurationDirectives.JVM_TARGET)?.let {
keyConfiguration.put(JVMConfigurationKeys.JVM_TARGET, it)
}
val configuratorForFlags = JvmEnvironmentConfigurator(services)
with(configuratorForFlags) {
val extractor = DirectiveToConfigurationKeyExtractor()
@@ -27,10 +27,10 @@ abstract class EnvironmentConfigurator(protected val testServices: TestServices)
configuration: CompilerConfiguration,
module: TestModule,
) {
configureCompilerConfiguration(configuration, module)
val extractor = DirectiveToConfigurationKeyExtractor()
extractor.provideConfigurationKeys()
extractor.configure(configuration, module.directives)
configureCompilerConfiguration(configuration, module)
}
open fun DirectiveToConfigurationKeyExtractor.provideConfigurationKeys() {}
@@ -21,6 +21,7 @@ import org.jetbrains.kotlin.test.TestJdkKind
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.ASSERTIONS_MODE
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.CONSTRUCTOR_CALL_NORMALIZATION_MODE
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.JVM_TARGET
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.LAMBDAS
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.SAM_CONVERSIONS
import org.jetbrains.kotlin.test.directives.JvmEnvironmentConfigurationDirectives.STRING_CONCAT
@@ -34,7 +35,6 @@ import org.jetbrains.kotlin.test.directives.LanguageSettingsDirectives.NO_UNIFIE
import org.jetbrains.kotlin.test.directives.LanguageSettingsDirectives.PARAMETERS_METADATA
import org.jetbrains.kotlin.test.directives.model.DirectivesContainer
import org.jetbrains.kotlin.test.directives.model.RegisteredDirectives
import org.jetbrains.kotlin.test.directives.model.singleOrZeroValue
import org.jetbrains.kotlin.test.model.DependencyDescription
import org.jetbrains.kotlin.test.model.DependencyKind
import org.jetbrains.kotlin.test.model.TestModule
@@ -73,15 +73,13 @@ class JvmEnvironmentConfigurator(testServices: TestServices) : EnvironmentConfig
register(DISABLE_CALL_ASSERTIONS, JVMConfigurationKeys.DISABLE_CALL_ASSERTIONS)
register(NO_UNIFIED_NULL_CHECKS, JVMConfigurationKeys.NO_UNIFIED_NULL_CHECKS)
register(PARAMETERS_METADATA, JVMConfigurationKeys.PARAMETERS_METADATA)
register(JVM_TARGET, JVMConfigurationKeys.JVM_TARGET)
}
override fun configureCompilerConfiguration(configuration: CompilerConfiguration, module: TestModule) {
if (module.targetPlatform !in JvmPlatforms.allJvmPlatforms) return
val registeredDirectives = module.directives
registeredDirectives.singleOrZeroValue(JvmEnvironmentConfigurationDirectives.JVM_TARGET)?.let {
configuration.put(JVMConfigurationKeys.JVM_TARGET, it)
}
configureDefaultJvmTarget(configuration)
val registeredDirectives = module.directives
when (extractJdkKind(registeredDirectives)) {
TestJdkKind.MOCK_JDK -> {