Inspection (and quickfix) for extension propeties conflicting with synthetic ones

idea/testData/inspections/conflictingExtensionProperty/File.kt

@@ -0,0 +1,16 @@
+import java.io.File
+import java.io.Serializable
+
+val File.name: String
+    get() = getName()
+
+val Serializable.name: String
+    get() = ""
+
+val File.parent: File
+    get() = getParentFile()
+
+class MyFile : File("")
+
+val MyFile.isFile: Boolean
+    get() = isFile()

idea/testData/inspections/conflictingExtensionProperty/inspectionData/expected.xml

@@ -0,0 +1,28 @@
+<problems>
+    <problem>
+        <file>File.kt</file>
+        <line>4</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="File.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Extension property conflicts with automatically produced one</problem_class>
+        <description>This property conflicts with synthetic extension and should be removed to avoid breaking code by future changes in the compiler</description>
+    </problem>
+
+    <problem>
+        <file>File.kt</file>
+        <line>10</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="File.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Extension property conflicts with automatically produced one</problem_class>
+        <description>This property conflicts with synthetic extension and should be removed to avoid breaking code by future changes in the compiler</description>
+    </problem>
+
+    <problem>
+        <file>File.kt</file>
+        <line>15</line>
+        <module>light_idea_test_case</module>
+        <entry_point TYPE="file" FQNAME="File.kt" />
+        <problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">Extension property conflicts with automatically produced one</problem_class>
+        <description>This property conflicts with synthetic extension and should be removed to avoid breaking code by future changes in the compiler</description>
+    </problem>
+</problems>

idea/testData/inspections/conflictingExtensionProperty/inspectionData/inspections.test

@@ -0,0 +1 @@
+// INSPECTION_CLASS: org.jetbrains.kotlin.idea.inspections.ConflictingExtensionPropertyInspection

idea/testData/quickfix/deprecatedSymbolUsage/javaDeprecated.before.Main.kt

@@ -1,5 +1,4 @@
 // "class org.jetbrains.kotlin.idea.quickfix.DeprecatedSymbolUsageFix" "false"
-// ACTION: Inspection 'DEPRECATED_SYMBOL_WITH_MESSAGE' options
 
 fun foo() {
     val c = JavaClass()

idea/testData/quickfix/migration/deleteRedundantExtension/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.ConflictingExtensionPropertyInspection

idea/testData/quickfix/migration/deleteRedundantExtension/explicitThis.kt

@@ -0,0 +1,7 @@
+// "Delete redundant extension property" "true"
+
+var Thread.<caret>priority: Int
+    get() = this.getPriority()
+    set(value) {
+        this.setPriority(value)
+    }

idea/testData/quickfix/migration/deleteRedundantExtension/explicitThis.kt.after

@@ -0,0 +1,2 @@
+// "Delete redundant extension property" "true"
+

idea/testData/quickfix/migration/deleteRedundantExtension/memberExtension.kt

@@ -0,0 +1,7 @@
+// "Delete redundant extension property" "true"
+import java.io.File
+
+class C {
+    val File.<caret>name: String
+        get() = getName()
+}

idea/testData/quickfix/migration/deleteRedundantExtension/memberExtension.kt.after

@@ -0,0 +1,5 @@
+// "Delete redundant extension property" "true"
+import java.io.File
+
+class C {
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.after.JustImport.kt

@@ -0,0 +1,4 @@
+package test
+
+fun foo() {
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.after.StarImport.kt

@@ -0,0 +1,8 @@
+package test
+
+import java.io.File
+import utils.*
+
+fun foo(file: File) {
+    print(file.name)
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.after.Usages.kt

@@ -0,0 +1,7 @@
+package test
+
+import java.io.File
+
+fun foo(file: File) {
+    print(file.name)
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.after.kt

@@ -0,0 +1,6 @@
+// "Delete redundant extension property" "true"
+package utils
+
+import java.io.File
+
+// WITH_RUNTIME

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.before.JustImport.kt

@@ -0,0 +1,6 @@
+package test
+
+import utils.name
+
+fun foo() {
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.before.Main.kt

@@ -0,0 +1,9 @@
+// "Delete redundant extension property" "true"
+package utils
+
+import java.io.File
+
+val File.<caret>name: String
+    get() = getName()
+
+// WITH_RUNTIME

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.before.StarImport.kt

@@ -0,0 +1,8 @@
+package test
+
+import java.io.File
+import utils.*
+
+fun foo(file: File) {
+    print(file.name)
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImports.before.Usages.kt

@@ -0,0 +1,8 @@
+package test
+
+import java.io.File
+import utils.name
+
+fun foo(file: File) {
+    print(file.name)
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImportsOverloads.after.Usages.kt

@@ -0,0 +1,9 @@
+package test
+
+import java.io.File
+import utils.name
+
+fun foo(file: File, thread: Thread) {
+    print(file.name)
+    print(thread.name)
+}

idea/testData/quickfix/migration/deleteRedundantExtension/removeImportsOverloads.after.kt

@@ -0,0 +1,9 @@
+// "Delete redundant extension property" "true"
+package utils
+
+import java.io.File
+
+val Thread.name: String
+    get() = getName()
+
+// WITH_RUNTIME

idea/testData/quickfix/migration/deleteRedundantExtension/removeImportsOverloads.before.Main.kt

@@ -0,0 +1,12 @@
+// "Delete redundant extension property" "true"
+package utils
+
+import java.io.File
+
+val File.<caret>name: String
+    get() = getName()
+
+val Thread.name: String
+    get() = getName()
+
+// WITH_RUNTIME

idea/testData/quickfix/migration/deleteRedundantExtension/removeImportsOverloads.before.Usages.kt

@@ -0,0 +1,9 @@
+package test
+
+import java.io.File
+import utils.name
+
+fun foo(file: File, thread: Thread) {
+    print(file.name)
+    print(thread.name)
+}

idea/testData/quickfix/migration/deleteRedundantExtension/returnInGetter.kt

@@ -0,0 +1,5 @@
+// "Delete redundant extension property" "true"
+import java.io.File
+
+val File.<caret>name: String
+    get() { return getName() }

idea/testData/quickfix/migration/deleteRedundantExtension/returnInGetter.kt.after

@@ -0,0 +1,3 @@
+// "Delete redundant extension property" "true"
+import java.io.File
+

idea/testData/quickfix/migration/deleteRedundantExtension/simple.kt

@@ -0,0 +1,5 @@
+// "Delete redundant extension property" "true"
+import java.io.File
+
+val File.<caret>name: String
+    get() = getName()

idea/testData/quickfix/migration/deleteRedundantExtension/simple.kt.after

@@ -0,0 +1,3 @@
+// "Delete redundant extension property" "true"
+import java.io.File
+

idea/testData/quickfix/migration/deleteRedundantExtension/valInsteadOfVar.kt

@@ -0,0 +1,4 @@
+// "Delete redundant extension property" "true"
+
+val Thread.<caret>priority: Int
+    get() = getPriority()

idea/testData/quickfix/migration/deleteRedundantExtension/valInsteadOfVar.kt.after

@@ -0,0 +1,2 @@
+// "Delete redundant extension property" "true"
+

idea/testData/quickfix/migration/deleteRedundantExtension/varInsteadOfVal.kt

@@ -0,0 +1,6 @@
+// "Delete redundant extension property" "false"
+import java.io.File
+
+var File.<caret>name: String
+    get() = getName()
+    set(value) {}

idea/testData/quickfix/migration/deleteRedundantExtension/withSetter.kt

@@ -0,0 +1,7 @@
+// "Delete redundant extension property" "true"
+
+var Thread.<caret>priority: Int
+    get() = getPriority()
+    set(value) {
+        setPriority(value)
+    }

idea/testData/quickfix/migration/deleteRedundantExtension/withSetter.kt.after

@@ -0,0 +1,2 @@
+// "Delete redundant extension property" "true"
+

idea/testData/quickfix/migration/deleteRedundantExtension/wrongExplicitThis.kt

@@ -0,0 +1,7 @@
+// "Delete redundant extension property" "false"
+// ACTION: Convert property to function
+
+class C : Thread() {
+    val Thread.<caret>priority: Int
+        get() = this@C.getPriority()
+}

idea/testData/quickfix/migration/deleteRedundantExtension/wrongExplicitThis2.kt

@@ -0,0 +1,9 @@
+// "Delete redundant extension property" "false"
+
+class C : Thread() {
+    var Thread.<caret>priority: Int
+        get() = getPriority()
+        set(value) {
+            this@C.setPriority(value)
+        }
+}

idea/testData/quickfix/migration/deleteRedundantExtension/wrongGetter.kt

@@ -0,0 +1,7 @@
+// "Delete redundant extension property" "false"
+
+var Thread.<caret>priority: Int
+  get() = getPriority() + 1
+  set(value) {
+      setPriority(value)
+  }

idea/testData/quickfix/migration/deleteRedundantExtension/wrongGetter2.kt

@@ -0,0 +1,6 @@
+// "Delete redundant extension property" "false"
+// ACTION: Convert property to function
+import java.io.File
+
+public val File.<caret>parent: File?
+    get() = getParentFile()

idea/testData/quickfix/migration/deleteRedundantExtension/wrongSetter.kt

@@ -0,0 +1,8 @@
+// "Delete redundant extension property" "false"
+
+var Thread.<caret>priority: Int
+    get() = this.getPriority()
+    set(value) {
+        this.setPriority(value)
+        System.out.print("set")
+    }