Fix for KT-5410 J2K: someObject + "someString" should be converted to someObject.toString() + "someString"

Otherwise `+` operator will not resolve
This commit is contained in:
Simon Ogorodnik
2016-10-14 17:35:01 +03:00
parent 0cebcc9f3c
commit 1069257e95
5 changed files with 87 additions and 0 deletions
@@ -18,6 +18,7 @@ package org.jetbrains.kotlin.idea.j2k
import com.intellij.psi.search.LocalSearchScope
import com.intellij.psi.search.searches.ReferencesSearch
import org.jetbrains.kotlin.builtins.KotlinBuiltIns
import org.jetbrains.kotlin.diagnostics.Diagnostic
import org.jetbrains.kotlin.diagnostics.DiagnosticFactory
import org.jetbrains.kotlin.diagnostics.Errors
@@ -36,6 +37,7 @@ import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.psi.*
import org.jetbrains.kotlin.psi.psiUtil.visibilityModifierType
import org.jetbrains.kotlin.resolve.BindingContext
import org.jetbrains.kotlin.resolve.calls.callUtil.getType
import org.jetbrains.kotlin.resolve.diagnostics.Diagnostics
import org.jetbrains.kotlin.utils.mapToIndex
import java.util.*
@@ -60,6 +62,7 @@ object J2KPostProcessingRegistrar {
_processings.add(RemoveExplicitTypeArgumentsProcessing())
_processings.add(RemoveRedundantOverrideVisibilityProcessing())
_processings.add(MoveLambdaOutsideParenthesesProcessing())
_processings.add(FixObjectStringConcatenationProcessing())
_processings.add(ConvertToStringTemplateProcessing())
_processings.add(UsePropertyAccessSyntaxProcessing())
_processings.add(RemoveRedundantSamAdaptersProcessing())
@@ -243,4 +246,31 @@ object J2KPostProcessingRegistrar {
return null
}
}
private class FixObjectStringConcatenationProcessing : J2kPostProcessing {
override fun createAction(element: KtElement, diagnostics: Diagnostics): (() -> Unit)? {
if (element !is KtBinaryExpression ||
element.operationToken != KtTokens.PLUS ||
diagnostics.forElement(element.operationReference).none {
it.factory == Errors.UNRESOLVED_REFERENCE_WRONG_RECEIVER
|| it.factory == Errors.NONE_APPLICABLE
})
return null
val bindingContext = element.analyzeAndGetResult().bindingContext
val rightType = element.right?.getType(bindingContext) ?: return null
if (KotlinBuiltIns.isString(rightType)) {
return {
val factory = KtPsiFactory(element)
element.left!!.replace(factory.buildExpression {
appendFixedText("(")
appendExpression(element.left)
appendFixedText(").toString()")
})
}
}
return null
}
}
}