[AA FIR] KT-58503 Use resolvedStatus to access visibility and modality of a class
Compiler plugins (AllOpen, for example) can modify the status of a declaration, including visibility and modality. If we observe them without enforcing STATUS resolve, we risk to see incorrect information, which in turn can lead to false negatives/positives in inspections/intentions. Add test for light classes. See KT-58503 description for the explanation how the initial problem was influencing Spring inspections from intellij repository. ^KT-58503 Fixed
This commit is contained in:
+12
@@ -0,0 +1,12 @@
|
||||
@org.jetbrains.kotlin.fir.plugin.AllOpen()
|
||||
public class BaseClass /* test.BaseClass*/ {
|
||||
private int prop = 42 /* initializer type: int */;
|
||||
|
||||
public BaseClass();// .ctor()
|
||||
|
||||
public int getProp();// getProp()
|
||||
|
||||
public void function();// function()
|
||||
|
||||
public void setProp(int);// setProp(int)
|
||||
}
|
||||
Vendored
+12
@@ -0,0 +1,12 @@
|
||||
@org.jetbrains.kotlin.fir.plugin.AllOpen()
|
||||
public final class BaseClass /* test.BaseClass*/ {
|
||||
private int prop;
|
||||
|
||||
public BaseClass();// .ctor()
|
||||
|
||||
public final int getProp();// getProp()
|
||||
|
||||
public final void function();// function()
|
||||
|
||||
public final void setProp(int);// setProp(int)
|
||||
}
|
||||
Vendored
+22
@@ -0,0 +1,22 @@
|
||||
// test.BaseClass
|
||||
// WITH_FIR_TEST_COMPILER_PLUGIN
|
||||
// IGNORE_LIBRARY_EXCEPTIONS: KT-58535
|
||||
// FILE: main.kt
|
||||
package test
|
||||
|
||||
import org.jetbrains.kotlin.fir.plugin.AllOpen
|
||||
|
||||
@AllOpen
|
||||
class BaseClass {
|
||||
fun function() {}
|
||||
|
||||
var prop: Int = 42
|
||||
}
|
||||
|
||||
// FILE: AllOpen.kt
|
||||
package org.jetbrains.kotlin.fir.plugin
|
||||
|
||||
/**
|
||||
* Imitates AllOpen annotation to trigger AllOpenMatcherBasedStatusTransformer
|
||||
*/
|
||||
annotation class AllOpen
|
||||
+18
@@ -578,4 +578,22 @@ public class CompilerLightClassTestGenerated extends AbstractCompilerLightClassT
|
||||
runTest("compiler/testData/asJava/lightClasses/lightClassByFqName/script/InnerClasses.kts");
|
||||
}
|
||||
}
|
||||
|
||||
@TestMetadata("compiler/testData/asJava/lightClasses/lightClassByFqName/withTestCompilerPluginEnabled")
|
||||
@TestDataPath("$PROJECT_ROOT")
|
||||
@RunWith(JUnit3RunnerWithInners.class)
|
||||
public static class WithTestCompilerPluginEnabled extends AbstractCompilerLightClassTest {
|
||||
private void runTest(String testDataFilePath) throws Exception {
|
||||
KotlinTestUtils.runTest(this::doTest, this, testDataFilePath);
|
||||
}
|
||||
|
||||
public void testAllFilesPresentInWithTestCompilerPluginEnabled() throws Exception {
|
||||
KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("compiler/testData/asJava/lightClasses/lightClassByFqName/withTestCompilerPluginEnabled"), Pattern.compile("^([^.]+)\\.(kt|kts)$"), null, true);
|
||||
}
|
||||
|
||||
@TestMetadata("allOpen.kt")
|
||||
public void testAllOpen() throws Exception {
|
||||
runTest("compiler/testData/asJava/lightClasses/lightClassByFqName/withTestCompilerPluginEnabled/allOpen.kt");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user