Make intermediate *Impl properties traits, not classes

Otherwise multiple inheritance of classes would be needed to make
implementations inherit correctly for mutable properties
This commit is contained in:
Alexander Udalov
2014-06-24 19:45:50 +04:00
parent ef7fbe55cf
commit 0fa6b40731
6 changed files with 23 additions and 29 deletions
@@ -16,6 +16,4 @@
package kotlin.reflect.jvm.internal package kotlin.reflect.jvm.internal
abstract class KCallableImpl<out R>( trait KCallableImpl<out R> : KCallable<R>
public override val name: String
) : KCallable<R>
@@ -19,12 +19,12 @@ package kotlin.reflect.jvm.internal
import java.lang.reflect.Method import java.lang.reflect.Method
open class KExtensionPropertyImpl<T, out R>( open class KExtensionPropertyImpl<T, out R>(
name: String, public override val name: String,
protected val owner: KPackageImpl, protected val owner: KPackageImpl,
protected val receiverClass: Class<T> protected val receiverClass: Class<T>
) : KExtensionProperty<T, R>, KPropertyImpl<R>(name) { ) : KExtensionProperty<T, R>, KPropertyImpl<R> {
// TODO: extract, make lazy (weak?), use our descriptors knowledge, support Java fields // TODO: extract, make lazy (weak?), use our descriptors knowledge, support Java fields
protected val getter: Method = owner.jClass.getMethod(getterName(name), receiverClass) val getter: Method = owner.jClass.getMethod(getterName(name), receiverClass)
override fun get(receiver: T): R { override fun get(receiver: T): R {
return getter(null, receiver) as R return getter(null, receiver) as R
@@ -35,8 +35,8 @@ class KMutableExtensionPropertyImpl<T, R>(
name: String, name: String,
owner: KPackageImpl, owner: KPackageImpl,
receiverClass: Class<T> receiverClass: Class<T>
) : KMutableExtensionProperty<T, R>, KExtensionPropertyImpl<T, R>(name, owner, receiverClass) { ) : KMutableExtensionProperty<T, R>, KMutablePropertyImpl<R>, KExtensionPropertyImpl<T, R>(name, owner, receiverClass) {
private val setter = owner.jClass.getMethod(setterName(name), receiverClass, getter.getReturnType()!!) val setter = owner.jClass.getMethod(setterName(name), receiverClass, getter.getReturnType()!!)
override fun set(receiver: T, value: R) { override fun set(receiver: T, value: R) {
setter.invoke(null, receiver, value) setter.invoke(null, receiver, value)
@@ -20,9 +20,9 @@ import java.lang.reflect.Field
import java.lang.reflect.Method import java.lang.reflect.Method
open class KMemberPropertyImpl<T, out R>( open class KMemberPropertyImpl<T, out R>(
name: String, public override val name: String,
protected val owner: KClassImpl<T> protected val owner: KClassImpl<T>
) : KMemberProperty<T, R>, KPropertyImpl<R>(name) { ) : KMemberProperty<T, R>, KPropertyImpl<R> {
val field: Field? = val field: Field? =
if (owner.origin == KClassOrigin.FOREIGN) { if (owner.origin == KClassOrigin.FOREIGN) {
owner.jClass.getField(name) owner.jClass.getField(name)
@@ -48,7 +48,7 @@ open class KMemberPropertyImpl<T, out R>(
class KMutableMemberPropertyImpl<T, R>( class KMutableMemberPropertyImpl<T, R>(
name: String, name: String,
owner: KClassImpl<T> owner: KClassImpl<T>
) : KMutableMemberProperty<T, R>, KMemberPropertyImpl<T, R>(name, owner) { ) : KMutableMemberProperty<T, R>, KMutablePropertyImpl<R>, KMemberPropertyImpl<T, R>(name, owner) {
val setter: Method? = val setter: Method? =
if (owner.origin == KClassOrigin.KOTLIN) { if (owner.origin == KClassOrigin.KOTLIN) {
owner.jClass.getMaybeDeclaredMethod(setterName(name), getter!!.getReturnType()!!) owner.jClass.getMaybeDeclaredMethod(setterName(name), getter!!.getReturnType()!!)
@@ -16,11 +16,12 @@
package kotlin.reflect.jvm.internal package kotlin.reflect.jvm.internal
abstract class KPropertyImpl<out R>( import java.lang.reflect.*
name: String
) : KProperty<R>, KCallableImpl<R>(name) trait KPropertyImpl<out R> : KProperty<R>, KCallableImpl<R> {
}
abstract class KMutablePropertyImpl<R>( trait KMutablePropertyImpl<R> : KMutableProperty<R>, KPropertyImpl<R> {
name: String }
) : KMutableProperty<R>, KPropertyImpl<R>(name)
@@ -19,11 +19,11 @@ package kotlin.reflect.jvm.internal
import java.lang.reflect.Method import java.lang.reflect.Method
open class KTopLevelPropertyImpl<out R>( open class KTopLevelPropertyImpl<out R>(
name: String, public override val name: String,
protected val owner: KPackageImpl protected val owner: KPackageImpl
) : KTopLevelProperty<R>, KVariableImpl<R>(name) { ) : KTopLevelProperty<R>, KVariableImpl<R> {
// TODO: extract, make lazy (weak?), use our descriptors knowledge, support Java fields // TODO: extract, make lazy (weak?), use our descriptors knowledge, support Java fields
protected val getter: Method = owner.jClass.getMethod(getterName(name)) val getter: Method = owner.jClass.getMethod(getterName(name))
override fun get(): R { override fun get(): R {
return getter(null) as R return getter(null) as R
@@ -33,8 +33,8 @@ open class KTopLevelPropertyImpl<out R>(
class KMutableTopLevelPropertyImpl<R>( class KMutableTopLevelPropertyImpl<R>(
name: String, name: String,
owner: KPackageImpl owner: KPackageImpl
) : KMutableTopLevelProperty<R>, KTopLevelPropertyImpl<R>(name, owner) { ) : KMutableTopLevelProperty<R>, KMutableVariableImpl<R>, KTopLevelPropertyImpl<R>(name, owner) {
private val setter = owner.jClass.getMethod(setterName(name), getter.getReturnType()!!) val setter = owner.jClass.getMethod(setterName(name), getter.getReturnType()!!)
override fun set(value: R) { override fun set(value: R) {
setter.invoke(null, value) setter.invoke(null, value)
@@ -16,11 +16,6 @@
package kotlin.reflect.jvm.internal package kotlin.reflect.jvm.internal
abstract class KVariableImpl<out R>( trait KVariableImpl<out R> : KVariable<R>, KPropertyImpl<R>
name: String
) : KVariable<R>, KPropertyImpl<R>(name)
trait KMutableVariableImpl<R> : KMutableVariable<R>, KVariableImpl<R>, KMutablePropertyImpl<R>
abstract class KMutableVariableImpl<R>(
name: String
) : KMutableVariable<R>, KVariableImpl<R>(name)