[FIR] Add diagnostic for primary constructor not called

compiler/fir/analysis-tests/testData/resolve/diagnostics/annotationClassMember.kt

@@ -1,5 +1,5 @@
 annotation class A() {
-    <!ANNOTATION_CLASS_MEMBER!>constructor(s: Nothing?) {}<!>
+    <!ANNOTATION_CLASS_MEMBER!><!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(s: Nothing?)<!> {}<!>
     <!ANNOTATION_CLASS_MEMBER!>init {}<!>
     <!ANNOTATION_CLASS_MEMBER!>fun foo() {}<!>
     <!ANNOTATION_CLASS_MEMBER!>val bar: Nothing?<!>

compiler/fir/analysis-tests/testData/resolve/diagnostics/cyclicConstructorDelegationCall.kt

@@ -42,16 +42,16 @@ class J<T> {
 }
 
 class F(s: String) {
-    constructor(i: Boolean) {}
+    <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(i: Boolean)<!> {}
     constructor(i: Int) : <!CYCLIC_CONSTRUCTOR_DELEGATION_CALL!>this<!>(3) {}
 }
 
 class G(x: Int) {
-    constructor() {}
+    <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor()<!> {}
 }
 
 class H(x: Int) {
-    constructor()
+    <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor()<!>
 }
 
 class K(x: Int) {

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirCyclicConstructorDelegationCallChecker.kt

@@ -13,6 +13,8 @@ import org.jetbrains.kotlin.fir.declarations.FirConstructor
 import org.jetbrains.kotlin.fir.declarations.FirMemberDeclaration
 import org.jetbrains.kotlin.fir.declarations.FirRegularClass
 import org.jetbrains.kotlin.fir.references.FirResolvedNamedReference
+import org.jetbrains.kotlin.fir.types.FirResolvedTypeRef
+import org.jetbrains.kotlin.fir.types.FirTypeRef
 import org.jetbrains.kotlin.utils.addToStdlib.safeAs
 
 object FirCyclicConstructorDelegationCallChecker : FirMemberDeclarationChecker() {
@@ -22,11 +24,27 @@ object FirCyclicConstructorDelegationCallChecker : FirMemberDeclarationChecker()
         }
 
         val cyclicConstructors = mutableSetOf<FirConstructor>()
+        var hasPrimaryConstructor = false
 
         for (it in declaration.declarations) {
-            if (it is FirConstructor && !it.isPrimary) {
+            if (it is FirConstructor) {
-                it.findCycle(cyclicConstructors)?.let { visited ->
+                if (!it.isPrimary) {
-                    cyclicConstructors += visited
+                    it.findCycle(cyclicConstructors)?.let { visited ->
+                        cyclicConstructors += visited
+                    }
+                } else {
+                    hasPrimaryConstructor = true
+                }
+            }
+        }
+
+        if (hasPrimaryConstructor) {
+            for (it in declaration.declarations) {
+                if (
+                    it is FirConstructor && !it.isPrimary && it !in cyclicConstructors &&
+                    it.delegatedConstructor?.constructedTypeRef?.getType() != it.returnTypeRef.getType()
+                ) {
+                    reporter.reportPrimaryConstructorDelegationCallExpected(it.delegatedConstructor?.source)
                 }
             }
         }
@@ -60,7 +78,16 @@ object FirCyclicConstructorDelegationCallChecker : FirMemberDeclarationChecker()
         ?.resolvedSymbol
         ?.fir.safeAs()
 
+    private fun FirTypeRef.getType() = when (this) {
+        is FirResolvedTypeRef -> type
+        else -> null
+    }
+
     private fun DiagnosticReporter.reportCyclicConstructorDelegationCall(source: FirSourceElement?) {
         source?.let { report(FirErrors.CYCLIC_CONSTRUCTOR_DELEGATION_CALL.on(it)) }
     }
+
+    private fun DiagnosticReporter.reportPrimaryConstructorDelegationCallExpected(source: FirSourceElement?) {
+        source?.let { report(FirErrors.PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED.on(it)) }
+    }
 }

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/diagnostics/FirErrors.kt

@@ -65,6 +65,7 @@ object FirErrors {
     val NOT_AN_ANNOTATION_CLASS by error1<FirSourceElement, PsiElement, String>()
 
     val CYCLIC_CONSTRUCTOR_DELEGATION_CALL by warning0<FirSourceElement, PsiElement>()
+    val PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED by warning0<FirSourceElement, PsiElement>()
 
     // Exposed visibility group
     val EXPOSED_TYPEALIAS_EXPANDED_TYPE by error3<FirSourceElement, PsiElement, FirEffectiveVisibility, FirMemberDeclaration, FirEffectiveVisibility>()

compiler/testData/diagnostics/tests/declarationChecks/mulitpleVarargParameters.fir.kt

@@ -2,7 +2,7 @@
 fun test(vararg x1: Int, vararg x2: Int) {
     fun test2(vararg x1: Int, vararg x2: Int) {
         class LocalClass(vararg x1: Int, vararg x2: Int) {
-        constructor(vararg x1: Int, vararg x2: Int, xx: Int) {}
+        <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(vararg x1: Int, vararg x2: Int, xx: Int)<!> {}
     }
         fun test3(vararg x1: Int, vararg x2: Int) {}
     }
@@ -20,7 +20,7 @@ abstract class C(vararg x1: Int, vararg x2: Int, b: Boolean) {
     abstract fun test2(vararg x1: Int, vararg x2: Int)
 
     class CC(vararg x1: Int, vararg x2: Int, b: Boolean) {
-        constructor(vararg x1: Int, vararg x2: Int) {}
+        <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(vararg x1: Int, vararg x2: Int)<!> {}
         fun test(vararg x1: Int, vararg x2: Int) {}
     }
 }
@@ -29,7 +29,7 @@ object O {
     fun test(vararg x1: Int, vararg x2: Int) {}
 
     class CC(vararg x1: Int, vararg x2: Int, b: Boolean) {
-        constructor(vararg x1: Int, vararg x2: Int) {}
+        <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(vararg x1: Int, vararg x2: Int)<!> {}
         fun test(vararg x1: Int, vararg x2: Int) {}
     }
 }

compiler/testData/diagnostics/tests/multiplatform/enum/constructorInHeaderEnum.fir.kt

@@ -7,7 +7,7 @@ expect enum class En(x: Int) {
     E2(42),
     ;
 
-    constructor(s: String)
+    <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(s: String)<!>
 }
 
 expect enum class En2 {

compiler/testData/diagnostics/tests/multiplatform/headerClass/headerClassWithFunctionBody.fir.kt

@@ -9,7 +9,7 @@ expect class Foo(
         "no"
     }
 
-    constructor(s: String) {
+    <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(s: String)<!> {
         "no"
     }
 

compiler/testData/diagnostics/tests/multiplatform/namedArguments.fir.kt

@@ -4,7 +4,7 @@
 // FILE: common.kt
 
 expect class Foo(zzz: Int) {
-    constructor(aaa: Boolean)
+    <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(aaa: Boolean)<!>
 
     fun f1(xxx: String): String
 }

compiler/testData/diagnostics/tests/secondaryConstructors/enums.fir.kt

@@ -14,7 +14,7 @@ enum class B(x: Int) {
 
     constructor(x: Int, y: Int): this(x+y)
     constructor(x: Double): this(x.toInt(), 1)
-    constructor(x: String): super(x, 1)
+    constructor(x: String): <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>super<!>(x, 1)
 }
 
 enum class C {

compiler/testData/diagnostics/tests/secondaryConstructors/expectedPrimaryConstructorCall.fir.kt

@@ -1,8 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_PARAMETER
-class A(x: Int) {
-    constructor()
-}
-open class B(x: Int)
-class C(x: Int) : B(x) {
-    constructor(): super(1)
-}

compiler/testData/diagnostics/tests/secondaryConstructors/expectedPrimaryConstructorCall.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_PARAMETER
 class A(x: Int) {
     <!PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor()<!>

compiler/testData/diagnostics/tests/secondaryConstructors/implicitSuperCallErrorsIfPrimary.fir.kt

@@ -2,6 +2,6 @@
 open class A(p1: String)
 
 class B() : A("") {
-    <!INAPPLICABLE_CANDIDATE!>constructor(s: String)<!> {
+    <!INAPPLICABLE_CANDIDATE, PRIMARY_CONSTRUCTOR_DELEGATION_CALL_EXPECTED!>constructor(s: String)<!> {
     }
 }