[CHERRY PICKED FROM IJ] KotlinBuilder: cleanup code
GitOrigin-RevId: 156806aed03531438fcafdd8fba325a7101f01d9 Original commit: https://github.com/JetBrains/intellij-community/commit/021d5bc301c91e386ea363389f5d95c25d361531
This commit is contained in:
committed by
Nikita Bobko
parent
1f62859019
commit
0ee7187e3e
@@ -230,7 +230,7 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
ExpectActualTracker.DoNothing,
|
ExpectActualTracker.DoNothing,
|
||||||
chunk,
|
chunk,
|
||||||
messageCollector
|
messageCollector
|
||||||
) ?: return
|
)
|
||||||
|
|
||||||
val removedClasses = HashSet<String>()
|
val removedClasses = HashSet<String>()
|
||||||
for (target in kotlinChunk.targets) {
|
for (target in kotlinChunk.targets) {
|
||||||
@@ -278,12 +278,12 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
context: CompileContext,
|
context: CompileContext,
|
||||||
chunk: ModuleChunk,
|
chunk: ModuleChunk,
|
||||||
dirtyFilesHolder: DirtyFilesHolder<JavaSourceRootDescriptor, ModuleBuildTarget>,
|
dirtyFilesHolder: DirtyFilesHolder<JavaSourceRootDescriptor, ModuleBuildTarget>,
|
||||||
outputConsumer: ModuleLevelBuilder.OutputConsumer
|
outputConsumer: OutputConsumer
|
||||||
): ModuleLevelBuilder.ExitCode {
|
): ExitCode {
|
||||||
if (chunk.isDummy(context))
|
if (chunk.isDummy(context))
|
||||||
return NOTHING_DONE
|
return NOTHING_DONE
|
||||||
|
|
||||||
val kotlinTarget = context.kotlinBuildTargets[chunk.representativeTarget()] ?: return OK
|
val kotlinTarget = context.kotlin.targetsBinding[chunk.representativeTarget()] ?: return OK
|
||||||
val messageCollector = MessageCollectorAdapter(context, kotlinTarget)
|
val messageCollector = MessageCollectorAdapter(context, kotlinTarget)
|
||||||
|
|
||||||
// New mpp project model: modules which is imported from sources sets of the compilations shouldn't be compiled for now.
|
// New mpp project model: modules which is imported from sources sets of the compilations shouldn't be compiled for now.
|
||||||
@@ -291,7 +291,7 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
if (chunk.modules.any { it.kotlinKind == KotlinModuleKind.SOURCE_SET_HOLDER }) {
|
if (chunk.modules.any { it.kotlinKind == KotlinModuleKind.SOURCE_SET_HOLDER }) {
|
||||||
if (chunk.modules.size > 1) {
|
if (chunk.modules.size > 1) {
|
||||||
messageCollector.report(
|
messageCollector.report(
|
||||||
CompilerMessageSeverity.ERROR,
|
ERROR,
|
||||||
"Cyclically dependent modules are not supported in multiplatform projects"
|
"Cyclically dependent modules are not supported in multiplatform projects"
|
||||||
)
|
)
|
||||||
return ABORT
|
return ABORT
|
||||||
@@ -335,7 +335,7 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
messageCollector: MessageCollectorAdapter,
|
messageCollector: MessageCollectorAdapter,
|
||||||
outputConsumer: OutputConsumer,
|
outputConsumer: OutputConsumer,
|
||||||
fsOperations: FSOperationsHelper
|
fsOperations: FSOperationsHelper
|
||||||
): ModuleLevelBuilder.ExitCode {
|
): ExitCode {
|
||||||
// Workaround for Android Studio
|
// Workaround for Android Studio
|
||||||
if (representativeTarget is KotlinJvmModuleBuildTarget && !JavaBuilder.IS_ENABLED[context, true]) {
|
if (representativeTarget is KotlinJvmModuleBuildTarget && !JavaBuilder.IS_ENABLED[context, true]) {
|
||||||
messageCollector.report(INFO, "Kotlin JPS plugin is disabled")
|
messageCollector.report(INFO, "Kotlin JPS plugin is disabled")
|
||||||
@@ -358,7 +358,6 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
val projectDescriptor = context.projectDescriptor
|
val projectDescriptor = context.projectDescriptor
|
||||||
val dataManager = projectDescriptor.dataManager
|
|
||||||
val targets = chunk.targets
|
val targets = chunk.targets
|
||||||
|
|
||||||
val isChunkRebuilding = JavaBuilderUtil.isForcedRecompilationAllJavaModules(context)
|
val isChunkRebuilding = JavaBuilderUtil.isForcedRecompilationAllJavaModules(context)
|
||||||
@@ -403,7 +402,7 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
exceptActualTracer,
|
exceptActualTracer,
|
||||||
chunk,
|
chunk,
|
||||||
messageCollector
|
messageCollector
|
||||||
) ?: return ABORT
|
)
|
||||||
|
|
||||||
context.testingContext?.buildLogger?.compilingFiles(
|
context.testingContext?.buildLogger?.compilingFiles(
|
||||||
kotlinDirtyFilesHolder.allDirtyFiles,
|
kotlinDirtyFilesHolder.allDirtyFiles,
|
||||||
@@ -591,7 +590,7 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
exceptActualTracer: ExpectActualTracker,
|
exceptActualTracer: ExpectActualTracker,
|
||||||
chunk: ModuleChunk,
|
chunk: ModuleChunk,
|
||||||
messageCollector: MessageCollectorAdapter
|
messageCollector: MessageCollectorAdapter
|
||||||
): JpsCompilerEnvironment? {
|
): JpsCompilerEnvironment {
|
||||||
val compilerServices = with(Services.Builder()) {
|
val compilerServices = with(Services.Builder()) {
|
||||||
kotlinModuleBuilderTarget.makeServices(this, incrementalCaches, lookupTracker, exceptActualTracer)
|
kotlinModuleBuilderTarget.makeServices(this, incrementalCaches, lookupTracker, exceptActualTracer)
|
||||||
build()
|
build()
|
||||||
@@ -646,7 +645,7 @@ class KotlinBuilder : ModuleLevelBuilder(BuilderCategory.SOURCE_PROCESSOR) {
|
|||||||
val sourceToTarget = HashMap<File, ModuleBuildTarget>()
|
val sourceToTarget = HashMap<File, ModuleBuildTarget>()
|
||||||
if (chunk.targets.size > 1) {
|
if (chunk.targets.size > 1) {
|
||||||
for (target in chunk.targets) {
|
for (target in chunk.targets) {
|
||||||
context.kotlinBuildTargets[target]?.sourceFiles?.forEach {
|
context.kotlin.targetsBinding[target]?.sourceFiles?.forEach {
|
||||||
sourceToTarget[it] = target
|
sourceToTarget[it] = target
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user