Completion of non-imported extensions in debugger for runtime receiver type

idea/idea-completion/src/org/jetbrains/kotlin/idea/completion/BasicCompletionSession.kt

@@ -240,9 +240,15 @@ class BasicCompletionSession(configuration: CompletionSessionConfiguration,
             if (completionKind != CompletionKind.KEYWORDS_ONLY) {
                 completeNonImported()
 
+                flushToResultSet()
+
                 if (position.getContainingFile() is KtCodeFragment) {
-                    flushToResultSet()
+                    val variants = getRuntimeReceiverTypeReferenceVariants()
-                    collector.addDescriptorElements(getRuntimeReceiverTypeReferenceVariants(), withReceiverCast = true)
+                    if (variants != null) {
+                        collector.addDescriptorElements(variants.imported, withReceiverCast = true)
+                        collector.addDescriptorElements(variants.notImportedExtensions, withReceiverCast = true, notImported = true)
+                        flushToResultSet()
+                    }
                 }
             }
         }

idea/idea-completion/src/org/jetbrains/kotlin/idea/completion/CompletionSession.kt

@@ -324,18 +324,19 @@ abstract class CompletionSession(protected val configuration: CompletionSessionC
         return this
     }
 
-    protected fun getRuntimeReceiverTypeReferenceVariants(): Collection<DeclarationDescriptor> {
+    protected fun getRuntimeReceiverTypeReferenceVariants(): ReferenceVariants? {
-        val explicitReceiver = callTypeAndReceiver.receiver as? KtExpression ?: return emptyList()
+        val explicitReceiver = callTypeAndReceiver.receiver as? KtExpression ?: return null
-        val type = bindingContext.getType(explicitReceiver) ?: return emptyList()
+        val type = bindingContext.getType(explicitReceiver) ?: return null
-        if (!TypeUtils.canHaveSubtypes(KotlinTypeChecker.DEFAULT, type)) return emptyList()
+        if (!TypeUtils.canHaveSubtypes(KotlinTypeChecker.DEFAULT, type)) return null
-        val evaluator = file.getCopyableUserData(KtCodeFragment.RUNTIME_TYPE_EVALUATOR) ?: return emptyList()
+        val evaluator = file.getCopyableUserData(KtCodeFragment.RUNTIME_TYPE_EVALUATOR) ?: return null
         val runtimeType = evaluator(explicitReceiver)
-        if (runtimeType == null || runtimeType == type) return emptyList()
+        if (runtimeType == null || runtimeType == type) return null
 
-        val (variants, notImportedExtensions/*TODO: use them*/) = collectReferenceVariants(descriptorKindFilter!!, runtimeType)
+        val (variants, notImportedExtensions) = collectReferenceVariants(descriptorKindFilter!!, runtimeType)
-        return variants.filter { descriptor ->
+        val normalVariants = referenceVariants!!.imported + referenceVariants!!.notImportedExtensions
-            referenceVariants!!.imported.none { compareDescriptors(project, it, descriptor) }
+        val filteredVariants = variants.filter { descriptor -> normalVariants.none { compareDescriptors(project, it, descriptor) } }
-        }
+        val filteredNotImportedExtensions = notImportedExtensions.filter { descriptor -> normalVariants.none { compareDescriptors(project, it, descriptor) } }
+        return ReferenceVariants(filteredVariants, filteredNotImportedExtensions)
     }
 
     protected fun shouldCompleteTopLevelCallablesFromIndex(): Boolean {

idea/idea-completion/src/org/jetbrains/kotlin/idea/completion/smart/SmartCompletionSession.kt

@@ -85,10 +85,12 @@ class SmartCompletionSession(configuration: CompletionSessionConfiguration, para
                     }
 
                     if (position.getContainingFile() is KtCodeFragment) {
-                        getRuntimeReceiverTypeReferenceVariants().forEach {
+                        val variants = getRuntimeReceiverTypeReferenceVariants()
-                            collector.addElements(filter(it).map { it.withReceiverCast() })
+                        if (variants != null) {
+                            variants.imported.forEach { collector.addElements(filter(it).map { it.withReceiverCast() }) }
+                            variants.notImportedExtensions.forEach { collector.addElements(filter(it).map { it.withReceiverCast() }, notImported = true) }
+                            flushToResultSet()
                         }
-                        flushToResultSet()
                     }
                 }
 

idea/idea-completion/testData/basic/codeFragments/runtimeType/notImportedExtension.kt

@@ -0,0 +1,8 @@
+fun foo(o: Any) {
+    <caret>val a = 1
+}
+
+// INVOCATION_COUNT: 1
+// EXIST: read, write
+
+// RUNTIME_TYPE: java.util.concurrent.locks.ReentrantReadWriteLock

idea/idea-completion/testData/basic/codeFragments/runtimeType/notImportedExtension.kt.fragment

@@ -0,0 +1 @@
+o.<caret>

idea/idea-completion/testData/handlers/runtimeCast/NotImportedExtension.kt

@@ -0,0 +1,8 @@
+fun foo(o: Any) {
+    <caret>val a = 1
+}
+
+// INVOCATION_COUNT: 1
+// ELEMENT: read
+
+// RUNTIME_TYPE: java.util.concurrent.locks.ReentrantReadWriteLock

idea/idea-completion/testData/handlers/runtimeCast/NotImportedExtension.kt.after

@@ -0,0 +1 @@
+(o as ReentrantReadWriteLock).read { <caret> }

idea/idea-completion/testData/handlers/runtimeCast/NotImportedExtension.kt.after.imports

@@ -0,0 +1,2 @@
+import kotlin.concurrent.read
+import java.util.concurrent.locks.ReentrantReadWriteLock

idea/idea-completion/testData/handlers/runtimeCast/NotImportedExtension.kt.fragment

@@ -0,0 +1 @@
+o.<caret>

idea/tests/org/jetbrains/kotlin/idea/debugger/evaluate/CodeFragmentCompletionHandlerTestGenerated.java

@@ -64,4 +64,10 @@ public class CodeFragmentCompletionHandlerTestGenerated extends AbstractCodeFrag
         String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/handlers/runtimeCast/InsertImport.kt");
         doTest(fileName);
     }
+
+    @TestMetadata("NotImportedExtension.kt")
+    public void testNotImportedExtension() throws Exception {
+        String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/handlers/runtimeCast/NotImportedExtension.kt");
+        doTest(fileName);
+    }
 }

idea/tests/org/jetbrains/kotlin/idea/debugger/evaluate/CodeFragmentCompletionTestGenerated.java

@@ -115,6 +115,12 @@ public class CodeFragmentCompletionTestGenerated extends AbstractCodeFragmentCom
             doTest(fileName);
         }
 
+        @TestMetadata("notImportedExtension.kt")
+        public void testNotImportedExtension() throws Exception {
+            String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/codeFragments/runtimeType/notImportedExtension.kt");
+            doTest(fileName);
+        }
+
         @TestMetadata("runtimeCast.kt")
         public void testRuntimeCast() throws Exception {
             String fileName = JetTestUtils.navigationMetadata("idea/idea-completion/testData/basic/codeFragments/runtimeType/runtimeCast.kt");