Fix multiple resource leaks by closing InputStream instances

The main fix is in BuiltInsPackageFragment, the rest is the improvement of
other usages of getResourceAsStream

 #KT-11433 Fixed

core/descriptors.runtime/src/org/jetbrains/kotlin/load/kotlin/reflect/RuntimePackagePartProvider.kt

@@ -25,7 +25,7 @@ class RuntimePackagePartProvider(private val classLoader: ClassLoader) : Package
 
     fun registerModule(moduleName: String) {
         val mapping = try {
-            classLoader.getResourceAsStream("META-INF/$moduleName.${ModuleMapping.MAPPING_FILE_EXT}")?.let { stream ->
+            classLoader.getResourceAsStream("META-INF/$moduleName.${ModuleMapping.MAPPING_FILE_EXT}")?.use { stream ->
                 ModuleMapping.create(stream.readBytes())
             }
         }

core/descriptors/src/org/jetbrains/kotlin/builtins/BuiltInsPackageFragment.kt

@@ -31,8 +31,7 @@ class BuiltInsPackageFragment(
         module: ModuleDescriptor,
         loadResource: (path: String) -> InputStream?
 ) : DeserializedPackageFragment(fqName, storageManager, module, loadResource) {
-    private val proto = run {
+    private val proto = loadResourceSure(BuiltInSerializerProtocol.getBuiltInsFilePath(fqName)).use { stream ->
-        val stream = loadResourceSure(BuiltInSerializerProtocol.getBuiltInsFilePath(fqName))
         val version = BuiltInsBinaryVersion.readFrom(stream)
 
         if (!version.isCompatible()) {

core/deserialization/src/org/jetbrains/kotlin/serialization/deserialization/DeserializedPackageFragment.kt

@@ -30,7 +30,7 @@ abstract class DeserializedPackageFragment(
         fqName: FqName,
         protected val storageManager: StorageManager,
         module: ModuleDescriptor,
-        protected val loadResource: (path: String) -> InputStream?
+        private val loadResource: (path: String) -> InputStream?
 ) : PackageFragmentDescriptorImpl(module, fqName) {
     // component dependency cycle
     @set:Inject

eval4j/test/org/jetbrains/eval4j/test/suiteBuilder.kt

@@ -37,21 +37,20 @@ fun buildTestSuite(
     val suite = TestSuite()
 
     val ownerClass = TestData::class.java
-    val inputStream = ownerClass.classLoader!!.getResourceAsStream(ownerClass.getInternalName() + ".class")!!
+    ownerClass.classLoader!!.getResourceAsStream(ownerClass.getInternalName() + ".class")!!.use { inputStream ->
-
+        ClassReader(inputStream).accept(object : ClassVisitor(ASM5) {
-    ClassReader(inputStream).accept(object : ClassVisitor(ASM5) {
+            override fun visitMethod(access: Int, name: String, desc: String, signature: String?, exceptions: Array<out String>?): MethodVisitor? {
-
+                return object : MethodNode(ASM5, access, name, desc, signature, exceptions) {
-        override fun visitMethod(access: Int, name: String, desc: String, signature: String?, exceptions: Array<out String>?): MethodVisitor? {
+                    override fun visitEnd() {
-            return object : MethodNode(ASM5, access, name, desc, signature, exceptions) {
+                        val testCase = buildTestCase(ownerClass, this, create)
-                override fun visitEnd() {
+                        if (testCase != null) {
-                    val testCase = buildTestCase(ownerClass, this, create)
+                            suite.addTest(testCase)
-                    if (testCase != null) {
+                        }
-                        suite.addTest(testCase)
                     }
                 }
             }
-        }
+        }, 0)
-    }, 0)
+    }
 
     return suite
 }

idea/src/org/jetbrains/kotlin/idea/debugger/evaluate/compilingEvaluator.kt

@@ -78,11 +78,8 @@ private class ClassBytes(val name: String) {
         val inputStream = this.javaClass.classLoader.getResourceAsStream(name.replace('.', '/') + ".class")
                           ?: throw EvaluateException("Couldn't find $name class in current class loader")
 
-        try {
+        inputStream.use {
-            inputStream.readBytes()
+            it.readBytes()
-        }
-        finally {
-            inputStream.close()
         }
     }
 }

js/js.serializer/src/org/jetbrains/kotlin/serialization/js/KotlinJavascriptPackageFragment.kt

@@ -33,21 +33,24 @@ class KotlinJavascriptPackageFragment(
         loadResource: (path: String) -> InputStream?
 ) : DeserializedPackageFragment(fqName, storageManager, module, loadResource) {
     private val nameResolver =
-            NameResolverImpl.read(loadResourceSure(KotlinJavascriptSerializedResourcePaths.getStringTableFilePath(fqName)))
+            loadResourceSure(KotlinJavascriptSerializedResourcePaths.getStringTableFilePath(fqName)).use { stream ->
+                NameResolverImpl.read(stream)
+            }
 
     override val classDataFinder = KotlinJavascriptClassDataFinder(nameResolver, loadResource)
 
-    override fun computeMemberScope(): DeserializedPackageMemberScope {
+    override fun computeMemberScope(): DeserializedPackageMemberScope =
-        val packageStream = loadResourceSure(KotlinJavascriptSerializedResourcePaths.getPackageFilePath(fqName))
+            loadResourceSure(KotlinJavascriptSerializedResourcePaths.getPackageFilePath(fqName)).use { packageStream ->
-        val packageProto = ProtoBuf.Package.parseFrom(packageStream, JsSerializerProtocol.extensionRegistry)
+                val packageProto = ProtoBuf.Package.parseFrom(packageStream, JsSerializerProtocol.extensionRegistry)
-        return DeserializedPackageMemberScope(
+                DeserializedPackageMemberScope(
-                this, packageProto, nameResolver, packagePartSource = null, components = components, classNames = { loadClassNames() }
+                        this, packageProto, nameResolver, packagePartSource = null, components = components,
-        )
+                        classNames = { loadClassNames() }
-    }
+                )
+            }
 
-    private fun loadClassNames(): Collection<Name> {
+    private fun loadClassNames(): Collection<Name> =
-        val classesStream = loadResourceSure(KotlinJavascriptSerializedResourcePaths.getClassesInPackageFilePath(fqName))
+            loadResourceSure(KotlinJavascriptSerializedResourcePaths.getClassesInPackageFilePath(fqName)).use { classesStream ->
-        val classesProto = JsProtoBuf.Classes.parseFrom(classesStream, JsSerializerProtocol.extensionRegistry)
+                val classesProto = JsProtoBuf.Classes.parseFrom(classesStream, JsSerializerProtocol.extensionRegistry)
-        return classesProto.classNameList?.map { id -> nameResolver.getName(id) } ?: listOf()
+                classesProto.classNameList?.map { id -> nameResolver.getName(id) } ?: listOf()
-    }
+            }
 }