From 0dc68c270245cfcd50ef229235d9133c10d2a1f2 Mon Sep 17 00:00:00 2001 From: Ilya Ryzhenkov Date: Wed, 5 Nov 2014 17:41:29 +0300 Subject: [PATCH] Avoid using negative in descending sorts. --- libraries/stdlib/src/generated/_Ordering.kt | 6 +++--- libraries/tools/kotlin-stdlib-gen/src/templates/Ordering.kt | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libraries/stdlib/src/generated/_Ordering.kt b/libraries/stdlib/src/generated/_Ordering.kt index ba24deb9b2d..9d036833072 100644 --- a/libraries/stdlib/src/generated/_Ordering.kt +++ b/libraries/stdlib/src/generated/_Ordering.kt @@ -156,7 +156,7 @@ public inline fun > Iterable.sortBy(inlineOptions(Inline */ public fun > Iterable.sortDescending(): List { val sortedList = toArrayList() - val sortBy: Comparator = comparator {(x: T, y: T) -> -x.compareTo(y) } + val sortBy: Comparator = comparator {(x: T, y: T) -> y.compareTo(x) } java.util.Collections.sort(sortedList, sortBy) return sortedList } @@ -166,7 +166,7 @@ public fun > Iterable.sortDescending(): List { */ public inline fun > Array.sortDescendingBy(inlineOptions(InlineOption.ONLY_LOCAL_RETURN) order: (T) -> R): List { val sortedList = toArrayList() - val sortBy: Comparator = comparator {(x: T, y: T) -> -order(x).compareTo(order(y)) } + val sortBy: Comparator = comparator {(x: T, y: T) -> order(y).compareTo(order(x)) } java.util.Collections.sort(sortedList, sortBy) return sortedList } @@ -176,7 +176,7 @@ public inline fun > Array.sortDescendingBy(inlineOpt */ public inline fun > Iterable.sortDescendingBy(inlineOptions(InlineOption.ONLY_LOCAL_RETURN) order: (T) -> R): List { val sortedList = toArrayList() - val sortBy: Comparator = comparator {(x: T, y: T) -> -order(x).compareTo(order(y)) } + val sortBy: Comparator = comparator {(x: T, y: T) -> order(y).compareTo(order(x)) } java.util.Collections.sort(sortedList, sortBy) return sortedList } diff --git a/libraries/tools/kotlin-stdlib-gen/src/templates/Ordering.kt b/libraries/tools/kotlin-stdlib-gen/src/templates/Ordering.kt index 613730edb87..93a390d372d 100644 --- a/libraries/tools/kotlin-stdlib-gen/src/templates/Ordering.kt +++ b/libraries/tools/kotlin-stdlib-gen/src/templates/Ordering.kt @@ -80,7 +80,7 @@ fun ordering(): List { body { """ val sortedList = toArrayList() - val sortBy: Comparator = comparator {(x: T, y: T) -> -x.compareTo(y) } + val sortBy: Comparator = comparator {(x: T, y: T) -> y.compareTo(x) } java.util.Collections.sort(sortedList, sortBy) return sortedList """ @@ -150,7 +150,7 @@ fun ordering(): List { body { """ val sortedList = toArrayList() - val sortBy: Comparator = comparator {(x: T, y: T) -> -order(x).compareTo(order(y)) } + val sortBy: Comparator = comparator {(x: T, y: T) -> order(y).compareTo(order(x)) } java.util.Collections.sort(sortedList, sortBy) return sortedList """