Merge pull request #808 from mcgee/KT-10196

KT-10196: Suggest to replace 'substring' calls by take/drop/dropLast calls when possible

idea/testData/intentions/replaceSubstringWithDropLast/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.ReplaceSubstringWithDropLastIntention

idea/testData/intentions/replaceSubstringWithDropLast/immutableProperty.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class A(val x: String)
+
+fun foo(a: A) {
+    a.x.substring<caret>(0, a.x.length - 5)
+}

idea/testData/intentions/replaceSubstringWithDropLast/immutableProperty.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class A(val x: String)
+
+fun foo(a: A) {
+    a.x.dropLast(5)
+}

idea/testData/intentions/replaceSubstringWithDropLast/methodCallReceiver.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+class A() {
+    fun bar(): String = null!!
+}
+
+fun foo(a: A) {
+    a.bar().substring<caret>(0, a.bar().length - 5)
+}

idea/testData/intentions/replaceSubstringWithDropLast/nonZeroFirstArgument.kt

@@ -0,0 +1,6 @@
+// IS_APPLICABLE: false
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(3, s.length - 5)
+}

idea/testData/intentions/replaceSubstringWithDropLast/replaceWithDropLast.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(0, s.length - 5)
+}

idea/testData/intentions/replaceSubstringWithDropLast/replaceWithDropLast.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.dropLast(5)
+}

idea/testData/intentions/replaceSubstringWithDropLast/semicolon.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(0, s.length - 5);
+}

idea/testData/intentions/replaceSubstringWithDropLast/semicolon.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.dropLast(5);
+}

idea/testData/intentions/replaceSubstringWithSubstringAfter/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.ReplaceSubstringWithSubstringAfterIntention

idea/testData/intentions/replaceSubstringWithSubstringAfter/immutableProperty.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class A(val x: String)
+
+fun foo(a: A) {
+    a.x.substring<caret>(a.x.indexOf('x'))
+}

idea/testData/intentions/replaceSubstringWithSubstringAfter/immutableProperty.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class A(val x: String)
+
+fun foo(a: A) {
+    a.x.substringAfter('x')
+}

idea/testData/intentions/replaceSubstringWithSubstringAfter/methodCallReceiver.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+class A() {
+    fun bar(): String = null!!
+}
+
+fun foo(a: A) {
+    a.bar().substring<caret>(a.bar().indexOf('x'))
+}

idea/testData/intentions/replaceSubstringWithSubstringAfter/replaceWithSubstringAfter.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(s.indexOf('x'))
+}

idea/testData/intentions/replaceSubstringWithSubstringAfter/replaceWithSubstringAfter.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substringAfter('x')
+}

idea/testData/intentions/replaceSubstringWithSubstringAfter/semicolon.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(s.indexOf('x'));
+}

idea/testData/intentions/replaceSubstringWithSubstringAfter/semicolon.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substringAfter('x');
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.ReplaceSubstringWithSubstringBeforeIntention

idea/testData/intentions/replaceSubstringWithSubstringBefore/immutableProperty.kt

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class A(val x: String)
+
+fun foo(a: A) {
+    a.x.substring<caret>(0, a.x.indexOf('x'))
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/immutableProperty.kt.after

@@ -0,0 +1,7 @@
+// WITH_RUNTIME
+
+class A(val x: String)
+
+fun foo(a: A) {
+    a.x.substringBefore('x')
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/methodCallReceiver.kt

@@ -0,0 +1,10 @@
+// WITH_RUNTIME
+// IS_APPLICABLE: false
+
+class A() {
+    fun bar(): String = null!!
+}
+
+fun foo(a: A) {
+    a.bar().substring<caret>(0, a.bar().indexOf('x'))
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/nonZeroFirstArgument.kt

@@ -0,0 +1,6 @@
+// IS_APPLICABLE: false
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(1, s.indexOf('x'))
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/replaceWithSubstringBefore.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(0, s.indexOf('x'))
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/replaceWithSubstringBefore.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substringBefore('x')
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/semicolon.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(0, s.indexOf('x'));
+}

idea/testData/intentions/replaceSubstringWithSubstringBefore/semicolon.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substringBefore('x');
+}

idea/testData/intentions/replaceSubstringWithTake/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.ReplaceSubstringWithTakeIntention

idea/testData/intentions/replaceSubstringWithTake/constantAsFirstArgument.kt

@@ -0,0 +1,8 @@
+// IS_APPLICABLE: false
+// WITH_RUNTIME
+
+const val x = 0
+
+fun foo(s: String) {
+    s.substring<caret>(x, 10)
+}

idea/testData/intentions/replaceSubstringWithTake/expressionAsFirstArgument.kt

@@ -0,0 +1,6 @@
+// IS_APPLICABLE: false
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(1 - 1, 10)
+}

idea/testData/intentions/replaceSubstringWithTake/nonZeroFirstArgument.kt

@@ -0,0 +1,6 @@
+// IS_APPLICABLE: false
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(1, 10)
+}

idea/testData/intentions/replaceSubstringWithTake/replaceWithTake.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(0, 10)
+}

idea/testData/intentions/replaceSubstringWithTake/replaceWithTake.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.take(10)
+}

idea/testData/intentions/replaceSubstringWithTake/semicolon.kt

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.substring<caret>(0, 10);
+}

idea/testData/intentions/replaceSubstringWithTake/semicolon.kt.after

@@ -0,0 +1,5 @@
+// WITH_RUNTIME
+
+fun foo(s: String) {
+    s.take(10);
+}