Synchronize cleanupTool = true with CleanupLocalInspectionTool

So #KT-20366 Fixed
This commit is contained in:
Mikhail Glukhikh
2017-09-22 18:21:37 +03:00
parent d6028877e1
commit 0bce06dc0f
7 changed files with 15 additions and 7 deletions
+8
View File
@@ -1740,6 +1740,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Redundant constructs" groupName="Redundant constructs"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="WEAK WARNING" level="WEAK WARNING"
language="kotlin" language="kotlin"
/> />
@@ -2120,6 +2121,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Redundant constructs" groupName="Redundant constructs"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="WEAK WARNING" level="WEAK WARNING"
language="kotlin" language="kotlin"
/> />
@@ -2129,6 +2131,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Redundant constructs" groupName="Redundant constructs"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="INFO" level="INFO"
language="kotlin" language="kotlin"
/> />
@@ -2202,6 +2205,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Redundant constructs" groupName="Redundant constructs"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="WEAK WARNING" level="WEAK WARNING"
language="kotlin" language="kotlin"
/> />
@@ -2211,6 +2215,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Redundant constructs" groupName="Redundant constructs"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="WEAK WARNING" level="WEAK WARNING"
language="kotlin" language="kotlin"
/> />
@@ -2346,6 +2351,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Style issues" groupName="Style issues"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="INFO" level="INFO"
language="kotlin" language="kotlin"
/> />
@@ -2472,6 +2478,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Redundant constructs" groupName="Redundant constructs"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="WEAK WARNING" level="WEAK WARNING"
language="kotlin" language="kotlin"
/> />
@@ -2571,6 +2578,7 @@
groupPath="Kotlin" groupPath="Kotlin"
groupName="Redundant constructs" groupName="Redundant constructs"
enabledByDefault="true" enabledByDefault="true"
cleanupTool="true"
level="WEAK WARNING" level="WEAK WARNING"
language="kotlin" language="kotlin"
/> />
@@ -58,7 +58,7 @@ import org.jetbrains.kotlin.resolve.scopes.collectSyntheticExtensionProperties
import org.jetbrains.kotlin.synthetic.SyntheticJavaPropertyDescriptor import org.jetbrains.kotlin.synthetic.SyntheticJavaPropertyDescriptor
import org.jetbrains.kotlin.utils.addToStdlib.firstIsInstanceOrNull import org.jetbrains.kotlin.utils.addToStdlib.firstIsInstanceOrNull
class ConflictingExtensionPropertyInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool { class ConflictingExtensionPropertyInspection : AbstractKotlinInspection() {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor { override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
val file = session.file as? KtFile ?: return PsiElementVisitor.EMPTY_VISITOR val file = session.file as? KtFile ?: return PsiElementVisitor.EMPTY_VISITOR
val resolutionFacade = file.getResolutionFacade() val resolutionFacade = file.getResolutionFacade()
@@ -29,7 +29,7 @@ import org.jetbrains.kotlin.resolve.BindingContext
import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
import org.jetbrains.kotlin.types.TypeUtils import org.jetbrains.kotlin.types.TypeUtils
class NullChecksToSafeCallInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool { class NullChecksToSafeCallInspection : AbstractKotlinInspection() {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) = override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
object : KtVisitorVoid() { object : KtVisitorVoid() {
override fun visitBinaryExpression(expression: KtBinaryExpression) { override fun visitBinaryExpression(expression: KtBinaryExpression) {
@@ -21,7 +21,7 @@ import com.intellij.openapi.project.Project
import com.intellij.psi.PsiElementVisitor import com.intellij.psi.PsiElementVisitor
import org.jetbrains.kotlin.psi.* import org.jetbrains.kotlin.psi.*
class RedundantGetterInspection : AbstractKotlinInspection() { class RedundantGetterInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor { override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
return object : KtVisitorVoid() { return object : KtVisitorVoid() {
override fun visitPropertyAccessor(accessor: KtPropertyAccessor) { override fun visitPropertyAccessor(accessor: KtPropertyAccessor) {
@@ -23,7 +23,7 @@ import org.jetbrains.kotlin.idea.references.mainReference
import org.jetbrains.kotlin.lexer.KtTokens import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.psi.* import org.jetbrains.kotlin.psi.*
class RedundantSetterInspection : AbstractKotlinInspection() { class RedundantSetterInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor { override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
return object : KtVisitorVoid() { return object : KtVisitorVoid() {
override fun visitPropertyAccessor(accessor: KtPropertyAccessor) { override fun visitPropertyAccessor(accessor: KtPropertyAccessor) {
@@ -16,6 +16,7 @@
package org.jetbrains.kotlin.idea.inspections package org.jetbrains.kotlin.idea.inspections
import com.intellij.codeInspection.CleanupLocalInspectionTool
import com.intellij.codeInspection.IntentionWrapper import com.intellij.codeInspection.IntentionWrapper
import com.intellij.codeInspection.ProblemHighlightType import com.intellij.codeInspection.ProblemHighlightType
import com.intellij.codeInspection.ProblemsHolder import com.intellij.codeInspection.ProblemsHolder
@@ -31,7 +32,7 @@ import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
import org.jetbrains.kotlin.types.typeUtil.isNothing import org.jetbrains.kotlin.types.typeUtil.isNothing
import org.jetbrains.kotlin.types.typeUtil.isUnit import org.jetbrains.kotlin.types.typeUtil.isUnit
class RedundantUnitReturnTypeInspection : AbstractKotlinInspection() { class RedundantUnitReturnTypeInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor { override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
return object : KtVisitorVoid() { return object : KtVisitorVoid() {
override fun visitNamedFunction(function: KtNamedFunction) { override fun visitNamedFunction(function: KtNamedFunction) {
@@ -16,14 +16,13 @@
package org.jetbrains.kotlin.idea.inspections package org.jetbrains.kotlin.idea.inspections
import com.intellij.codeInspection.CleanupLocalInspectionTool
import com.intellij.codeInspection.LocalInspectionToolSession import com.intellij.codeInspection.LocalInspectionToolSession
import com.intellij.codeInspection.ProblemHighlightType import com.intellij.codeInspection.ProblemHighlightType
import com.intellij.codeInspection.ProblemsHolder import com.intellij.codeInspection.ProblemsHolder
import org.jetbrains.kotlin.lexer.KtTokens import org.jetbrains.kotlin.lexer.KtTokens
import org.jetbrains.kotlin.psi.* import org.jetbrains.kotlin.psi.*
class SuspiciousEqualsCombination : AbstractKotlinInspection(), CleanupLocalInspectionTool { class SuspiciousEqualsCombination : AbstractKotlinInspection() {
override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) = override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
object : KtVisitorVoid() { object : KtVisitorVoid() {
override fun visitBinaryExpression(expression: KtBinaryExpression) { override fun visitBinaryExpression(expression: KtBinaryExpression) {