diff --git a/compiler/tests/org/jetbrains/jet/JetLiteFixture.java b/compiler/tests/org/jetbrains/jet/JetLiteFixture.java index 87e8fba9150..1719cbf181d 100644 --- a/compiler/tests/org/jetbrains/jet/JetLiteFixture.java +++ b/compiler/tests/org/jetbrains/jet/JetLiteFixture.java @@ -38,7 +38,7 @@ public abstract class JetLiteFixture extends UsefulTestCase { } protected String getTestDataPath() { - return JetTestCaseBase.getTestDataPathBase(); + return JetTestCaseBuilder.getTestDataPathBase(); } public Project getProject() { @@ -49,9 +49,9 @@ public abstract class JetLiteFixture extends UsefulTestCase { protected void setUp() throws Exception { super.setUp(); myEnvironment = new JetCoreEnvironment(getTestRootDisposable()); - final File rtJar = new File(JetTestCaseBase.getHomeDirectory(), "compiler/testData/mockJDK-1.7/jre/lib/rt.jar"); + final File rtJar = new File(JetTestCaseBuilder.getHomeDirectory(), "compiler/testData/mockJDK-1.7/jre/lib/rt.jar"); myEnvironment.addToClasspath(rtJar); - myEnvironment.addToClasspath(new File(JetTestCaseBase.getHomeDirectory(), "compiler/testData/mockJDK-1.7/jre/lib/annotations.jar")); + myEnvironment.addToClasspath(new File(JetTestCaseBuilder.getHomeDirectory(), "compiler/testData/mockJDK-1.7/jre/lib/annotations.jar")); } @Override diff --git a/compiler/tests/org/jetbrains/jet/JetTestCaseBase.java b/compiler/tests/org/jetbrains/jet/JetTestCaseBuilder.java similarity index 75% rename from compiler/tests/org/jetbrains/jet/JetTestCaseBase.java rename to compiler/tests/org/jetbrains/jet/JetTestCaseBuilder.java index d3c3deb7373..05e88fb44e6 100644 --- a/compiler/tests/org/jetbrains/jet/JetTestCaseBase.java +++ b/compiler/tests/org/jetbrains/jet/JetTestCaseBuilder.java @@ -1,8 +1,6 @@ package org.jetbrains.jet; -import com.intellij.codeInsight.daemon.LightDaemonAnalyzerTestCase; import com.intellij.openapi.application.PathManager; -import com.intellij.openapi.projectRoots.Sdk; import junit.framework.Test; import junit.framework.TestSuite; import org.jetbrains.annotations.NotNull; @@ -17,42 +15,20 @@ import java.util.List; /** * @author abreslav */ -public abstract class JetTestCaseBase extends LightDaemonAnalyzerTestCase { - - private static FilenameFilter emptyFilter; - private String dataPath; - protected final String name; - - public JetTestCaseBase(String dataPath, String name) { - this.dataPath = dataPath; - this.name = name; - } - - @Override - protected String getTestDataPath() { - return getTestDataPathBase(); - } +public abstract class JetTestCaseBuilder { + private static FilenameFilter emptyFilter = new FilenameFilter() { + @Override + public boolean accept(File file, String name) { + return true; + } + }; public static String getTestDataPathBase() { return getHomeDirectory() + "/compiler/testData"; } public static String getHomeDirectory() { - return new File(PathManager.getResourceRoot(JetTestCaseBase.class, "/org/jetbrains/jet/JetTestCaseBase.class")).getParentFile().getParentFile().getParent(); - } - - protected String getDataPath() { - return dataPath; - } - - protected void setUp() throws Exception { - super.setUp(); - emptyFilter = new FilenameFilter() { - @Override - public boolean accept(File file, String name) { - return true; - } - }; + return new File(PathManager.getResourceRoot(JetTestCaseBuilder.class, "/org/jetbrains/jet/JetTestCaseBuilder.class")).getParentFile().getParentFile().getParent(); } public interface NamedTestFactory { diff --git a/compiler/tests/org/jetbrains/jet/cfg/JetControlFlowTest.java b/compiler/tests/org/jetbrains/jet/cfg/JetControlFlowTest.java index e7260983306..fa1de3d14cf 100644 --- a/compiler/tests/org/jetbrains/jet/cfg/JetControlFlowTest.java +++ b/compiler/tests/org/jetbrains/jet/cfg/JetControlFlowTest.java @@ -9,7 +9,7 @@ import junit.framework.Test; import junit.framework.TestSuite; import org.jetbrains.annotations.NotNull; import org.jetbrains.jet.JetLiteFixture; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.lang.cfg.LoopInfo; import org.jetbrains.jet.lang.cfg.pseudocode.*; import org.jetbrains.jet.lang.psi.*; @@ -394,7 +394,7 @@ public class JetControlFlowTest extends JetLiteFixture { public static TestSuite suite() { TestSuite suite = new TestSuite(); - suite.addTest(JetTestCaseBase.suiteForDirectory(JetTestCaseBase.getTestDataPathBase(), "/cfg/", true, new JetTestCaseBase.NamedTestFactory() { + suite.addTest(JetTestCaseBuilder.suiteForDirectory(JetTestCaseBuilder.getTestDataPathBase(), "/cfg/", true, new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { diff --git a/compiler/tests/org/jetbrains/jet/checkers/FullJetPsiCheckerTest.java b/compiler/tests/org/jetbrains/jet/checkers/FullJetPsiCheckerTest.java index 8d77de18fd9..48d36f9d52b 100644 --- a/compiler/tests/org/jetbrains/jet/checkers/FullJetPsiCheckerTest.java +++ b/compiler/tests/org/jetbrains/jet/checkers/FullJetPsiCheckerTest.java @@ -6,7 +6,7 @@ import junit.framework.Test; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.NotNull; import org.jetbrains.jet.JetLiteFixture; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.lang.diagnostics.DiagnosticUtils; import org.jetbrains.jet.lang.resolve.BindingContext; import org.jetbrains.jet.lang.resolve.java.AnalyzerFacade; @@ -97,7 +97,7 @@ public class FullJetPsiCheckerTest extends JetLiteFixture { */ public static Test suite() { - return JetTestCaseBase.suiteForDirectory(JetTestCaseBase.getTestDataPathBase(), "/checkerWithErrorTypes/full/", true, new JetTestCaseBase.NamedTestFactory() { + return JetTestCaseBuilder.suiteForDirectory(JetTestCaseBuilder.getTestDataPathBase(), "/checkerWithErrorTypes/full/", true, new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { diff --git a/compiler/tests/org/jetbrains/jet/checkers/QuickJetPsiCheckerTest.java b/compiler/tests/org/jetbrains/jet/checkers/QuickJetPsiCheckerTest.java index b76d37388c0..ebb5e91515e 100644 --- a/compiler/tests/org/jetbrains/jet/checkers/QuickJetPsiCheckerTest.java +++ b/compiler/tests/org/jetbrains/jet/checkers/QuickJetPsiCheckerTest.java @@ -6,7 +6,7 @@ import junit.framework.Test; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.NotNull; import org.jetbrains.jet.JetLiteFixture; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.lang.diagnostics.DiagnosticUtils; import org.jetbrains.jet.lang.psi.JetFile; import org.jetbrains.jet.lang.resolve.AnalyzingUtils; @@ -93,7 +93,7 @@ public class QuickJetPsiCheckerTest extends JetLiteFixture { // } public static Test suite() { - return JetTestCaseBase.suiteForDirectory(JetTestCaseBase.getTestDataPathBase(), "/checkerWithErrorTypes/quick", true, new JetTestCaseBase.NamedTestFactory() { + return JetTestCaseBuilder.suiteForDirectory(JetTestCaseBuilder.getTestDataPathBase(), "/checkerWithErrorTypes/quick", true, new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { diff --git a/compiler/tests/org/jetbrains/jet/parsing/JetParsingTest.java b/compiler/tests/org/jetbrains/jet/parsing/JetParsingTest.java index 6413d420c30..1a2dadff195 100644 --- a/compiler/tests/org/jetbrains/jet/parsing/JetParsingTest.java +++ b/compiler/tests/org/jetbrains/jet/parsing/JetParsingTest.java @@ -13,7 +13,7 @@ import junit.framework.Test; import junit.framework.TestSuite; import org.jetbrains.annotations.NonNls; import org.jetbrains.annotations.NotNull; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.lang.parsing.JetParserDefinition; import org.jetbrains.jet.lang.psi.JetElement; import org.jetbrains.jet.lang.psi.JetVisitorVoid; @@ -101,7 +101,7 @@ public class JetParsingTest extends ParsingTestCase { public static TestSuite suite() { TestSuite suite = new TestSuite(); - JetTestCaseBase.NamedTestFactory factory = new JetTestCaseBase.NamedTestFactory() { + JetTestCaseBuilder.NamedTestFactory factory = new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { @@ -109,8 +109,8 @@ public class JetParsingTest extends ParsingTestCase { } }; String prefix = JetParsingTest.getTestDataDir() + "/psi/"; - suite.addTest(JetTestCaseBase.suiteForDirectory(prefix, "/", false, factory)); - suite.addTest(JetTestCaseBase.suiteForDirectory(prefix, "examples", true, factory)); + suite.addTest(JetTestCaseBuilder.suiteForDirectory(prefix, "/", false, factory)); + suite.addTest(JetTestCaseBuilder.suiteForDirectory(prefix, "examples", true, factory)); return suite; } diff --git a/compiler/tests/org/jetbrains/jet/resolve/JetResolveTest.java b/compiler/tests/org/jetbrains/jet/resolve/JetResolveTest.java index 1880b23ef8d..ca206ae88c0 100644 --- a/compiler/tests/org/jetbrains/jet/resolve/JetResolveTest.java +++ b/compiler/tests/org/jetbrains/jet/resolve/JetResolveTest.java @@ -9,7 +9,7 @@ import com.intellij.psi.PsiMethod; import com.intellij.psi.search.GlobalSearchScope; import junit.framework.Test; import org.jetbrains.annotations.NotNull; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.lang.JetSemanticServices; import org.jetbrains.jet.lang.descriptors.ClassDescriptor; import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor; @@ -154,7 +154,7 @@ public class JetResolveTest extends ExtensibleResolveTestCase { } public static Test suite() { - return JetTestCaseBase.suiteForDirectory(getHomeDirectory() + "/compiler/testData/", "/resolve/", true, new JetTestCaseBase.NamedTestFactory() { + return JetTestCaseBuilder.suiteForDirectory(getHomeDirectory() + "/compiler/testData/", "/resolve/", true, new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { diff --git a/compiler/tests/org/jetbrains/jet/types/JetOverridingTest.java b/compiler/tests/org/jetbrains/jet/types/JetOverridingTest.java index 83896c8cfaa..4de8bd9a285 100644 --- a/compiler/tests/org/jetbrains/jet/types/JetOverridingTest.java +++ b/compiler/tests/org/jetbrains/jet/types/JetOverridingTest.java @@ -1,7 +1,7 @@ package org.jetbrains.jet.types; import org.jetbrains.jet.JetLiteFixture; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.JetTestUtils; import org.jetbrains.jet.lang.JetSemanticServices; import org.jetbrains.jet.lang.descriptors.FunctionDescriptor; @@ -32,7 +32,7 @@ public class JetOverridingTest extends JetLiteFixture { @Override protected String getTestDataPath() { - return JetTestCaseBase.getTestDataPathBase(); + return JetTestCaseBuilder.getTestDataPathBase(); } public void testBasic() throws Exception { diff --git a/compiler/tests/org/jetbrains/jet/types/JetTypeCheckerTest.java b/compiler/tests/org/jetbrains/jet/types/JetTypeCheckerTest.java index 22547f87bc3..aa914ef6bb3 100644 --- a/compiler/tests/org/jetbrains/jet/types/JetTypeCheckerTest.java +++ b/compiler/tests/org/jetbrains/jet/types/JetTypeCheckerTest.java @@ -5,7 +5,7 @@ import com.intellij.openapi.project.Project; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import org.jetbrains.jet.JetLiteFixture; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.JetTestUtils; import org.jetbrains.jet.lang.JetSemanticServices; import org.jetbrains.jet.lang.descriptors.*; @@ -51,7 +51,7 @@ public class JetTypeCheckerTest extends JetLiteFixture { @Override protected String getTestDataPath() { - return JetTestCaseBase.getTestDataPathBase(); + return JetTestCaseBuilder.getTestDataPathBase(); } public void testConstants() throws Exception { diff --git a/idea/tests/org/jetbrains/jet/checkers/JetPsiCheckerTest.java b/idea/tests/org/jetbrains/jet/checkers/JetPsiCheckerTest.java index 8aaef8089ea..608022b4a54 100644 --- a/idea/tests/org/jetbrains/jet/checkers/JetPsiCheckerTest.java +++ b/idea/tests/org/jetbrains/jet/checkers/JetPsiCheckerTest.java @@ -5,7 +5,7 @@ import com.intellij.openapi.projectRoots.Sdk; import junit.framework.Test; import junit.framework.TestSuite; import org.jetbrains.annotations.NotNull; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import org.jetbrains.jet.plugin.quickfix.PluginTestCaseBase; import java.io.File; @@ -55,21 +55,21 @@ public class JetPsiCheckerTest extends LightDaemonAnalyzerTestCase { public static Test suite() { TestSuite suite = new TestSuite(); - suite.addTest(JetTestCaseBase.suiteForDirectory(PluginTestCaseBase.getTestDataPathBase(), "/checker/", false, new JetTestCaseBase.NamedTestFactory() { + suite.addTest(JetTestCaseBuilder.suiteForDirectory(PluginTestCaseBase.getTestDataPathBase(), "/checker/", false, new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { return new JetPsiCheckerTest(dataPath, name); } })); - suite.addTest(JetTestCaseBase.suiteForDirectory(PluginTestCaseBase.getTestDataPathBase(), "/checker/regression/", false, new JetTestCaseBase.NamedTestFactory() { + suite.addTest(JetTestCaseBuilder.suiteForDirectory(PluginTestCaseBase.getTestDataPathBase(), "/checker/regression/", false, new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { return new JetPsiCheckerTest(dataPath, name); } })); - suite.addTest(JetTestCaseBase.suiteForDirectory(PluginTestCaseBase.getTestDataPathBase(), "/checker/infos/", false, new JetTestCaseBase.NamedTestFactory() { + suite.addTest(JetTestCaseBuilder.suiteForDirectory(PluginTestCaseBase.getTestDataPathBase(), "/checker/infos/", false, new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { diff --git a/idea/tests/org/jetbrains/jet/plugin/quickfix/JetQuickFixTest.java b/idea/tests/org/jetbrains/jet/plugin/quickfix/JetQuickFixTest.java index cea1007b691..fcf4fc91077 100644 --- a/idea/tests/org/jetbrains/jet/plugin/quickfix/JetQuickFixTest.java +++ b/idea/tests/org/jetbrains/jet/plugin/quickfix/JetQuickFixTest.java @@ -6,7 +6,7 @@ import com.intellij.openapi.projectRoots.Sdk; import junit.framework.Test; import junit.framework.TestSuite; import org.jetbrains.annotations.NotNull; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; import java.io.File; import java.io.FilenameFilter; @@ -49,7 +49,7 @@ public class JetQuickFixTest extends LightQuickFixTestCase { return false; } }; - JetTestCaseBase.NamedTestFactory namedTestFactory = new JetTestCaseBase.NamedTestFactory() { + JetTestCaseBuilder.NamedTestFactory namedTestFactory = new JetTestCaseBuilder.NamedTestFactory() { @NotNull @Override public Test createTest(@NotNull String dataPath, @NotNull String name) { @@ -60,14 +60,14 @@ public class JetQuickFixTest extends LightQuickFixTestCase { List subDirs = Arrays.asList(quickFixTestsFilter != null ? dir.list(quickFixTestsFilter) : dir.list()); Collections.sort(subDirs); for (String subDirName : subDirs) { - suite.addTest(JetTestCaseBase.suiteForDirectory(getTestDataPathBase(), subDirName, false, fileNameFilter, namedTestFactory)); + suite.addTest(JetTestCaseBuilder.suiteForDirectory(getTestDataPathBase(), subDirName, false, fileNameFilter, namedTestFactory)); } return suite; } public static String getTestDataPathBase() { - return JetTestCaseBase.getHomeDirectory() + "/idea/testData/quickfix/"; + return JetTestCaseBuilder.getHomeDirectory() + "/idea/testData/quickfix/"; } public String getName() { diff --git a/idea/tests/org/jetbrains/jet/plugin/quickfix/PluginTestCaseBase.java b/idea/tests/org/jetbrains/jet/plugin/quickfix/PluginTestCaseBase.java index abf84536c65..7a14d6e797c 100644 --- a/idea/tests/org/jetbrains/jet/plugin/quickfix/PluginTestCaseBase.java +++ b/idea/tests/org/jetbrains/jet/plugin/quickfix/PluginTestCaseBase.java @@ -2,14 +2,14 @@ package org.jetbrains.jet.plugin.quickfix; import com.intellij.openapi.projectRoots.Sdk; import com.intellij.openapi.projectRoots.impl.JavaSdkImpl; -import org.jetbrains.jet.JetTestCaseBase; +import org.jetbrains.jet.JetTestCaseBuilder; /** * @author yole */ public class PluginTestCaseBase { public static String getTestDataPathBase() { - return JetTestCaseBase.getHomeDirectory() + "/idea/testData"; + return JetTestCaseBuilder.getHomeDirectory() + "/idea/testData"; } public static Sdk jdkFromIdeaHome() {