[FIR] Implement FirNativeIdentifierChecker

* INVALID_CHARACTERS_NATIVE

compiler/fir/checkers/checkers-component-generator/src/org/jetbrains/kotlin/fir/checkers/generator/diagnostics/FirNativeDiagnosticsList.kt

@@ -5,8 +5,11 @@
 
 package org.jetbrains.kotlin.fir.checkers.generator.diagnostics
 
+import com.intellij.psi.PsiElement
+import org.jetbrains.kotlin.config.LanguageFeature
 import org.jetbrains.kotlin.fir.PrivateForInline
 import org.jetbrains.kotlin.fir.checkers.generator.diagnostics.model.DiagnosticList
+import org.jetbrains.kotlin.fir.checkers.generator.diagnostics.model.PositioningStrategy
 import org.jetbrains.kotlin.fir.symbols.impl.FirRegularClassSymbol
 import org.jetbrains.kotlin.name.FqName
 import org.jetbrains.kotlin.psi.KtDeclaration
@@ -30,5 +33,11 @@ object NATIVE_DIAGNOSTICS_LIST : DiagnosticList("FirNativeErrors") {
         val INAPPLICABLE_SHARED_IMMUTABLE_TOP_LEVEL by error<KtElement>()
         val INAPPLICABLE_THREAD_LOCAL by error<KtElement>()
         val INAPPLICABLE_THREAD_LOCAL_TOP_LEVEL by error<KtElement>()
+        val INVALID_CHARACTERS_NATIVE by deprecationError<PsiElement>(
+            LanguageFeature.ProhibitInvalidCharsInNativeIdentifiers,
+            PositioningStrategy.NAME_IDENTIFIER
+        ) {
+            parameter<String>("message")
+        }
     }
 }

compiler/fir/checkers/checkers.native/gen/org/jetbrains/kotlin/fir/analysis/diagnostics/native/FirNativeErrors.kt

@@ -5,7 +5,10 @@
 
 package org.jetbrains.kotlin.fir.analysis.diagnostics.native
 
+import com.intellij.psi.PsiElement
+import org.jetbrains.kotlin.config.LanguageFeature.ProhibitInvalidCharsInNativeIdentifiers
 import org.jetbrains.kotlin.diagnostics.*
+import org.jetbrains.kotlin.diagnostics.SourceElementPositioningStrategies
 import org.jetbrains.kotlin.diagnostics.rendering.RootDiagnosticRendererFactory
 import org.jetbrains.kotlin.fir.analysis.diagnostics.*
 import org.jetbrains.kotlin.fir.symbols.impl.FirRegularClassSymbol
@@ -28,6 +31,7 @@ object FirNativeErrors {
     val INAPPLICABLE_SHARED_IMMUTABLE_TOP_LEVEL by error0<KtElement>()
     val INAPPLICABLE_THREAD_LOCAL by error0<KtElement>()
     val INAPPLICABLE_THREAD_LOCAL_TOP_LEVEL by error0<KtElement>()
+    val INVALID_CHARACTERS_NATIVE by deprecationError1<PsiElement, String>(ProhibitInvalidCharsInNativeIdentifiers, SourceElementPositioningStrategies.NAME_IDENTIFIER)
 
     init {
         RootDiagnosticRendererFactory.registerFactory(FirNativeErrorsDefaultMessages)

compiler/fir/checkers/checkers.native/src/org/jetbrains/kotlin/fir/analysis/diagnostics/native/FirNativeErrorsDefaultMessages.kt

@@ -17,6 +17,7 @@ import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors.INAP
 import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors.INAPPLICABLE_THREAD_LOCAL_TOP_LEVEL
 import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors.INCOMPATIBLE_THROWS_INHERITED
 import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors.INCOMPATIBLE_THROWS_OVERRIDE
+import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors.INVALID_CHARACTERS_NATIVE
 import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors.MISSING_EXCEPTION_IN_THROWS_ON_SUSPEND
 import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors.THROWS_LIST_EMPTY
 
@@ -39,6 +40,7 @@ object FirNativeErrorsDefaultMessages : BaseDiagnosticRendererFactory() {
             "@ThreadLocal is applicable only to property with backing field, to property with delegation or to objects"
         )
         map.put(INAPPLICABLE_THREAD_LOCAL_TOP_LEVEL, "@ThreadLocal is applicable only to top level declarations")
+        map.put(INVALID_CHARACTERS_NATIVE, "Name {0}", TO_STRING)
 
         map.checkMissingMessages(FirNativeErrors)
     }

compiler/fir/checkers/checkers.native/src/org/jetbrains/kotlin/fir/analysis/native/checkers/FirNativeIdentifierChecker.kt

@@ -0,0 +1,55 @@
+/*
+ * Copyright 2010-2022 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.fir.analysis.native.checkers
+
+import org.jetbrains.kotlin.KtFakeSourceElementKind
+import org.jetbrains.kotlin.KtSourceElement
+import org.jetbrains.kotlin.diagnostics.DiagnosticReporter
+import org.jetbrains.kotlin.diagnostics.reportOn
+import org.jetbrains.kotlin.fir.analysis.checkers.SourceNavigator
+import org.jetbrains.kotlin.fir.analysis.checkers.context.CheckerContext
+import org.jetbrains.kotlin.fir.analysis.checkers.declaration.FirBasicDeclarationChecker
+import org.jetbrains.kotlin.fir.analysis.diagnostics.native.FirNativeErrors
+import org.jetbrains.kotlin.fir.declarations.*
+import org.jetbrains.kotlin.name.Name
+
+object FirNativeIdentifierChecker : FirBasicDeclarationChecker() {
+    // Also includes characters used by IR mangler (see MangleConstant).
+    private val invalidChars = setOf(
+        '.', ';', ',', '(', ')', '[', ']', '{', '}', '/', '<', '>',
+        ':', '\\', '$', '&', '~', '*', '?', '#', '|', '§', '%', '@',
+    )
+
+    override fun check(declaration: FirDeclaration, context: CheckerContext, reporter: DiagnosticReporter) {
+        val source = declaration.source
+        when (declaration) {
+            is FirRegularClass -> checkNameAndReport(declaration.name, source, context, reporter)
+            is FirSimpleFunction -> checkNameAndReport(declaration.name, source, context, reporter)
+            is FirTypeParameter -> checkNameAndReport(declaration.name, source, context, reporter)
+            is FirProperty -> checkNameAndReport(declaration.name, source, context, reporter)
+            is FirTypeAlias -> checkNameAndReport(declaration.name, source, context, reporter)
+            is FirValueParameter -> checkNameAndReport(declaration.name, source, context, reporter)
+            is FirEnumEntry -> checkNameAndReport(declaration.name, source, context, reporter)
+            else -> return
+        }
+    }
+
+    private fun checkNameAndReport(name: Name, source: KtSourceElement?, context: CheckerContext, reporter: DiagnosticReporter) {
+        if (source != null && source.kind !is KtFakeSourceElementKind && !name.isSpecial) {
+            val text = name.asString()
+            val message = when {
+                text.isEmpty() -> "should not be empty"
+                text.any { it in invalidChars } -> "contains illegal characters: " +
+                        invalidChars.intersect(text.toSet()).joinToString("", prefix = "\"", postfix = "\"")
+                else -> null
+            }
+
+            if (message != null) {
+                reporter.reportOn(source, FirNativeErrors.INVALID_CHARACTERS_NATIVE, message, context)
+            }
+        }
+    }
+}

compiler/fir/checkers/checkers.native/src/org/jetbrains/kotlin/fir/analysis/native/checkers/NativeDeclarationCheckers.kt

@@ -13,6 +13,7 @@ object NativeDeclarationCheckers : DeclarationCheckers() {
         get() = setOf(
             FirNativeThrowsChecker,
             FirNativeSharedImmutableChecker,
-            FirNativeThreadLocalChecker
+            FirNativeThreadLocalChecker,
+            FirNativeIdentifierChecker
         )
 }