azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check all modifiers for objects

Browse Source 
DeclarationsChecker didn't check visibility modifiers for objects
This commit is contained in:
Alexander Udalov
2012-12-03 19:04:59 +04:00
parent 7a3000ccac
commit 0a1907de11
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend/src/org/jetbrains/jet/lang/resolve/DeclarationsChecker.java
+1 -1
View File
@@ -64,7 +64,7 @@ public class DeclarationsChecker {
if (!bodiesResolveContext.completeAnalysisNeeded(objectDeclaration)) continue; if (!bodiesResolveContext.completeAnalysisNeeded(objectDeclaration)) continue;
checkObject(objectDeclaration); checkObject(objectDeclaration);
modifiersChecker.checkIllegalModalityModifiers(objectDeclaration); modifiersChecker.checkModifiersForDeclaration(objectDeclaration, objectDescriptor);
} }
Map<JetNamedFunction, SimpleFunctionDescriptor> functions = bodiesResolveContext.getFunctions(); Map<JetNamedFunction, SimpleFunctionDescriptor> functions = bodiesResolveContext.getFunctions();
compiler/testData/diagnostics/tests/IllegalModifiers.kt
+3
View File
@@ -19,3 +19,6 @@ class FinalClass() {
var j: Int = 1 var j: Int = 1
<!ILLEGAL_MODIFIER!>open<!> set(v: Int) {} <!ILLEGAL_MODIFIER!>open<!> set(v: Int) {}
} }
<!INCOMPATIBLE_MODIFIERS!>private<!> <!INCOMPATIBLE_MODIFIERS!>public<!> class C
<!INCOMPATIBLE_MODIFIERS!>private<!> <!INCOMPATIBLE_MODIFIERS!>public<!> object D