Redundant 'inner' modifier: fix false positive/negative with constructor call

#KT-40879 Fixed
#KT-41223 Fixed
#KT-41311 Fixed
#KT-41680 Fixed

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedClass.1.java

@@ -0,0 +1,3 @@
+public class Java {
+    public abstract class NestedClass {}
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedClass.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+class Test : Java() {
+    <caret>inner class Foo : Java.NestedClass()
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedInterface.1.java

@@ -0,0 +1,3 @@
+public class Java {
+    public interface NestedInterface {}
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedInterface.1.java.after

@@ -0,0 +1,3 @@
+public class Java {
+    public interface NestedInterface {}
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedInterface.kt

@@ -0,0 +1,3 @@
+class Test : Java() {
+    <caret>inner class Foo : Java.NestedInterface
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedInterface.kt.after

@@ -0,0 +1,3 @@
+class Test : Java() {
+    class Foo : Java.NestedInterface
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedStaticClass.1.java

@@ -0,0 +1,3 @@
+public class Java {
+    public abstract static class NestedStaticClass {}
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedStaticClass.1.java.after

@@ -0,0 +1,3 @@
+public class Java {
+    public abstract static class NestedStaticClass {}
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedStaticClass.kt

@@ -0,0 +1,3 @@
+class Test : Java() {
+    <caret>inner class Foo2 : Java.NestedStaticClass()
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/extendJavaNestedStaticClass.kt.after

@@ -0,0 +1,3 @@
+class Test : Java() {
+    class Foo2 : Java.NestedStaticClass()
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/hasConstructorCallOfOuterClassMember.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+class Test {
+    private <caret>inner class Inner {
+        val inner2 = Inner2()
+    }
+
+    private inner class Inner2
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/hasConstructorCallOfOuterClassMember2.kt

@@ -0,0 +1,8 @@
+// PROBLEM: none
+class Test {
+    private <caret>inner class Inner {
+        val inner2 = Inner2()
+    }
+
+    private inner class Inner2()
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/hasConstructorCallOfOuterClassMember3.kt

@@ -0,0 +1,7 @@
+class Test {
+    private <caret>inner class Inner {
+        val inner2 = Inner2()
+    }
+
+    private class Inner2
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/hasConstructorCallOfOuterClassMember3.kt.after

@@ -0,0 +1,7 @@
+class Test {
+    private class Inner {
+        val inner2 = Inner2()
+    }
+
+    private class Inner2
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/hasOuterClassMemberReferenceInSuperTypeConstructorCall.kt

@@ -0,0 +1,11 @@
+// PROBLEM: none
+abstract class Base(val x: Int)
+
+open class Outer(val x: Int) {
+    <caret>inner class Inner {
+        fun useX() {
+            object : Base(x) {
+            }
+        }
+    }
+}

idea/testData/inspectionsLocal/redundantInnerClassModifier/hasOuterClassMemberReferenceInSuperTypeConstructorCall2.kt

@@ -0,0 +1,6 @@
+// PROBLEM: none
+class A(private val someText: String) {
+    private <caret>inner class B() : C(someText)
+}
+
+abstract class C(private val text: String)