azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[K/JS] Prevent Char boxing on value or reference equals call

Browse Source
This commit is contained in:
Artem Kobzar
2023-04-13 08:39:03 +00:00
committed by Space Team
parent 8629c92c62
commit 09bccd272d
4 changed files with 52 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
js/js.tests/test/org/jetbrains/kotlin/js/testOld/utils/DirectiveTestUtils.java
+20 -6
View File
@@ -219,8 +219,8 @@ public class DirectiveTestUtils {
@Override
void processEntry(@NotNull JsNode ast, @NotNull ArgumentsHelper arguments) throws Exception {
String functionName = arguments.getNamedArgument("function");
String countStr = arguments.getNamedArgument("count");
int expectedCount = Integer.valueOf(countStr);
String countStr = arguments.findNamedArgument("count");
String maxCountStr = arguments.findNamedArgument("max");
JsFunction function = AstSearchUtil.getFunction(ast, functionName);
List<T> nodes = collectInstances(klass, function.getBody());
@@ -230,10 +230,24 @@ public class DirectiveTestUtils {
actualCount += getActualCountFor(node, arguments);
}
String message = "Function " + functionName + " contains " + actualCount +
" nodes of type " + klass.getName() +
", but expected count is " + expectedCount;
assertEquals(message, expectedCount, actualCount);
if (countStr != null) {
int expectedCount = Integer.valueOf(countStr);
String message = "Function " + functionName + " contains " + actualCount +
" nodes of type " + klass.getName() +
", but expected count is " + expectedCount;
assertEquals(message, expectedCount, actualCount);
} else if (maxCountStr != null) {
int expectedCount = Integer.valueOf(maxCountStr);
String message = "Function " + functionName + " contains " + actualCount +
" nodes of type " + klass.getName() +
", but expected max is " + expectedCount;
assertTrue(message, expectedCount >= actualCount);
} else {
throw new IllegalArgumentException("'max' or 'count' argument should be provided");
}
}
protected int getActualCountFor(@NotNull T node, @NotNull ArgumentsHelper arguments) {
js/js.translator/testData/box/char/charEquals.kt
Vendored
+7 -1
View File
@@ -1,15 +1,21 @@
// EXPECTED_REACHABLE_NODES: 1372
package foo
// CHECK_NEW_COUNT: function=box max=6
fun box(): String {
assertEquals(true, 'A' == 'A')
assertEquals(false, 'A' != 'A')
assertEquals(false, 'A' == 'B')
assertEquals(true, 'A' != 'B')
assertEquals(false, ('A' as Any) == (65 as Any))
assertEquals(true, ('A' as Any) != (65 as Any))
assertEquals(true, 'A' === 'A')
assertEquals(false, 'A' !== 'A')
assertEquals(false, 'A' === 'B')
assertEquals(true, 'A' !== 'B')
assertEquals(false, ('A' as Any) === (65 as Any))
assertEquals(true, ('A' as Any) !== (65 as Any))
assertTrue(bar('Q'))
assertFalse(bar('W'))