FirDefaultParametersResolver: process imported from objects properly

#KT-49083 Fixed

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosisCompilerFirTestdataTestGenerated.java

@@ -5069,6 +5069,12 @@ public class DiagnosisCompilerFirTestdataTestGenerated extends AbstractDiagnosis
                 runTest("compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/DailyAggregatedDoubleFactor.kt");
             }
 
+            @Test
+            @TestMetadata("defaultParameterFromBase.kt")
+            public void testDefaultParameterFromBase() throws Exception {
+                runTest("compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/defaultParameterFromBase.kt");
+            }
+
             @Test
             @TestMetadata("EnumWithToString.kt")
             public void testEnumWithToString() throws Exception {

compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/defaultParameterFromBase.fir.txt

@@ -0,0 +1,22 @@
+FILE: defaultParameterFromBase.kt
+    public open class Base : R|kotlin/Any| {
+        public constructor(): R|Base| {
+            super<R|kotlin/Any|>()
+        }
+
+        public open fun foo(arg: R|kotlin/Int|, def: R|kotlin/String| = String()): R|kotlin/Unit| {
+        }
+
+    }
+    public final object Derived : R|Base| {
+        private constructor(): R|Derived| {
+            super<R|Base|>()
+        }
+
+        public final override fun foo(arg: R|kotlin/Int|, def: R|kotlin/String|): R|kotlin/Unit| {
+        }
+
+    }
+    public final fun test(): R|kotlin/Unit| {
+        Q|Derived|.R|/Derived.foo|(Int(42))
+    }

compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/defaultParameterFromBase.kt

@@ -0,0 +1,11 @@
+import Derived.foo
+
+open class Base {
+    open fun foo(arg: Int, def: String = "") {}
+}
+object Derived : Base() {
+    override fun foo(arg: Int, def: String) {}
+}
+fun test() {
+    foo(42) // No value passed for parameter 'def'
+}

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirDiagnosticTestGenerated.java

@@ -5069,6 +5069,12 @@ public class FirDiagnosticTestGenerated extends AbstractFirDiagnosticTest {
                 runTest("compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/DailyAggregatedDoubleFactor.kt");
             }
 
+            @Test
+            @TestMetadata("defaultParameterFromBase.kt")
+            public void testDefaultParameterFromBase() throws Exception {
+                runTest("compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/defaultParameterFromBase.kt");
+            }
+
             @Test
             @TestMetadata("EnumWithToString.kt")
             public void testEnumWithToString() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirDiagnosticsWithLightTreeTestGenerated.java

@@ -5069,6 +5069,12 @@ public class FirDiagnosticsWithLightTreeTestGenerated extends AbstractFirDiagnos
                 runTest("compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/DailyAggregatedDoubleFactor.kt");
             }
 
+            @Test
+            @TestMetadata("defaultParameterFromBase.kt")
+            public void testDefaultParameterFromBase() throws Exception {
+                runTest("compiler/fir/analysis-tests/testData/resolveWithStdlib/intellij/defaultParameterFromBase.kt");
+            }
+
             @Test
             @TestMetadata("EnumWithToString.kt")
             public void testEnumWithToString() throws Exception {

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/FirDefaultParametersResolver.kt

@@ -8,26 +8,36 @@ package org.jetbrains.kotlin.fir.resolve
 import org.jetbrains.kotlin.fir.FirSession
 import org.jetbrains.kotlin.fir.FirSessionComponent
 import org.jetbrains.kotlin.fir.declarations.FirFunction
+import org.jetbrains.kotlin.fir.declarations.FirSimpleFunction
 import org.jetbrains.kotlin.fir.declarations.FirValueParameter
-import org.jetbrains.kotlin.fir.scopes.FirScope
+import org.jetbrains.kotlin.fir.resolve.substitution.ConeSubstitutor
-import org.jetbrains.kotlin.fir.scopes.FirTypeScope
+import org.jetbrains.kotlin.fir.scopes.*
-import org.jetbrains.kotlin.fir.scopes.ProcessorAction
+import org.jetbrains.kotlin.fir.scopes.impl.FirAbstractImportingScope
-import org.jetbrains.kotlin.fir.scopes.processOverriddenFunctions
-import org.jetbrains.kotlin.fir.symbols.impl.FirNamedFunctionSymbol
 
 class FirDefaultParametersResolver : FirSessionComponent {
     fun declaresDefaultValue(
+        session: FirSession,
+        scopeSession: ScopeSession,
         valueParameter: FirValueParameter,
         function: FirFunction,
         originScope: FirScope?,
         index: Int,
     ): Boolean {
         if (valueParameter.defaultValue != null) return true
-        if (originScope !is FirTypeScope) return false
+        if (function !is FirSimpleFunction) return false
-        val symbol = function.symbol as? FirNamedFunctionSymbol ?: return false
+        val symbol = function.symbol
+        val typeScope = when (originScope) {
+            is FirTypeScope -> originScope
+            // imported from object case
+            is FirAbstractImportingScope -> {
+                val containingClass = function.getContainingClass(session) ?: return false
+                containingClass.scopeForClass(ConeSubstitutor.Empty, session, scopeSession)
+            }
+            else -> return false
+        }
         var result = false
 
-        originScope.processOverriddenFunctions(symbol) { overridden ->
+        typeScope.processOverriddenFunctions(symbol) { overridden ->
             if (overridden.fir.valueParameters[index].defaultValue != null) {
                 result = true
                 return@processOverriddenFunctions ProcessorAction.STOP

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/ResolveUtils.kt

@@ -446,7 +446,7 @@ private fun initialTypeOfCandidate(candidate: Candidate, typeRef: FirResolvedTyp
     return candidate.substitutor.substituteOrSelf(typeRef.type)
 }
 
-fun FirCallableDeclaration.getContainingClass(session: FirSession): FirRegularClass? = this.containingClassForStaticMemberAttr?.let { lookupTag ->
+fun FirCallableDeclaration.getContainingClass(session: FirSession): FirRegularClass? = this.containingClass()?.let { lookupTag ->
     session.symbolProvider.getSymbolByLookupTag(lookupTag)?.fir as? FirRegularClass
 }
 

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/calls/FirArgumentsToParametersMapper.kt

@@ -259,12 +259,15 @@ private class FirCallArgumentsProcessor(
 
         for ((index, parameter) in parameters.withIndex()) {
             if (!result.containsKey(parameter)) {
-                if (bodyResolveComponents.session.defaultParameterResolver.declaresDefaultValue(parameter, function, originScope, index)) {
+                when {
-                    result[parameter] = ResolvedCallArgument.DefaultArgument
+                    bodyResolveComponents.session.defaultParameterResolver.declaresDefaultValue(
-                } else if (parameter.isVararg) {
+                        useSiteSession, bodyResolveComponents.scopeSession, parameter, function, originScope, index
-                    result[parameter] = ResolvedCallArgument.VarargArgument(emptyList())
+                    ) ->
-                } else {
+                        result[parameter] = ResolvedCallArgument.DefaultArgument
-                    addDiagnostic(NoValueForParameter(parameter, function))
+                    parameter.isVararg ->
+                        result[parameter] = ResolvedCallArgument.VarargArgument(emptyList())
+                    else ->
+                        addDiagnostic(NoValueForParameter(parameter, function))
                 }
             }
         }