[JS IR] Don't concatenate string template segments with '' when possible

If concatenating with an empty string is a sure no-op, just don't do it.
This commit is contained in:
Sergej Jaskiewicz
2021-11-18 20:13:57 +03:00
committed by Space
parent cad57e693f
commit 060074a9d6
3 changed files with 38 additions and 2 deletions
@@ -13,6 +13,7 @@ import org.jetbrains.kotlin.ir.backend.js.utils.emptyScope
import org.jetbrains.kotlin.ir.backend.js.utils.getJsNameOrKotlinName
import org.jetbrains.kotlin.ir.declarations.*
import org.jetbrains.kotlin.ir.expressions.*
import org.jetbrains.kotlin.ir.types.isString
import org.jetbrains.kotlin.ir.types.isUnit
import org.jetbrains.kotlin.ir.util.isEffectivelyExternal
import org.jetbrains.kotlin.ir.util.isEnumClass
@@ -68,7 +69,15 @@ class IrElementToJsExpressionTransformer : BaseIrElementToJsNodeTransformer<JsEx
override fun visitStringConcatenation(expression: IrStringConcatenation, context: JsGenerationContext): JsExpression {
// TODO revisit
return expression.arguments.fold<IrExpression, JsExpression>(JsStringLiteral("")) { jsExpr, irExpr ->
val firstArgument = expression.arguments.firstOrNull()
val (head, tail) = if (firstArgument?.type?.isString() == true) {
Pair(firstArgument.accept(this, context), expression.arguments.asSequence().drop(1))
} else {
Pair(JsStringLiteral(""), expression.arguments.asSequence())
}
return tail.fold(head) { jsExpr, irExpr ->
JsBinaryOperation(
JsBinaryOperator.ADD,
jsExpr,