Fix receiver inconsistency when builder inference restriction disabled

In 154e53c701 update of
extensionReceiverArgument in resolvedCall was accidentally moved into
language feature dependant block

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosisCompilerTestFE10TestdataTestGenerated.java

@@ -14453,6 +14453,12 @@ public class DiagnosisCompilerTestFE10TestdataTestGenerated extends AbstractDiag
                     runTest("compiler/testData/diagnostics/tests/inference/builderInference/multiLambdaRestrictionDisabled.kt");
                 }
 
+                @Test
+                @TestMetadata("noBuilderInferenceRestrictionReceiverInconsistency.kt")
+                public void testNoBuilderInferenceRestrictionReceiverInconsistency() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/inference/builderInference/noBuilderInferenceRestrictionReceiverInconsistency.kt");
+                }
+
                 @Test
                 @TestMetadata("propertySubstitution.kt")
                 public void testPropertySubstitution() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsTestGenerated.java

@@ -14453,6 +14453,12 @@ public class FirOldFrontendDiagnosticsTestGenerated extends AbstractFirDiagnosti
                     runTest("compiler/testData/diagnostics/tests/inference/builderInference/multiLambdaRestrictionDisabled.kt");
                 }
 
+                @Test
+                @TestMetadata("noBuilderInferenceRestrictionReceiverInconsistency.kt")
+                public void testNoBuilderInferenceRestrictionReceiverInconsistency() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/inference/builderInference/noBuilderInferenceRestrictionReceiverInconsistency.kt");
+                }
+
                 @Test
                 @TestMetadata("propertySubstitution.kt")
                 public void testPropertySubstitution() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsWithLightTreeTestGenerated.java

@@ -14453,6 +14453,12 @@ public class FirOldFrontendDiagnosticsWithLightTreeTestGenerated extends Abstrac
                     runTest("compiler/testData/diagnostics/tests/inference/builderInference/multiLambdaRestrictionDisabled.kt");
                 }
 
+                @Test
+                @TestMetadata("noBuilderInferenceRestrictionReceiverInconsistency.kt")
+                public void testNoBuilderInferenceRestrictionReceiverInconsistency() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/inference/builderInference/noBuilderInferenceRestrictionReceiverInconsistency.kt");
+                }
+
                 @Test
                 @TestMetadata("propertySubstitution.kt")
                 public void testPropertySubstitution() throws Exception {

compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/components/ResolutionParts.kt

@@ -663,23 +663,23 @@ internal object CheckReceivers : ResolutionPart() {
             )
 
             1 -> {
+                var extensionReceiverArgument = resolvedCall.extensionReceiverArgument
+                if (extensionReceiverArgument == null) {
+                    extensionReceiverArgument = chooseExtensionReceiverCandidate() ?: return
+                    resolvedCall.extensionReceiverArgument = extensionReceiverArgument
+                }
                 val checkBuilderInferenceRestriction =
                     !callComponents.languageVersionSettings
                         .supportsFeature(LanguageFeature.NoBuilderInferenceWithoutAnnotationRestriction)
-                if (checkBuilderInferenceRestriction) {
+                if (checkBuilderInferenceRestriction &&
-                    var extensionReceiverArgument = resolvedCall.extensionReceiverArgument
+                    extensionReceiverArgument.receiver.receiverValue.type is StubTypeForBuilderInference
-                    if (extensionReceiverArgument == null) {
+                ) {
-                        extensionReceiverArgument = chooseExtensionReceiverCandidate() ?: return
+                    addDiagnostic(
-                        resolvedCall.extensionReceiverArgument = extensionReceiverArgument
+                        StubBuilderInferenceReceiver(
-                    }
+                            extensionReceiverArgument,
-                    if (extensionReceiverArgument.receiver.receiverValue.type is StubTypeForBuilderInference) {
+                            candidateDescriptor.extensionReceiverParameter!!
-                        addDiagnostic(
-                            StubBuilderInferenceReceiver(
-                                extensionReceiverArgument,
-                                candidateDescriptor.extensionReceiverParameter!!
-                            )
                         )
-                    }
+                    )
                 }
                 checkReceiver(
                     resolvedCall.extensionReceiverArgument,

compiler/testData/diagnostics/tests/inference/builderInference/noBuilderInferenceRestrictionReceiverInconsistency.kt

@@ -0,0 +1,15 @@
+// FIR_IDENTICAL
+// SKIP_TXT
+// WITH_STDLIB
+// LANGUAGE: +NoBuilderInferenceWithoutAnnotationRestriction
+
+class A
+class B
+
+var B.foo: Boolean
+    get() = true
+    set(value) {}
+
+private fun A.bar(b: B) {
+    b.foo = true
+}

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/DiagnosticTestGenerated.java

@@ -14459,6 +14459,12 @@ public class DiagnosticTestGenerated extends AbstractDiagnosticTest {
                     runTest("compiler/testData/diagnostics/tests/inference/builderInference/multiLambdaRestrictionDisabled.kt");
                 }
 
+                @Test
+                @TestMetadata("noBuilderInferenceRestrictionReceiverInconsistency.kt")
+                public void testNoBuilderInferenceRestrictionReceiverInconsistency() throws Exception {
+                    runTest("compiler/testData/diagnostics/tests/inference/builderInference/noBuilderInferenceRestrictionReceiverInconsistency.kt");
+                }
+
                 @Test
                 @TestMetadata("propertySubstitution.kt")
                 public void testPropertySubstitution() throws Exception {